The title of the login page ("Login at mydomain") should be configurable via UCR.
f6ede8b35a Bug #51718: yaml 8f7df30272 Bug #51718: debian changelog 63d139f3d3 Bug #51718: make the title of the login page configurable Successful build Package: univention-management-console Version: 11.0.4-92A~4.4.0.202007231346 Branch: ucs_4.4-0 Scope: errata4.4-5
Reopen: 03_ucr.63checkucrwarning fails http://jenkins.knut.univention.de:8080/job/UCS-4.4/job/UCS-4.4-5/job/AutotestJoin/lastCompletedBuild/SambaVersion=s4,Systemrolle=member/testReport/03_ucr/63checkucrwarning/member097/
This were half the failing test today [4.4-5] ea8fd3a57e Bug #51718: make the title of the login page configurable test/ucs-test/tests/03_ucr/63checkucrwarning | 1 + 1 file changed, 1 insertion(+) [4.4-5] a0af4db8df Bug #51718: make the title of the login page configurable test/ucs-test/debian/changelog | 6 ++++++ 1 file changed, 6 insertions(+) Package: ucs-test Version: 9.0.4-16A~4.4.0.202007241051 Branch: ucs_4.4-0 Scope: errata4.4-5
Please don't introduce a new meta.json while there is already an existing one, where the data can simply be added.
Question: The reason why we make it configurable is that the BSI security guidelines don't want domainnames / fqdns to be exposed? If yes, then this is still exposed in "/univention/get/meta".
(In reply to Florian Best from comment #4) > Please don't introduce a new meta.json while there is already an existing > one, where the data can simply be added. We thought it would be better to not flood the meta.json with information that is only needed for the login page in this case. If that is the point of the meta.json (to be used as a global storage for different pages) then i guess we can change it. Is there another reason to use the 'global' meta.json? (In reply to Florian Best from comment #5) > Question: The reason why we make it configurable is that the BSI security > guidelines don't want domainnames / fqdns to be exposed? > > If yes, then this is still exposed in "/univention/get/meta". Yes this was communicated and so far this does not seem to be a problem. That would be a different bug.
(In reply to Johannes Keiser from comment #6) > (In reply to Florian Best from comment #4) > > Please don't introduce a new meta.json while there is already an existing > > one, where the data can simply be added. > > We thought it would be better to not flood the meta.json with information > that is only needed for the login page in this case. If that is the point of > the meta.json (to be used as a global storage for different pages) then i > guess we can change it. Is there another reason to use the 'global' > meta.json? The existing meta.json contains already data for the login dialog, e.g. login_links. I would like to eliminate a second unnecessary HTTP request because the old meta.json is also fetched on the login page. And I would like to keep the overview by not having more than 1 place with metadata. > (In reply to Florian Best from comment #5) > > Question: The reason why we make it configurable is that the BSI security > > guidelines don't want domainnames / fqdns to be exposed? > > > > If yes, then this is still exposed in "/univention/get/meta". > > Yes this was communicated and so far this does not seem to be a problem. > That would be a different bug. OK. I thought that was solved by a javascript hook.
258e1aedbe Bug #51718: yaml e0922e22f0 Bug #51718: debian changelog 9db861dac9 Bug #51718: use existing meta.json Successful build Package: univention-management-console Version: 11.0.4-94A~4.4.0.202007281621 Branch: ucs_4.4-0 Scope: errata4.4-5
5adfd744e1 Bug #51718: yaml b34186f976 Bug #51718: debian changelog 7bd54a200e Bug #51718: fix typo and redundant ucr var 1ae65ffe10 Bug #51718: yaml f4ccbef6f7 Bug #51718: debian changelog 2e4af36b34 Bug #51718: login title is configurable via ucr Successful build Package: univention-management-console Version: 11.0.4-96A~4.4.0.202007291436 Branch: ucs_4.4-0 Scope: errata4.4-5 Successful build Package: univention-saml Version: 6.0.2-46A~4.4.0.202007291436 Branch: ucs_4.4-0 Scope: errata4.4-5
What I tested: Classic login with and without custom text: OK SAML login with and without custom text: OK YAML: OK -> verified
<https://errata.software-univention.de/#/?erratum=4.4x684> <https://errata.software-univention.de/#/?erratum=4.4x685>
E:0004-12: conffiles/etc/simplesamlphp/univentiontheme/dictionaries/login.translation.json: template file contains variables that are not registered in file entry: - domainname E:0004-12: conffiles/etc/simplesamlphp/univentiontheme/dictionaries/login.definition.json: template file contains variables that are not registered in file entry: - domainname → In theory this is a REOPEN.