Bug 51739 - Regression: /etc/default/libvirtd not created during installation
Regression: /etc/default/libvirtd not created during installation
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UMC - Virtual machines (UVMM)
UCS 4.4
Other Linux
: P5 normal (vote)
: UCS 4.4-5-errata
Assigned To: Philipp Hahn
Florian Best
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2020-07-29 08:59 CEST by Dirk Schnick
Modified: 2020-08-05 15:15 CEST (History)
2 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 5: Major Usability: Impairs usability in key scenarios
Who will be affected by this bug?: 1: Will affect a very few installed domains
How will those affected feel about the bug?: 5: Blocking further progress on the daily work
User Pain: 0.143
Enterprise Customer affected?: Yes
School Customer affected?: Yes
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number: 2020072321000546
Bug group (optional): Regression
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Schnick univentionstaff 2020-07-29 08:59:40 CEST
UVMM can not connect to any physical host as the option -l of libvirtd is missing. ucr commit /etc/default/libvirtd seems to be missing during installation.

User need to manual execute

ucr commit /etc/default/libvirtd

after installation to get it working until this will be fixed.
Comment 1 Philipp Hahn univentionstaff 2020-07-29 17:15:53 CEST
The underlying problem will be fixed by Bug #30127 with UCS-5.
The documentation <https://docs.software-univention.de/developer-reference-4.4.html#ucr:module>:

on registration: changes=Dict[str, Optional[str]]
on change: changes=Dict[str, Tuple[Optional[str], Optional[str]]
Comment 2 Erik Damrose univentionstaff 2020-07-29 17:27:24 CEST
This basically makes installing and using a KVM node very hard, because one has to figure out that the /etc/default/libvirtd file is not written upon package installation.

That is a regression, from f3f96e050ed Bug #51215, UCS 4.4-4 errata 596

The issue is that Exception handling was expanded in the commit, but not all possible Exceptions are handled - TypeError is one of them.
As all UCR modules are executed upon installation, but with a different changeset than a during a regular ucr set, this broke the template and module import, all remaining UCR templates for the u-virtual-machine-manager-node-common were not installed.

The error message during package installation while the debhelper is called is not very helpful, for completeness here it is:

univention-virtual-machine-manager-node-common (7.0.1-6A~4.4.0.202005041337) wird eingerichtet ...
Module: uvmm_restore
E: your request could not be fulfilled
try `univention-config-registry --help` for more information



ff152509d5 Bug #51739: Fix Exception handling in uvmm_restore ucr module.
88ae399cff Bug #51739: yaml

QA: Please also check if this fixes updating from a broken package state with the file /etc/default/libvirtd not being present.
Comment 3 Florian Best univentionstaff 2020-07-29 17:31:31 CEST
Sorry, for the regression!
Comment 4 Philipp Hahn univentionstaff 2020-07-30 12:23:35 CEST
OK: 88ae399cff17d141baeca12f6d359139cf737a1d → 85cf32c26afd924fe066073fc5530f449f55f00c
OK: errata-announce  -V --onyl univention-virtual-machine-manager-node.yaml
OK: univention-virtual-machine-manager-node.yaml

OK: ff152509d5b7f494ec13e400d2993362d4c0f35f

Old:
> univention-virtual-machine-manager-node-common (7.0.1-6A~4.4.0.202005041337) wird eingerichtet ...
> Module: uvmm_restore
> E: your request could not be fulfilled
> try `univention-config-registry --help` for more information

FAIL: /etc/default/libvirtd is missing
FAIL: systemctl status libvirtd.service

Upgrade:
OK: apt install -t apt univention-virtual-machine-manager-node-common
OK: dpkg -L univention-virtual-machine-manager-node-common | sed -ne 's,/etc/univention/templates/files/,/,p' | xargs ls -ld
~OK: libvirtd.service is not automatically restarted, so users need to manually do that or reboot the server.
OK: systemctl restart libvirtd.service

Install:
FAIL: apt install -t apt --no-install-recommends univention-virtual-machine-manager-node-common
> univention-virtual-machine-manager-node-common (7.0.1-7A~4.4.0.202007291719) wird eingerichtet ...
> Module: uvmm_restore
> 'NoneType' object has no attribute 'endswith'
OK: dpkg -L univention-virtual-machine-manager-node-common | sed -ne 's,/etc/univention/templates/files/,/,p' | xargs ls -ld

OK:
univention-virtual-machine-manager-node-common (7.0.1-7) wird eingerichtet ...
Module: uvmm_restore


[4.4-5] c8cd75052f Bug #51739 uvmm-node: Fix initial install
 .../conffiles/uvmm_restore.py                          | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

Package: univention-virtual-machine-manager-node
Version: 7.0.1-7A~4.4.0.202007301220
Branch: ucs_4.4-0
Scope: errata4.4-5

[4.4-5] 1c74fa51e1 Bug #51739: univention-virtual-machine-manager-node 7.0.1-7A~4.4.0.202007301220
 doc/errata/staging/univention-virtual-machine-manager-node.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 5 Florian Best univentionstaff 2020-07-31 09:32:02 CEST
OK: new installation
OK: upgrade
OK: advisory