Bug 51799 - Respect proxy settings during setup (setup-join.sh)
Respect proxy settings during setup (setup-join.sh)
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: System setup
UCS 4.4
Other Linux
: P5 normal (vote)
: UCS 4.4-6
Assigned To: Felix Botner
Erik Damrose
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2020-08-10 13:09 CEST by Felix Botner
Modified: 2020-10-05 09:06 CEST (History)
2 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 6: Setup Problem: Issue for the setup process
Who will be affected by this bug?: 2: Will only affect a few installed domains
How will those affected feel about the bug?: 5: Blocking further progress on the daily work
User Pain: 0.343
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Felix Botner univentionstaff 2020-08-10 13:09:02 CEST
During the system setup (setup-join.sh) we set the proxy UCR variables according to the profile, but not as environment variables during the setup itself. So all scripts after 30_net are missing the proxy settings.

Maybe we need something like this:

diff --git a/base/univention-system-setup/usr/lib/univention-system-setup/scripts/setup-join.sh b/base/univention-system-setup/usr/lib/univention-system-setup/scripts/setup-join.sh
index 5ee1def..fe34d82 100755
--- a/base/univention-system-setup/usr/lib/univention-system-setup/scripts/setup-join.sh
+++ b/base/univention-system-setup/usr/lib/univention-system-setup/scripts/setup-join.sh
@@ -205,6 +205,9 @@ fi
 # Do network stuff
 echo "Starting re-configuration of network"
 run-parts -v -a --network-only -a --appliance-mode -- /usr/lib/univention-system-setup/scripts/30_net
+eval "$(ucr shell proxy/http proxy/https proxy/no_proxy)"
+test -n $proxy_http && export http_proxy=$proxy_http
+test -n $proxy_no_proxy && export no_proxy=$proxy_no_proxy
 
 run-parts -v /usr/lib/univention-system-setup/scripts/35_timezone
Comment 1 Felix Botner univentionstaff 2020-09-16 14:48:58 CEST
453f0c7ae45d09bf153b0f4b53b05d9abb8daf0a - univention-system-setup (export proxy settings as env variables)
c92b3ee66359ab59a16529cb5f7c18de15bb47d6 - changelog


Successful build
Package: univention-system-setup
Version: 12.0.2-27A~4.4.0.202009161441
Branch: ucs_4.4-0
Scope: ucs4.4-6
Comment 2 Erik Damrose univentionstaff 2020-09-20 17:25:25 CEST
OK: env variabes are set correctly in scripts called by setup-join
OK: changelog
Verified
Comment 3 Erik Damrose univentionstaff 2020-10-05 09:06:04 CEST
UCS 4.4-6 has been released:
 https://docs.software-univention.de/release-notes-4.4-6-en.html
 https://docs.software-univention.de/release-notes-4.4-6-de.html

If this error occurs again, please use the "Clone This Bug" option.