Bug 51973 - Remove managedclient, fatclient, mobileclient, policies/thinclient
Remove managedclient, fatclient, mobileclient, policies/thinclient
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UDM (Generic)
UCS 5.0
Other Linux
: P5 normal (vote)
: UCS 5.0
Assigned To: Philipp Hahn
Florian Best
:
Depends on: 51655
Blocks:
  Show dependency treegraph
 
Reported: 2020-09-08 14:59 CEST by Florian Best
Modified: 2021-05-25 16:00 CEST (History)
2 users (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): API change, Cleanup
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Best univentionstaff 2020-09-08 14:59:22 CEST
The UDM modules and system roles computers/managedclient, computers/fatclient, computers/mobileclient and policies/thinclient are obsolete and should be removed.
Comment 1 Ingo Steuwer univentionstaff 2020-09-16 08:49:38 CEST
I think we can also remove ucc:

  computers/ucc
  policies/ucc_computer
  policies/ucc_desktop
  policies/ucc_software
  policies/ucc_user
  settings/ucc_image
  settings/ucc_session
Comment 2 Philipp Hahn univentionstaff 2020-09-16 08:58:19 CEST
(In reply to Ingo Steuwer from comment #1)
> I think we can also remove ucc:

UCC has support until 2021-04-30, but only for UCS-4, so removing it for UCS-5 looks okay.
@Erik ?
Comment 3 Erik Damrose univentionstaff 2020-09-16 09:09:30 CEST
> UCC has support until 2021-04-30, but only for UCS-4, so removing it for
> UCS-5 looks okay.

I agree.
Comment 5 Philipp Hahn univentionstaff 2020-09-16 10:03:35 CEST
The UDM modules are not part of UCS, but in <https://git.knut.univention.de/univention/ucc-integration/-/tree/3.0/ucs-4.2/ucc-management-integration>

I removed all remaining references to UCC:

[feature/ucs5] 82f141c931 Bug #51973: Remove UCC traces
 base/univention-ssl/debian/univention-ssl.postinst                | 2 +-
 .../debian/univention-ssl.univention-config-registry-variables    | 4 ++--
 .../umc/python/setup/netconf/modules/RewriteUcr.py                | 3 ---
 doc/manual/domain-ldap-de.xml                                     | 8 --------
 doc/manual/domain-ldap-en.xml                                     | 8 --------
 doc/quickstart/quickstart-de-4.4.xml                              | 8 +-------
 doc/quickstart/quickstart-en-4.4.xml                              | 8 --------
 management/univention-appcenter/apps/apps.xml                     | 6 +++---
 management/univention-appcenter/umc/python/appcenter/__init__.py  | 2 +-
 .../modules/univention/admin/handlers/policies/registry.py        | 2 +-
 ...
 20 files changed, 19 insertions(+), 68 deletions(-)
[feature/ucs5] 04964b3cad fixup! Bug #51973: Remove UCC traces
 doc/changelog/changelog-5.0-0.xml | 3 +++
 1 file changed, 3 insertions(+)


I did NOT touch management/univention-directory-manager-modules/modules/univention/admin/license.py which still contains very old licence code.

FYI: univentionClient is also used for "IP managed client" - do not remove!
Comment 6 Florian Best univentionstaff 2020-09-16 17:10:31 CEST
(In reply to Erik Damrose from comment #3)
> > UCC has support until 2021-04-30, but only for UCS-4, so removing it for
> > UCS-5 looks okay.
> 
> I agree.

Do we support mixed environments? DC Master with UCS 5.0; DC Slave with UCS 4.X and UCC?
Comment 7 Philipp Hahn univentionstaff 2020-09-16 17:19:57 CEST
(In reply to Florian Best from comment #6)
> (In reply to Erik Damrose from comment #3)
> Do we support mixed environments? DC Master with UCS 5.0; DC Slave with UCS
> 4.X and UCC?

If you still want to manage them, you need a UCS-4.x system to do that.
Comment 8 Ingo Steuwer univentionstaff 2020-09-17 09:18:41 CEST
(In reply to Philipp Hahn from comment #7)
> (In reply to Florian Best from comment #6)
> > (In reply to Erik Damrose from comment #3)
> > Do we support mixed environments? DC Master with UCS 5.0; DC Slave with UCS
> > 4.X and UCC?
> 
> If you still want to manage them, you need a UCS-4.x system to do that.

fine for me
Comment 9 Florian Best univentionstaff 2020-09-17 09:30:37 CEST
(In reply to Ingo Steuwer from comment #8)
> (In reply to Philipp Hahn from comment #7)
> > (In reply to Florian Best from comment #6)
> > > (In reply to Erik Damrose from comment #3)
> > > Do we support mixed environments? DC Master with UCS 5.0; DC Slave with UCS
> > > 4.X and UCC?
> > 
> > If you still want to manage them, you need a UCS-4.x system to do that.
> 
> fine for me

Then we need to migrate the UCC-UDM modules to Python 3 as well. Because otherwise these UDM objects are not detected anymore and you cannot move a container containing an UCC object, etc.
Comment 10 Erik Damrose univentionstaff 2020-09-17 09:33:51 CEST
UCS 4 will still be in maintenance when UCC goes end-of-life, see comment#1. We could block the update to UCS 5 when UCC is installed and provide an SDB article.
Comment 11 Ingo Steuwer univentionstaff 2020-09-17 12:03:40 CEST
(In reply to Florian Best from comment #9)
> (In reply to Ingo Steuwer from comment #8)
> > (In reply to Philipp Hahn from comment #7)
> > > (In reply to Florian Best from comment #6)
> > > > (In reply to Erik Damrose from comment #3)
> > > > Do we support mixed environments? DC Master with UCS 5.0; DC Slave with UCS
> > > > 4.X and UCC?
> > > 
> > > If you still want to manage them, you need a UCS-4.x system to do that.
> > 
> > fine for me
> 
> Then we need to migrate the UCC-UDM modules to Python 3 as well. Because
> otherwise these UDM objects are not detected anymore and you cannot move a
> container containing an UCC object, etc.

OK, no, I don't want that. For me it is fine if these objects can only be managed from UCS 4 instances after users have been warned explicitly during the update, so...

(In reply to Erik Damrose from comment #10)
> UCS 4 will still be in maintenance when UCC goes end-of-life, see comment#1.
> We could block the update to UCS 5 when UCC is installed and provide an SDB
> article.

... sounds good. Should we have a dedicated bug?
Comment 12 Florian Best univentionstaff 2021-03-19 16:56:05 CET
OK: removal
OK: changelog entry
~OK: some policy objects have been removed from base.ldif, which are referenced elsewhere. If customers which upgrade just remove the objects (because of the postup.sh) they probably won't remove the references, which will cause incorrect referential integrity.
OK: update is blocked with UCC objects

OK: commits:
univention-virtual-machine-manager-schema (10.0.0-1)
b3268afde58d | Bug #51973: Remove managedclient
588c623b9e93 | Bug #51973: Remove mobileclient

univention-updater (15.0.1-2)
219d304804c1 | Bug #51655: Bug #51973: add UCC object classes to be removed

univention-updater (15.0.0-8)
a467f09a49ea | Bug #51497: Bug #51973: Bug #31048: Bug #51655: block upgrade if LDAP contains old objects

univention-updater (15.0.0-1)
366ed3910714 | Bug #51973: Remove fatclient
588c623b9e93 | Bug #51973: Remove mobileclient

univention-system-setup (13.0.0-1)
760865f914f3 | Bug #51973: Remove UCC traces
55d136f0fb8e | Bug #51973: Remove policies/thinclient

univention-ssl (14.0.0-2)
760865f914f3 | Bug #51973: Remove UCC traces

univention-s4-connector (14.0.0-1)
760865f914f3 | Bug #51973: Remove UCC traces

univention-pkgdb (13.0.0-1)
760865f914f3 | Bug #51973: Remove UCC traces
univention-net-installer (13.0.0-1)
760865f914f3 | Bug #51973: Remove UCC traces

univention-nagios-raid (9.0.0-1)
366ed3910714 | Bug #51973: Remove fatclient

univention-nagios (13.0.0-1)
b3268afde58d | Bug #51973: Remove managedclient
366ed3910714 | Bug #51973: Remove fatclient
588c623b9e93 | Bug #51973: Remove mobileclient
55d136f0fb8e | Bug #51973: Remove policies/thinclient

univention-management-console-module-udm (10.0.0-1)
760865f914f3 | Bug #51973: Remove UCC traces
b3268afde58d | Bug #51973: Remove managedclient
588c623b9e93 | Bug #51973: Remove mobileclient

univention-lilo (1.0.0-1)
366ed3910714 | Bug #51973: Remove fatclient
588c623b9e93 | Bug #51973: Remove mobileclient

univention-ldap (16.0.0-5)
b3268afde58d | Bug #51973: Remove managedclient
366ed3910714 | Bug #51973: Remove fatclient
588c623b9e93 | Bug #51973: Remove mobileclient
55d136f0fb8e | Bug #51973: Remove policies/thinclient

univention-join (12.0.0-1)
760865f914f3 | Bug #51973: Remove UCC traces
b3268afde58d | Bug #51973: Remove managedclient
366ed3910714 | Bug #51973: Remove fatclient
588c623b9e93 | Bug #51973: Remove mobileclient

univention-directory-manager-modules (15.0.3-3)
f4e0cdbb0f75 | Bug #51973: fix univention.admin.syntax.univentionAdminModules.choices

univention-directory-manager-modules (15.0.0-1)
760865f914f3 | Bug #51973: Remove UCC traces
b3268afde58d | Bug #51973: Remove managedclient
588c623b9e93 | Bug #51973: Remove mobileclient
55d136f0fb8e | Bug #51973: Remove policies/thinclient

univention-base-files (9.0.2-1)
1cf5424592fe | Bug #51973: fix typo

univention-base-files (9.0.0-1)
366ed3910714 | Bug #51973: Remove fatclient
588c623b9e93 | Bug #51973: Remove mobileclient

univention-appcenter (9.0.0-1)
760865f914f3 | Bug #51973: Remove UCC traces

univention-ad-connector (14.0.0-1)
760865f914f3 | Bug #51973: Remove UCC traces

ucs-test-tools (9.0.0-1)
55d136f0fb8e | Bug #51973: Remove policies/thinclient

ucs-test (10.0.0-1)
760865f914f3 | Bug #51973: Remove UCC traces
b3268afde58d | Bug #51973: Remove managedclient
366ed3910714 | Bug #51973: Remove fatclient
588c623b9e93 | Bug #51973: Remove mobileclient
55d136f0fb8e | Bug #51973: Remove policies/thinclient

changelog-5.0-0.xml
62c2675cc9da | Bug #51973: add changelog entry
Comment 13 Florian Best univentionstaff 2021-05-25 16:00:58 CEST
UCS 5.0 has been released:
 https://docs.software-univention.de/release-notes-5.0-0-en.html
 https://docs.software-univention.de/release-notes-5.0-0-de.html

If this error occurs again, please use "Clone This Bug".