Univention Bugzilla – Bug 51976
Allow computerroom to deal with multiple IPs and MACs
Last modified: 2020-11-18 10:38:29 CET
Laptops being added to the computerroom will always appear "offline" when there are two MACs and IPs assigned and they use WiFi instead of Ethernet. Laptops frequently have mutliple NICs (Ethernet and WiFi) and thus are configured accordingly. But in schools they are frequently only connected to the WiFi when in use and as the Ethernet interface is not reachable they will apear "offline" even though they are not. Computerroom should check both (or all) assigned IPs.
The computerroom will now checks the list of assigned IPs. If a computer is 'active', i.e. pingalbe, it will be used. If no ip is valid, the first ip found will be used since this is the default so far. I added a unittest, which causes a failure of dpkg-buildpackage - I will look into that. @QA just comment out the line `pytest unittests/ -vl -rsx` in rules and run the tests afterwards.
Code Review: OK Functional Test: I set up a Windows 10 VM with italc and made sure it was working. After that I edited the computer to have non existent/unreachable IP/MAC Addresses and verified that the computer room was not able anymore to access the Computer. After building and updating to the new package the computer room used the correct IP/MAC Addresses and worked just fine. Please complete the unit tests at least with this additional tests: - Same tests for MAC as for IP - Access MAC before IP
Package: ucs-school-umc-computerroom Version: 11.0.0-25A~4.4.0.202010160832 Branch: ucs_4.4-0 Scope: ucs-school-4.4 Package: ucs-test-ucsschool Version: 6.0.148A~4.4.0.202010160838 Branch: ucs_4.4-0 Scope: ucs-school-4.4 Tests were moved to ucs-test-ucsschool due to some faulty behavior of the unittests in concert with italc (segfaults). Functional QA was done before. Just final QA needed.
Final QA -> All OK -> VERIFY removed unittests from packages -> ok changelogs -> ok yaml -> ok merge -> no conflicts OK tests are green in jenkins OK functional qa -> OK - build: OK - ucs-test: 101 displayname & multple ips and macs passing OK - test with client OK comment for clarification: The sequence of the ips retrieved of a computer object is random, so the first ip, which is randomly selected and pingable, will be chosen.
UCS@school 4.4 v8 has been released (errata update to the release). https://docs.software-univention.de/changelog-ucsschool-4.4v8-de.html If this error occurs again, please clone this bug.