Bug 52050 - Mailaddresses for UCS@school workgroups
Mailaddresses for UCS@school workgroups
Status: CLOSED FIXED
Product: UCS@school
Classification: Unclassified
Component: UMC - Classes / Teachers / Workgroup assignment
UCS@school 4.4
Other Linux
: P5 normal (vote)
: UCS@school 4.4 v7
Assigned To: Ole Schwiegert
Tobias Wenzel
:
: 52149 (view as bug list)
Depends on: 52035
Blocks:
  Show dependency treegraph
 
Reported: 2020-09-17 11:58 CEST by Ole Schwiegert
Modified: 2020-10-12 16:19 CEST (History)
0 users

See Also:
What kind of report is it?: Feature Request
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ole Schwiegert univentionstaff 2020-09-17 11:58:13 CEST
Teachers and school admins should be able to create and manage an email address for a work group when creating it. At the same time it should be possible to create work groups for the sole purpose of the mail address. Thus the creation of a share has to be configurable on creation of the workgroup.
Comment 1 Ole Schwiegert univentionstaff 2020-09-17 15:49:48 CEST
Changes are on branch oschwieg/4.4/52050

You need the changes from Bug #52035 (new school-lib) to test this features
Documentation and tests follow ASAP. Please REOPEN with a comment whether the features are OK or not.

Please test that the following is the case:

Only the administrate workgroups module changed. Not the assing * to class, etc

Shares:
- You can choose to create or not create a share for the work group ONLY when creating a new group
- While editing it is only shown, if a share was created or not

Email (these options are only available, if the UCRV ucsschool/workgroups/mailaddress is not empty):
- When creating a new work group you can choose to create a mail address or not
- You can configure groups and users able to send emails to the work group (only school groups)
- The address is generated for you according to your pattern. {ou} and {name} are replaced by group name and chosen OU if used in pattern of the UCRV
- Email is not editable
- When editing a group you can disable the creation of a mail address. If saved the address and sender limitations are deleted from the group.
- You can also enable the creation of an email address on an already existing work group
- If the mail address of the group was changed in the udm group module the mail address is not overwritten with the specified pattern or changed by this UMC module.
Comment 2 Tobias Wenzel univentionstaff 2020-09-18 10:29:25 CEST
QA -> All OK -> REOPEN

As discussed, after the text changes, feel free to can merge & build 

UCR-V -> OK, with work group change

funcationality -> All OK

1) create

"Freigabe erstellen" is checked by default. When creating a workgroup, the share is created as expected. -> OK
If unchecked, no share is created.  -> OK

ucr set ucsschool/workgroups/mailaddress={ou}-{name}@wenzel-univention.intranet
-> Email Adresse erstellen checkbox appears in wizzard. The field "Email Adresse" is disabled and is updated after changes in the name or ou.

"Email Adresse erstellen" is unchecked by default. -> OK
When enabled, the 3 fields Email-Adresse, which is comprised of the template defined in the UCR-V and disabled, "Benutzer, die berechtigt sind, E-Mails an diese Gruppe zu versenden" & 
"Gruppen, die berechtigt sind, E-Mails an diese Gruppe zu versenden" are displayed.  After creating, the group then has an email adress. -> OK
Otherwise they remain hidden and no email adress is created -> OK
Users & groups, which are appended to to corresponding lists are appended to allowedEmailUsers and  allowedEmailGroups -> OK

2) modify

"Freigabe erstellen"  is now called "Freigabe erstellt" and disabled -> OK
If no email was created yet, this is still possible (by checking the checkbox) -> OK
If the checkbox is unchecked, the email-adress is removed -> OK
The rest is like in 1) create

3) delete 

works as expected: if a share was created, it is deleted
Comment 3 Ole Schwiegert univentionstaff 2020-09-21 09:55:48 CEST
Package: ucs-school-umc-groups
Version: 9.0.0-4A~4.4.0.202009210951
Branch: ucs_4.4-0
Scope: ucs-school-4.4


Package: ucs-test-ucsschool
Version: 6.0.137A~4.4.0.202009210953
Branch: ucs_4.4-0
Scope: ucs-school-4.4

Tests were created and packages were build. Minor changes to the UMC widget positioning (checkbox for shares is now directly above checkbox for email) and text of the sender limitation widgets. Documentation was created for the teachers manual and the administration manual.

 Please do final QA
Comment 4 Ole Schwiegert univentionstaff 2020-09-21 11:39:44 CEST
Package: ucs-school-umc-groups
Version: 9.0.0-5A~4.4.0.202009211139
Branch: ucs_4.4-0
Scope: ucs-school-4.4

Fix typo
Comment 5 Tobias Wenzel univentionstaff 2020-09-21 11:41:47 CEST
QA -> All OK -> Set to VERIFY

Thanks for the quick correction!

Tests -> Code looks good, test is passing, OK
New look -> Looks good, OK
Doku -> OK
Changelog -> OK
YAML -> OK
Comment 6 Ole Schwiegert univentionstaff 2020-09-29 10:59:06 CEST
*** Bug 52149 has been marked as a duplicate of this bug. ***
Comment 7 Ole Schwiegert univentionstaff 2020-09-29 11:05:00 CEST
There was an error here, that executed code for all flavors of the UMC module, instead of only for workgroup-admin. Made visible by the test 56_teacher_assignment.py

Problem fixed, new build:

Package: ucs-school-umc-groups
Version: 9.0.0-6A~4.4.0.202009291103
Branch: ucs_4.4-0
Scope: ucs-school-4.4
Comment 8 Tobias Wenzel univentionstaff 2020-09-30 08:51:00 CEST
All OK -> VERIFY

Code -> Looks good
Test passes http://jenkins.knut.univention.de:8080/job/UCSschool-4.4/job/Install%20Singleserver/624/#showFailuresLink
Changelog -> OK
YAML -> OK
Comment 9 Daniel Tröder univentionstaff 2020-10-12 16:19:02 CEST
UCS@school 4.4 v7 has been released.

https://docs.software-univention.de/changelog-ucsschool-4.4v7-de.html

If this error occurs again, please clone this bug.