Bug 52123 - Remove univention-check-printers
Remove univention-check-printers
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: ZZZ - Trash - UCS-Console
UCS 5.0
Other Linux
: P5 normal (vote)
: UCS 5.0
Assigned To: Philipp Hahn
Florian Best
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2020-09-21 11:27 CEST by Philipp Hahn
Modified: 2021-05-25 15:59 CEST (History)
0 users

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Hahn univentionstaff 2020-09-21 11:27:30 CEST
Checking the liveness of USB printers are not supported anymore out-of-the-box with UCS-5.
Comment 1 Philipp Hahn univentionstaff 2020-09-21 11:43:26 CEST
Bug #52123: Remove univention-check-printers
Comment 2 Florian Best univentionstaff 2020-10-19 17:24:21 CEST
Shouldn't we remove the cronjob file /etc/cron.d/univention-check-printers?

OK: removal git:0d92367518882a0c14ed9c2662c7bf5b4a825dcf
OK: changelog

I added the package to check.sh:update_check_old_packages in git:0d9236751888
Comment 3 Florian Best univentionstaff 2021-02-18 10:17:19 CET
The packages were still part of the repositories:

Removing: /var/univention/buildsystem2/apt/ucs_5.0-0/all/univention-check-printers_13.0.0-1A~5.0.0.202006052156_all.deb
Removing: /var/univention/buildsystem2/apt/ucs_5.0-0/source/univention-check-printers_13.0.0-1A~5.0.0.202006052156.tar.gz
Removing: /var/univention/buildsystem2/apt/ucs_5.0-0/source/univention-check-printers_13.0.0-1A~5.0.0.202006052156.dsc
Comment 4 Philipp Hahn univentionstaff 2021-03-10 18:00:56 CET
(In reply to Florian Best from comment #2)
> Shouldn't we remove the cronjob file /etc/cron.d/univention-check-printers?

This happens on "apt purge" only.
Comment 5 Florian Best univentionstaff 2021-03-10 21:17:39 CET
(In reply to Philipp Hahn from comment #4)
> (In reply to Florian Best from comment #2)
> > Shouldn't we remove the cronjob file /etc/cron.d/univention-check-printers?
> 
> This happens on "apt purge" only.

Then we should purge the package in the preup.sh.
Comment 6 Philipp Hahn univentionstaff 2021-03-10 21:24:29 CET
(In reply to Florian Best from comment #5)
> Then we should purge the package in the preup.sh.

This is the Admins decision, not yours!
Comment 7 Florian Best univentionstaff 2021-03-10 21:40:16 CET
(In reply to Philipp Hahn from comment #6)
> (In reply to Florian Best from comment #5)
> > Then we should purge the package in the preup.sh.
> 
> This is the Admins decision, not yours!

My intention here is:
I want to prevent that our support team gets tickets about admins being spammed with emails from cron that say /usr/sbin/univention-check-printers doesn't exists.

Well, looking into the cronjob tells me there is a check for existence of the binary:

`@%@cups/checkprinters/cron@%@   root   if [ -x /usr/sbin/univention-check-printers ]; then /usr/sbin/univention-check-printers; fi`

How will admins get informed about the packages being removed and that they should purge it?
Should we at least add the information to the changelog for every removed package?
Comment 8 Florian Best univentionstaff 2021-03-24 00:02:02 CET
OK: removal
OK: changelog entry
OK: package removed automatically during upgrade via Conflicts entry:
rc  univention-check-printers 11.0.0-1A~4.3.0.201712120023 all          UCS - USB printer monitoring
OK: leftover cronjob doesn't break anything
Comment 9 Florian Best univentionstaff 2021-05-25 15:59:55 CEST
UCS 5.0 has been released:
 https://docs.software-univention.de/release-notes-5.0-0-en.html
 https://docs.software-univention.de/release-notes-5.0-0-de.html

If this error occurs again, please use "Clone This Bug".