Univention Bugzilla – Bug 52278
simplesamlphp does 2 ldap binds where 0 are necessary
Last modified: 2020-11-04 14:49:23 CET
Created attachment 10538 [details] patch (git:fbest/52278-improove-saml-performance) In our self written PHP module for simplesamlphp (uLDAP.php) we are doing 2 LDAP binds in the constructor of the class. This is not necessary, we can do them also when they are needed.
The LDAP bind has been moved into a static variable, so it's only initialized once. The call to initialize this LDAP variable has been deferred to when it is used the first time. univention-saml.yaml 6a87fd13dec3 | YAML Bug #52278 univention-saml (6.0.2-59) 49b0b8c9f213 | Bug #52278: defer LDAP bind when it is needed
Introduced in Bug #43384 (git:00624a4420a9d88421f2c1c3dbcc5b5ab30e2dce).
What I tested: No ldap bind on loading the login form -> OK Login -> OK Wrong password -> OK Expired password -> OK Changing expired password -> OK jenkins -> OK yaml -> OK -> verified
<https://errata.software-univention.de/#/?erratum=4.4x796>