Bug 52296 - Don't store python XML objects in session
Don't store python XML objects in session
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UMC (Generic)
UCS 4.4
Other Linux
: P5 normal (vote)
: UCS 4.4-6-errata
Assigned To: Florian Best
Dirk Wiesenthal
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2020-11-02 13:07 CET by Florian Best
Modified: 2020-11-04 14:49 CET (History)
1 user (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Large environments, UCS Performance
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Best univentionstaff 2020-11-02 13:07:37 CET
We currently store the complete SAML response objects from pysaml2 during the whole session. We don't need those objects. We should only store the relevant data.
Comment 1 Florian Best univentionstaff 2020-11-02 13:23:16 CET
The unrelevant data has been dropped from being stored in the SAMLUser instance.

univention-management-console.yaml
c391d48529db | YAML Bug #52296

univention-management-console (11.0.5-9)
ef28b372cf8b | Bug #52296: store only relevant SAML data, which we use, in the session
Comment 2 Dirk Wiesenthal univentionstaff 2020-11-03 04:07:47 CET
Code: OK

Unfortunately, I was not able to test the memory improvement. But from what I understand, it should be considerable.
Comment 3 Dirk Wiesenthal univentionstaff 2020-11-03 05:43:38 CET
Please cherry-pick 80bb1f2314
Comment 4 Florian Best univentionstaff 2020-11-03 09:20:24 CET
(In reply to Dirk Wiesenthal from comment #3)
> Please cherry-pick 80bb1f2314

No, this is only necessary in the feature branch. This would be for the unmerged Bug #52272.
Comment 5 Dirk Wiesenthal univentionstaff 2020-11-03 09:28:24 CET
Alright.