Bug 52521 - Make ucsschool-veyon-client thread safe
Make ucsschool-veyon-client thread safe
Status: CLOSED FIXED
Product: UCS@school
Classification: Unclassified
Component: Veyon
UCS@school 4.4
Other Linux
: P5 normal (vote)
: UCS@school 4.4 v9
Assigned To: Ole Schwiegert
Daniel Tröder
:
Depends on:
Blocks: 53019
  Show dependency treegraph
 
Reported: 2020-12-21 10:59 CET by Ole Schwiegert
Modified: 2021-03-30 16:11 CEST (History)
1 user (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments
test threading manually (1.27 KB, text/x-python)
2021-03-18 08:57 CET, Tobias Wenzel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ole Schwiegert univentionstaff 2020-12-21 10:59:22 CET
The veyon client will be used in a threaded environment (The UMC Computerroom module) and thus needs to be threadsafe.
Comment 1 Ole Schwiegert univentionstaff 2020-12-21 11:39:43 CET
Changes implemented on oschwieg/4.4/veyon_integration

Facilitating threading.Lock now to ensure thread safe operation for the internal session management.
Comment 3 Ole Schwiegert univentionstaff 2021-01-11 08:37:46 CET
Proposal was implemented and committed.
Comment 4 Ole Schwiegert univentionstaff 2021-03-02 08:54:15 CET
Package: ucs-school-veyon-client
Version: 1.0.1-5A~4.4.0.202103020852
Branch: ucs_4.4-0
Scope: ucs-school-4.4


build and merge in 4.4
Comment 5 Tobias Wenzel univentionstaff 2021-03-18 08:57:28 CET
Created attachment 10651 [details]
test threading manually

a very rough test which checks if the connection uids returned are the
same in different threads.
Comment 6 Tobias Wenzel univentionstaff 2021-03-18 09:02:10 CET
QA → All OK → Verify

Changelog → OK
Advisory → OK
Merge → OK
Functionality → see comment 5
Comment 7 Tobias Wenzel univentionstaff 2021-03-24 14:10:18 CET
UCS@school 4.4 v9 has been released.

https://docs.software-univention.de/changelog-ucsschool-4.4v9-de.html

If this error occurs again, please clone this bug.