Bug 52524 - Umlaut in school class not replaced if imported through UMC
Umlaut in school class not replaced if imported through UMC
Status: CLOSED FIXED
Product: UCS@school
Classification: Unclassified
Component: Import scripts
UCS@school 4.4
Other Linux
: P5 normal (vote)
: UCS@school 4.4 v8-errata
Assigned To: Daniel Tröder
Tobias Wenzel
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2020-12-21 13:00 CET by Daniel Tröder
Modified: 2021-02-10 09:28 CET (History)
4 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 3: Simply Wrong: The implementation doesn't match the docu
Who will be affected by this bug?: 2: Will only affect a few installed domains
How will those affected feel about the bug?: 2: A Pain – users won’t like this once they notice it
User Pain: 0.069
Enterprise Customer affected?:
School Customer affected?: Yes
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number: 2020121821000519
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Tröder univentionstaff 2020-12-21 13:00:46 CET
When importing a CSV containing an Umlaut in a class name, using the UMC import module, the character is not replaced.

Bug 45683 had introduced the "school_classes_invalid_character_replacement" configuration variable, but the code is only executed, when the "school_classes" attribute is still a string, and not when it is already a dictionary, like in the case of an import through the UMC module where HttpApiCsvReader.handle_input() created the dict.

make sure invalid characters in school_class names are replaced according to the value of "school_classes_invalid_character_replacement".
Comment 1 Daniel Tröder univentionstaff 2020-12-21 13:38:32 CET
Invalid characters in school_class names are now also replaced, when importing through the UMC module.
A unit test was added to very the function doing the string replacement.

[4.4 ac6a60544] Bug #52524: replace invalid chars in school_class names in all code paths
[4.4 2a195ce67] Bug #52524: advisory update

ucs-school-import (17.0.48)
ucs-test-ucsschool (6.0.176)
Comment 2 Tobias Wenzel univentionstaff 2021-01-05 15:52:07 CET
QA: All OK → VERIFY

Code is already in 4.4

Code in importer and http-api → OK
Code in test → OK

unit-tests pass → OK

functional qa:
tested umc-import with

DEMOSCHOOL-Democlassä → fails (ok, since trailing "-" is not allowed)
DEMOSCHOOL-1äöB → DEMOSCHOOL-1--B
DEMOSCHOOL-2ßiaäu → DEMOSCHOOL-2-ia-u

(...and others)
Comment 3 Ole Schwiegert univentionstaff 2021-02-10 09:28:43 CET
Errata updates for UCS@school 4.4 v8 have been released.

https://docs.software-univention.de/changelog-ucsschool-4.4v8-de.html

If this error occurs again, please clone this bug.