Bug 52534 – Adapt veyon client for demo mode

Bug 52534 - Adapt veyon client for demo mode


Summary:	Adapt veyon client for demo mode

Status:	CLOSED FIXED

Product:	UCS@school
Classification:	Unclassified
Component:	Veyon
Version:	UCS@school 4.4
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS@school 4.4 v9
Assigned To:	Ole Schwiegert
QA Contact:	Daniel Tröder

URL:
Keywords:

Depends on:
Blocks:	52522 52915 52922
	Show dependency tree / graph

Reported:	2020-12-22 13:07 CET by Ole Schwiegert
Modified:	2021-03-16 15:28 CET (History)
CC List:	1 user (show)

See Also:
What kind of report is it?:	Feature Request
What type of bug is this?:	---
Who will be affected by this bug?:	---
How will those affected feel about the bug?:	---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Ole Schwiegert

2020-12-22 13:07:06 CET

The veyon client needs to be able to send args when setting feature modes. This is necessary for the newly added demo mode.

Comment 1 Ole Schwiegert

2020-12-23 14:25:52 CET

Package: ucs-school-veyon-client
Version: 1.0.1-2A~4.4.0.202012231421
Branch: ucs_4.4-0
Scope: ucs-school-4.4

Added parameters to set_feature.

Comment 2 Daniel Tröder

2021-01-11 14:26:26 CET

In VeyonClient.set_feature():
1. arguments could be **feature_kwargs
2. arguments / data is never used

Comment 3 Ole Schwiegert

2021-01-12 11:13:25 CET

Oh wow.. that was a pre holiday stress doozy.. Fixed:

Package: ucs-school-veyon-client
Version: 1.0.1-3A~4.4.0.202101121110
Branch: ucs_4.4-0
Scope: ucs-school-4.4

We decided together to not use **feature_kwargs to prevent the possibility of function argument and HTTP call argument overlap

Comment 4 Daniel Tröder

2021-01-12 14:15:33 CET

OK: the Veyon clients code has been adapted for demo mode.
Unfortunately the Veyon server and the room management module do not support it yet, so it's not possible to really test it.
I'll approve this anyway. If problems are encountered later, when integrating the client with the updated room management and the Veyon server, errors will be handled it the room management bugs QA.

Comment 5 Ole Schwiegert

2021-02-03 11:10:51 CET

Errata updates for UCS@school 4.4 v8 have been released.

https://docs.software-univention.de/changelog-ucsschool-4.4v8-de.html

If this error occurs again, please clone this bug.