Bug 52539 - Remove or migrate docker scripts to Python3
Remove or migrate docker scripts to Python3
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: Docker
UCS 5.0
Other Linux
: P5 normal (vote)
: UCS 5.0-1-errata
Assigned To: Johannes Lohmer
Florian Best
https://git.knut.univention.de/univen...
: python3-migration
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2020-12-29 11:38 CET by Jan Luttermann
Modified: 2022-04-27 16:11 CEST (History)
3 users (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:
best: Patch_Available+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Luttermann univentionstaff 2020-12-29 11:38:21 CET
Migrate following files to Python3
container/univention-docker-container-mode/usr/share/univention-docker-container-mode/restore_data_before_setup
container/univention-docker-container-mode/usr/share/univention-docker-container-mode/store_data
container/univention-docker/scripts/migrate_container_MountPoints_to_v2_config
Comment 1 Florian Best univentionstaff 2021-03-15 12:43:37 CET
There is a untested patch in git:jluttermann/bug52539-migrate-docker-to-python3
Comment 2 Dirk Wiesenthal univentionstaff 2021-04-28 10:08:13 CEST
I don't think we need to migrate that at all. All three scripts do not need to be run in 5.0 (appbox and 4.3 migration script)
Comment 3 Florian Best univentionstaff 2021-07-09 14:14:35 CEST
Created issue in GitLab for this bug at: https://git.knut.univention.de/univention/ucs/-/issues/629
Comment 4 Florian Best univentionstaff 2022-01-26 14:37:59 CET
@Johannes, please find out if we still need the scripts. If not, please remove them from the package. If yes, migrate them to Python as well as migrate the usage of optparse to argparse.
Comment 5 Johannes Lohmer univentionstaff 2022-04-04 11:02:34 CEST
After a brief discussion between Dirk Wiesenthal and me, we decided to remove the appbox docker container. (univention-docker-container-mode)
Aswell as the third script. (migrate_container_MountPoints_to_v2_config)

They are no longer in use and a revival in the future is not expected.

Merge Request: 
https://git.knut.univention.de/univention/ucs/-/merge_requests/325
Comment 6 Johannes Lohmer univentionstaff 2022-04-21 15:55:04 CEST
univention-docker-container-mode (5.0.0-2)
b04c19d673b3 | Bug #52539: removed deprecated appbox docker container

univention-docker (5.0.2-1)
6526665f0970 | Bug #52539: removed deprecated script: migrate_container_MountPoints_to_v2_config
Comment 7 Florian Best univentionstaff 2022-04-22 02:09:16 CEST
OK: empty transitional package

# dpkg -L univention-docker-container-mode
/.
/usr
/usr/share
/usr/share/doc
/usr/share/doc/univention-docker-container-mode
/usr/share/doc/univention-docker-container-mode/changelog.Debian.gz
/usr/share/doc/univention-docker-container-mode/copyright

OK: removal of migrate_container_MountPoints_to_v2_config
OK: YAML