Bug 52681 - S4C stopped after initializing the s4-connector.py Listener module
S4C stopped after initializing the s4-connector.py Listener module
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: S4 Connector
UCS 4.4
Other Linux
: P5 normal (vote)
: UCS 5.0
Assigned To: Arvid Requate
Florian Best
:
Depends on: 46972
Blocks:
  Show dependency treegraph
 
Reported: 2021-01-24 17:11 CET by Arvid Requate
Modified: 2021-05-25 16:02 CEST (History)
1 user (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:
requate: Patch_Available+


Attachments
Workaround-for-Bug52681.patch (1.33 KB, patch)
2021-01-24 17:15 CET, Arvid Requate
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arvid Requate univentionstaff 2021-01-24 17:11:11 CET
During the UCS 5.0 tests for AD-Takeover I repeatedly found the S4-Connector process vanishing. The listener.log shows this:
==================================================
23.01.21 07:10:18.637  LISTENER    ( WARN    ) : initializing module s4-connector
32246
23.01.21 07:10:19.137  LISTENER    ( PROCESS ) : s4-connector: restarting connector ...
Restarting univention-s4-connector (via systemctl): univention-s4-connector.service.
23.01.21 07:10:19.975  LISTENER    ( PROCESS ) : s4-connector: ... done
32276
23.01.21 07:10:20.023  LISTENER    ( PROCESS ) : s4-connector: restarting connector ...
Restarting univention-s4-connector (via systemctl): univention-s4-connector.service.
23.01.21 07:10:20.837  LISTENER    ( PROCESS ) : s4-connector: ... done
32306
23.01.21 07:10:20.888  LISTENER    ( PROCESS ) : s4-connector: restarting connector ...
Restarting univention-s4-connector (via systemctl): univention-s4-connector.service.
23.01.21 07:10:21.721  LISTENER    ( PROCESS ) : s4-connector: ... done
32336
23.01.21 07:10:21.779  LISTENER    ( PROCESS ) : s4-connector: restarting connector ...
Restarting univention-s4-connector (via systemctl): univention-s4-connector.service.
23.01.21 07:10:22.733  LISTENER    ( PROCESS ) : s4-connector: ... done
32387
23.01.21 07:10:22.779  LISTENER    ( PROCESS ) : s4-connector: restarting connector ...
Restarting univention-s4-connector (via systemctl): univention-s4-connector.serviceJob for univention-s4-connector.service failed.
See "systemctl status univention-s4-connector.service" and "journalctl -xe" for details.
 failed!
==================================================

And systemd logs this:
==================================================
Jan 23 06:54:34 master220 systemd[1]: univention-s4-connector.service: Start request repeated too quickly.
Jan 23 06:54:34 master220 systemd[1]: univention-s4-connector.service: Failed with result 'start-limit-hit'.
==================================================

Now, the s4-connector.py may repeatedly restart the service due to the changes made for Bug #46972. We may improve that, but that would require a bit of careful thought. IMHO it would be better if systemd could just be configured to stop interfering. Basically this is a DOS by systemd.
Comment 1 Arvid Requate univentionstaff 2021-01-24 17:15:29 CET
Created attachment 10600 [details]
Workaround-for-Bug52681.patch
Comment 2 Arvid Requate univentionstaff 2021-01-24 21:41:05 CET
db0c8b66e5 Bug #52681: Avoid S4C restart burst during listener initialization
59ed2a4a55 Bug #52681: Changelogs

Package: univention-s4-connector
Version: 14.0.5-1A~5.0.0.202101242116
Branch: ucs_5.0-0
Comment 3 Florian Best univentionstaff 2021-03-02 17:13:57 CET
OK: The S4-Connector restart is not done in init mode.
OK: changelog entry
OK: Jenkins Tests
Comment 4 Florian Best univentionstaff 2021-05-25 16:02:21 CEST
UCS 5.0 has been released:
 https://docs.software-univention.de/release-notes-5.0-0-en.html
 https://docs.software-univention.de/release-notes-5.0-0-de.html

If this error occurs again, please use "Clone This Bug".