Bug 52712 - Other teachers with the same class also receive materials
Other teachers with the same class also receive materials
Status: NEW
Product: UCS@school
Classification: Unclassified
Component: UMC - Distribution
UCS@school 4.4
All All
: P5 normal (vote)
: ---
Assigned To: UCS@school maintainers
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2021-01-28 08:31 CET by Daniel Duchon
Modified: 2021-05-05 07:58 CEST (History)
3 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 1: Cosmetic issue or missing function but workaround exists
Who will be affected by this bug?: 1: Will affect a very few installed domains
How will those affected feel about the bug?: 2: A Pain – users won’t like this once they notice it
User Pain: 0.011
Enterprise Customer affected?: Yes
School Customer affected?: Yes
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number: 2021012521000471
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Duchon univentionstaff 2021-01-28 08:31:59 CET
Our Customer criticizes the following misconduct:

You have multiple teachers assigned to different classes.
Let's say an English, German, Math and French teacher.

Now the English teacher distributes materials to his class.
However, in addition to the students, all other teachers teaching the same class are now assigned these materials.

How can this be reproduced?
- Create a demo-school-environment with multiple teachers, at least one student and one class.
- assign at least on student to the class
- assign at least two teachers to the class
- deploy material with one teacher
- ssh into the school-server with another teacher accounts and cd into teachers home-dir.
- see the deployed documents dir.


Environment:
UCS-Version:        4.4-7 erratta 868
UCS@School-Version: 4.4 v8
Comment 1 Daniel Tröder univentionstaff 2021-01-28 08:50:08 CET
1. This is not a mistake but intent. This way teacher(s) can see that the file distribution worked and how the result looks like for students.
2. Priority: This does in no way hinder usability of the product. Everyone can still do their work. This is merely a cosmetic issue.
Comment 2 Daniel Duchon univentionstaff 2021-01-28 09:03:59 CET
(In reply to Daniel Tröder from comment #1)
> 1. This is not a mistake but intent. This way teacher(s) can see that the
> file distribution worked and how the result looks like for students.

That a teacher sees his/her own distribution I can understand. However, that a teacher of a class sees all distributions of all other teachers is not, is it?
Comment 4 Patrick Ziegler univentionstaff 2021-03-01 09:31:03 CET
Added to backlog https://taiga.knut.univention.de/project/oschwieg-ucs-5/us/5578
Comment 5 Dirk Schnick univentionstaff 2021-05-04 09:29:14 CEST
I have got a technical question regarding a solution:

The problem is that teachers who are also assigned to the class receive the exam materials. 
Already during the assignment to the exam only cn=schueler,cn=users,ou=schoolOU,dc=myschool,dc=xy
should be entered. Is this not possible without UMC adjustment by appropriate dn check?

This is really an annoying bug. Other teacher do not need exam materials of every exam written by an applied class.
Comment 6 Daniel Tröder univentionstaff 2021-05-05 07:39:11 CEST
(In reply to Dirk Schnick from comment #5)
> I have got a technical question regarding a solution:
> 
> The problem is that teachers who are also assigned to the class receive the
> exam materials. 
> Already during the assignment to the exam only
> cn=schueler,cn=users,ou=schoolOU,dc=myschool,dc=xy
> should be entered. Is this not possible without UMC adjustment by
> appropriate dn check?
We cannot filter my OU only. Students and teachers can be assigned to multiple schools and write exams in their "secondary" school(s).
Comment 7 Dirk Schnick univentionstaff 2021-05-05 07:44:59 CEST
Teachers are always in ...,cn=teacher,... students are always in ...,cn=student,... or? Throw away teachers?

As written maybe I'm wrong but from non developer view it seems to be so simple. ;-)
Comment 8 Daniel Tröder univentionstaff 2021-05-05 07:58:14 CEST
We do not want to decide a users role depending on its position in the LDAP tree anymore, and use objectClasses and ucsschool_roles for that now.
But ignoring that: yes the fix is simple: just remove all teachers, except the "sender", from the distribution target list.