Bug 52761 – Regression in S4-Connector due to mistake in code cleanup for Bug #46971

Bug 52761 - Regression in S4-Connector due to mistake in code cleanup for Bug #46971


Summary:	Regression in S4-Connector due to mistake in code cleanup for Bug #46971

Status:	NEW

Product:	UCS
Classification:	Unclassified
Component:	S4 Connector
Version:	UCS 4.4
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	---
Assigned To:	Samba maintainers
QA Contact:	Samba maintainers

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2021-02-08 21:05 CET by Arvid Requate
Modified:	2021-02-10 20:20 CET (History)
CC List:	1 user (show)

See Also:
What kind of report is it?:	Development Internal
What type of bug is this?:	---
Who will be affected by this bug?:	---
How will those affected feel about the bug?:	---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):	Regression
Max CVSS v3 score:

Flags:	requate: Patch_Available+

Attachments
Bug52761.patch (828 bytes, patch) 2021-02-08 21:06 CET, Arvid Requate	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Arvid Requate

2021-02-08 21:05:08 CET

During the code review for Bug #52044 (ADC) I spotted a line of code introduced during a code cleanup for Bug #46971 (S4C), which defeats the purpose of a loop in group_members_sync_from_ucs. I fixed it in ADC and I guess we should also fix it in S4C. I'll attach a patch.

Comment 1 Arvid Requate

2021-02-08 21:06:09 CET

Created attachment 10615 [details]
Bug52761.patch

Comment 2 Florian Best

2021-02-10 20:20:37 CET

We should also have a test case which detects this.