Bug 52941 - add icons for modules of portal page
add icons for modules of portal page
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UMC (Generic)
UCS 5.0
Other Linux
: P5 normal (vote)
: UCS 5.0
Assigned To: Jan Luttermann
Florian Best
: interim-1
: 52988 53017 53032 (view as bug list)
Depends on: 35061
Blocks:
  Show dependency treegraph
 
Reported: 2021-03-17 15:11 CET by Jan Luttermann
Modified: 2021-05-25 16:01 CEST (History)
3 users (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Luttermann univentionstaff 2021-03-17 15:11:59 CET
components:
base/univention-firewall
base/univention-quota
base/univention-updater
univention-appcenter
univention-management-console-module-lib
univention-management-console-module-reboot
univention-management-console-module-services
univention-management-console-module-top
univention-management-console-module-ucr
univention-system-info
services/univention-ad-connector
services/univention-pkgdb
services/univention-printserver
Comment 1 Florian Best univentionstaff 2021-03-18 18:45:22 CET
Please revert your changes: We don't use the icons from UCS 3.2.
Comment 2 Jan Luttermann univentionstaff 2021-03-23 13:59:57 CET
(In reply to Jan Luttermann from comment #0)
> components:
> base/univention-firewall
> base/univention-quota
> base/univention-updater
> univention-appcenter
> univention-management-console-module-lib
> univention-management-console-module-reboot
> univention-management-console-module-services
> univention-management-console-module-top
> univention-management-console-module-ucr
> univention-system-info
> services/univention-ad-connector
> services/univention-pkgdb
> services/univention-printserver

the old icons will not be used. the changes that were done will be reverted. new icons will be used
Comment 3 Jan Luttermann univentionstaff 2021-03-25 16:32:25 CET
univention-updater (15.0.3-32)
69606b4a9d2b | Bug #52941: added module icons for portal page

univention-system-setup (13.0.3-15)
69606b4a9d2b | Bug #52941: added module icons for portal page

univention-system-info (10.0.0-2)
69606b4a9d2b | Bug #52941: added module icons for portal page

univention-quota (14.0.1-5)
69606b4a9d2b | Bug #52941: added module icons for portal page

univention-portal (4.0.5-13)
69606b4a9d2b | Bug #52941: added module icons for portal page

univention-pkgdb (13.0.1-4)
69606b4a9d2b | Bug #52941: added module icons for portal page

univention-management-console-module-udm (10.0.1-2)
69606b4a9d2b | Bug #52941: added module icons for portal page

univention-management-console-module-ucr (9.0.0-4)
69606b4a9d2b | Bug #52941: added module icons for portal page

univention-management-console-module-top (9.0.0-6)
69606b4a9d2b | Bug #52941: added module icons for portal page

univention-management-console-module-top (9.0.0-5)
88725d897c97 | Bug #52941: readding umc-top icons from version 3.2

univention-management-console-module-services (9.0.0-4)
69606b4a9d2b | Bug #52941: added module icons for portal page

univention-management-console-module-diagnostic (6.0.0-9)
69606b4a9d2b | Bug #52941: added module icons for portal page

univention-management-console (12.0.11-1)
c82229bb6df7 | Bug #52941: fix dependency on librsvg2-bin to support SVG to PNG conversion
b5a2b6affca7 | Revert "fixup! Bug #52941: create missing PNG image from SVGs during build"
2898201cba00 | fixup! Bug #52941: create missing PNG image from SVGs during build
40c9f8217a71 | Bug #52941: create missing PNG image from SVGs during build

univention-join (12.0.3-4)
69606b4a9d2b | Bug #52941: added module icons for portal page

univention-appcenter (9.0.2-26)
69606b4a9d2b | Bug #52941: added module icons for portal page
Comment 4 Florian Best univentionstaff 2021-03-30 10:39:23 CEST
REOPEN:

I get the following error messages:
https://member096.autotest096.local/univention/js/dijit/themes/umc/icons/50x50/system-services.png - Failed to load resource: the server responded with a status of 404 (Not Found)
https://member096.autotest096.local/univention/js/dijit/themes/umc/icons/50x50/system-diagnostics.png - Failed to load resource: the server responded with a status of 404 (Not Found)

→ Please make sure all icons are correctly integrated into the packages.
Comment 5 Florian Best univentionstaff 2021-03-30 17:26:48 CEST
*** Bug 53017 has been marked as a duplicate of this bug. ***
Comment 6 Florian Best univentionstaff 2021-03-30 17:27:12 CEST
(In reply to Florian Best from comment #5)
> *** Bug 53017 has been marked as a duplicate of this bug. ***

A icon for the Univention AD Connector needs to be added.
Comment 7 Florian Best univentionstaff 2021-03-31 19:55:17 CEST
I fixed 4 problems introduced in git:69606b4a9d2b296496e0b48330c40aaa056467fe:

1.
-               <flavor priority="50" id="computers/computer">
+               <flavor priority="50" icon="computers" iconsid="computers/computer">

id → iconsid

2.
-       <module id="setup" version="1.0">
+       <module id="setup" icon="language-settings" version="1.0">
                <flavor priority="50" id="languages">

The icon must be set in the <flavor> instead of the <module>, like in the other below.

3. The icons directory was in the wrong directory.

Wrong:   management/univention-management-console-module-services/icons
Correct: management/univention-management-console-module-services/umc/icons/

4. Missing in management/univention-management-console-module-diagnostic/debian/univention-management-console-module-diagnostic.umc-modules was:
Icons: umc/icons

Fixed in:

univention-system-setup (13.0.3-18)
92171c6bf531 | fixup! Bug #52941: added module icons for portal page

univention-management-console-module-udm (10.0.1-2)
92171c6bf531 | fixup! Bug #52941: added module icons for portal page

univention-management-console-module-services (9.0.0-4)
92171c6bf531 | fixup! Bug #52941: added module icons for portal page

univention-management-console-module-diagnostic (6.0.0-9)
92171c6bf531 | fixup! Bug #52941: added module icons for portal page
Comment 8 Florian Best univentionstaff 2021-03-31 19:57:58 CEST
*** Bug 52988 has been marked as a duplicate of this bug. ***
Comment 9 Florian Best univentionstaff 2021-04-14 13:49:34 CEST
*** Bug 53032 has been marked as a duplicate of this bug. ***
Comment 10 Florian Best univentionstaff 2021-04-26 12:22:38 CEST
REOPEN: An icon for udm:users/self is missing.
Comment 11 Florian Best univentionstaff 2021-04-28 14:36:59 CEST
REOPEN: The icon for the Portal module is not yet shown.

REOPEN: The icon for the SAML Identify Provider is still in color, while it should be white like the others.
Comment 12 Jan Luttermann univentionstaff 2021-04-28 17:24:42 CEST
univention-updater (15.0.3-44)
e464bbec8b9a | Bug #52941: added new icons to all modules that are presented in the portal

univention-updater (15.0.3-36)
3aef6f2be6fe | Bug #52941: debian changelog

univention-updater (15.0.3-35)
efcb21b65147 | Bug #52941: update module icons for portal

univention-updater (15.0.3-32)
69606b4a9d2b | Bug #52941: added module icons for portal page

univention-system-setup (13.0.3-22)
e464bbec8b9a | Bug #52941: added new icons to all modules that are presented in the portal

univention-system-setup (13.0.3-20)
3aef6f2be6fe | Bug #52941: debian changelog

univention-system-setup (13.0.3-19)
efcb21b65147 | Bug #52941: update module icons for portal

univention-system-setup (13.0.3-18)
92171c6bf531 | fixup! Bug #52941: added module icons for portal page

univention-system-setup (13.0.3-15)
69606b4a9d2b | Bug #52941: added module icons for portal page

univention-system-info (10.0.0-4)
e464bbec8b9a | Bug #52941: added new icons to all modules that are presented in the portal

univention-system-info (10.0.0-3)
3aef6f2be6fe | Bug #52941: debian changelog

univention-system-info (10.0.0-2)
efcb21b65147 | Bug #52941: update module icons for portal
69606b4a9d2b | Bug #52941: added module icons for portal page

univention-saml (7.0.4-9)
3be05b9d242a | Bug #52941: set icon for users/self and removed old icons for saml

univention-saml (7.0.4-8)
62e7ca12459a | Bug #52941: move svg file to needed directory while saml install

univention-saml (7.0.4-7)
abc7fc3d0ae9 | Bug #52941: fixup for icon in saml xml file

univention-saml (7.0.4-6)
e464bbec8b9a | Bug #52941: added new icons to all modules that are presented in the portal

univention-saml (7.0.4-12)
c37885c5ccb9 | Bug #52941: remove moving svg file in install script

univention-saml (7.0.4-11)
c593a0bc3b4d | Bug #52941: added icon tag to umc-modules

univention-saml (7.0.4-10)
59d3ec024061 | Bug #52941: fixed saml install and delected old icon reference

univention-quota (14.0.1-7)
e464bbec8b9a | Bug #52941: added new icons to all modules that are presented in the portal

univention-quota (14.0.1-6)
3aef6f2be6fe | Bug #52941: debian changelog

univention-quota (14.0.1-5)
efcb21b65147 | Bug #52941: update module icons for portal
69606b4a9d2b | Bug #52941: added module icons for portal page

univention-printserver (13.0.2-8)
e464bbec8b9a | Bug #52941: added new icons to all modules that are presented in the portal

univention-portal (4.0.5-39)
e464bbec8b9a | Bug #52941: added new icons to all modules that are presented in the portal

univention-portal (4.0.5-35)
4c010251d1c9 | Bug #52941: Ensure login in UMC portal (typo)
79bd353b3552 | Bug #52941: Ensure login in UMC portal

univention-portal (4.0.5-33)
500d2d93a4af | Bug #52941: Fix UMC portal cache

univention-portal (4.0.5-18)
a7ae2539df8d | Bug #52941: Remove Apps category

univention-portal (4.0.5-16)
222e98467371 | Bug #52941: Styling for UMC modules

univention-portal (4.0.5-13)
69606b4a9d2b | Bug #52941: added module icons for portal page

univention-pkgdb (13.0.1-6)
e464bbec8b9a | Bug #52941: added new icons to all modules that are presented in the portal

univention-pkgdb (13.0.1-5)
3aef6f2be6fe | Bug #52941: debian changelog

univention-pkgdb (13.0.1-4)
efcb21b65147 | Bug #52941: update module icons for portal
69606b4a9d2b | Bug #52941: added module icons for portal page

univention-management-console-module-udm (10.0.1-9)
3be05b9d242a | Bug #52941: set icon for users/self and removed old icons for saml

univention-management-console-module-udm (10.0.1-5)
e464bbec8b9a | Bug #52941: added new icons to all modules that are presented in the portal

univention-management-console-module-udm (10.0.1-4)
3aef6f2be6fe | Bug #52941: debian changelog

univention-management-console-module-udm (10.0.1-2)
efcb21b65147 | Bug #52941: update module icons for portal
92171c6bf531 | fixup! Bug #52941: added module icons for portal page
69606b4a9d2b | Bug #52941: added module icons for portal page

univention-management-console-module-ucr (9.0.0-6)
e464bbec8b9a | Bug #52941: added new icons to all modules that are presented in the portal

univention-management-console-module-ucr (9.0.0-5)
3aef6f2be6fe | Bug #52941: debian changelog

univention-management-console-module-ucr (9.0.0-4)
efcb21b65147 | Bug #52941: update module icons for portal
69606b4a9d2b | Bug #52941: added module icons for portal page

univention-management-console-module-top (9.0.0-8)
e464bbec8b9a | Bug #52941: added new icons to all modules that are presented in the portal

univention-management-console-module-top (9.0.0-7)
3aef6f2be6fe | Bug #52941: debian changelog

univention-management-console-module-top (9.0.0-6)
efcb21b65147 | Bug #52941: update module icons for portal
69606b4a9d2b | Bug #52941: added module icons for portal page

univention-management-console-module-top (9.0.0-5)
88725d897c97 | Bug #52941: readding umc-top icons from version 3.2

univention-management-console-module-services (9.0.0-6)
e464bbec8b9a | Bug #52941: added new icons to all modules that are presented in the portal

univention-management-console-module-services (9.0.0-5)
3aef6f2be6fe | Bug #52941: debian changelog

univention-management-console-module-services (9.0.0-4)
efcb21b65147 | Bug #52941: update module icons for portal
92171c6bf531 | fixup! Bug #52941: added module icons for portal page
69606b4a9d2b | Bug #52941: added module icons for portal page

univention-management-console-module-diagnostic (6.0.0-9)
efcb21b65147 | Bug #52941: update module icons for portal
92171c6bf531 | fixup! Bug #52941: added module icons for portal page
69606b4a9d2b | Bug #52941: added module icons for portal page

univention-management-console-module-diagnostic (6.0.0-11)
e464bbec8b9a | Bug #52941: added new icons to all modules that are presented in the portal

univention-management-console-module-diagnostic (6.0.0-10)
3aef6f2be6fe | Bug #52941: debian changelog

univention-management-console-module-adtakeover (7.0.2-3)
e464bbec8b9a | Bug #52941: added new icons to all modules that are presented in the portal

univention-management-console (12.0.11-4)
fffb972118b4 | Bug #52941: Change /umc/ redirection to the portal

univention-management-console (12.0.11-2)
c0834f4bd0c3 | Bug #52941: Category colors

univention-management-console (12.0.11-1)
c82229bb6df7 | Bug #52941: fix dependency on librsvg2-bin to support SVG to PNG conversion
b5a2b6affca7 | Revert "fixup! Bug #52941: create missing PNG image from SVGs during build"
2898201cba00 | fixup! Bug #52941: create missing PNG image from SVGs during build
40c9f8217a71 | Bug #52941: create missing PNG image from SVGs during build

univention-join (12.0.3-6)
e464bbec8b9a | Bug #52941: added new icons to all modules that are presented in the portal

univention-join (12.0.3-5)
3aef6f2be6fe | Bug #52941: debian changelog

univention-join (12.0.3-4)
efcb21b65147 | Bug #52941: update module icons for portal
69606b4a9d2b | Bug #52941: added module icons for portal page

univention-appcenter (9.0.2-34)
e464bbec8b9a | Bug #52941: added new icons to all modules that are presented in the portal

univention-appcenter (9.0.2-28)
3aef6f2be6fe | Bug #52941: debian changelog

univention-appcenter (9.0.2-27)
efcb21b65147 | Bug #52941: update module icons for portal

univention-appcenter (9.0.2-26)
69606b4a9d2b | Bug #52941: added module icons for portal page

univention-admin-diary (2.0.2-6)
8a6e0653340f | Bug #52941: added icon tag to umc_modules file

univention-admin-diary (2.0.2-5)
fd0393717277 | Bug #52941: moved svg image to icon directory in install file

univention-admin-diary (2.0.2-4)
e464bbec8b9a | Bug #52941: added new icons to all modules that are presented in the portal

univention-ad-connector (14.0.7-3)
e464bbec8b9a | Bug #52941: added new icons to all modules that are presented in the portal
Comment 13 Florian Best univentionstaff 2021-05-05 14:16:14 CEST
I fixed the portal icon for you in:

univention-portal (4.0.5-45)
772137d895a0 | Bug #52941: add missing portal icon
Comment 14 Jan Luttermann univentionstaff 2021-05-05 15:05:38 CEST
univention-portal (4.0.5-46)
7404c3c03db2 | Bug #52941: changelog entry for missing portal icons
Comment 15 Florian Best univentionstaff 2021-05-05 22:40:20 CEST
OK: all visible modules have icons
OK: duplicate bugs are resolved here
OK: changelog entry
Comment 16 Florian Best univentionstaff 2021-05-25 16:01:52 CEST
UCS 5.0 has been released:
 https://docs.software-univention.de/release-notes-5.0-0-en.html
 https://docs.software-univention.de/release-notes-5.0-0-de.html

If this error occurs again, please use "Clone This Bug".