Bug 52957 - debian control of ucs5 server extended by removed packages
debian control of ucs5 server extended by removed packages
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: Update - univention-updater
UCS 5.0
Other Linux
: P5 normal (vote)
: UCS 5.0
Assigned To: Jan Luttermann
Florian Best
: interim-1
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2021-03-19 12:22 CET by Jan Luttermann
Modified: 2021-05-25 16:02 CEST (History)
2 users (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Luttermann univentionstaff 2021-03-19 12:22:24 CET
some packages have been removed in ucs 5.0.
 univention-mysql,
 univention-java,
 univention-passwd-store,
 univention-passwd-cache,
 univention-remote-backup,
 univention-debootstrap,
 univention-virtual-machine-manager-schema,
 python-univention-directory-manager-uvmm,
 univention-ftp,
 univention-snmp,
 univention-snmpd,
 univention-check-printers,
 univention-runit,
 univention-printquota,
 univention-doc,
 univention-management-console-doc,
 univention-samba4wins,
 univention-dansguardian

remove them in the check.sh of the updater and add them to Breaks of the univention-role-common in the univention-server package
Comment 1 Florian Best univentionstaff 2021-03-19 16:11:51 CET
I added univention-samba4wins-schema:

univention-server (15.0.3-4)
ebe6613e8d52 | fixup! Bug #52957: move the removed packages of ucs5 to the debian/control part of the server
Comment 2 Florian Best univentionstaff 2021-03-19 16:58:53 CET
Do we also need to add in-UCS-5-not-existing-packages like samba4wins? They are only a dependency of univention-samba4wins. An autoremove would remove them as well.
Comment 3 Philipp Hahn univentionstaff 2021-03-19 17:07:19 CET
(In reply to Florian Best from comment #2)
> Do we also need to add in-UCS-5-not-existing-packages like samba4wins? They
> are only a dependency of univention-samba4wins. An autoremove would remove
> them as well.

No: Only our univention-* integration packages, never the underlying packages. An Admin is free to install *any* (Debian) package on her own, removing (or even purging) them would lead to disaster.
Comment 4 Jan Luttermann univentionstaff 2021-03-25 16:37:57 CET
univention-updater (15.0.3-30)
59daf6e91b3a | fixup! Bug #52957: Switch to Conflict and move a few packages
dd4818f80348 | Bug #52957: Switch to Conflict and move a few packages
4d1ed13b6b71 | Bug #52957: move the removed packages of ucs5 to the debian/control part of the server

univention-server (15.0.3-4)
dd4818f80348 | Bug #52957: Switch to Conflict and move a few packages
ebe6613e8d52 | fixup! Bug #52957: move the removed packages of ucs5 to the debian/control part of the server
4d1ed13b6b71 | Bug #52957: move the removed packages of ucs5 to the debian/control part of the server

univention-management-console (12.0.9-1)
dd4818f80348 | Bug #52957: Switch to Conflict and move a few packages
Comment 5 Florian Best univentionstaff 2021-04-23 16:25:27 CEST
There should be a conflict to:
univention-network-manager
univention-management-console-module-packages

The following packages are removed but neither mentioned in check.sh or debian/control:
univention-nagios-dansguardian
univention-nagios-libvirtd
univention-nagios-libvirtd-kvm
univention-nagios-libvirtd-xen
univention-nagios-uvmmd
univention-printquotadb

RFC: should we add these packages also to the Conflicts section (they are only in check.sh):
univention-bacula
univention-dansguardian
univention-printquota
Comment 6 Florian Best univentionstaff 2021-04-23 16:28:01 CEST
The commits git:37709a6e561efb78f2a0d9ba514fdd1b67caf3f8 and git:d95c6c8675623e2d6a91be5e3fa7e63c322e6a53 for this bug belong to Bug #52953.
Comment 7 Jan Luttermann univentionstaff 2021-04-30 14:05:17 CEST
univention-updater (15.0.3-49)
f5ab8088e6e5 | Bug #52957: added deleted packages to univention-role-common and old packages check

univention-updater (15.0.3-45)
e065097566b1 | Bug #52957: remove hint to disable old packages check
1bfc0150e3ac | Bug #52957: Enforce univention-passwd-store to be purged

univention-updater (15.0.3-30)
59daf6e91b3a | fixup! Bug #52957: Switch to Conflict and move a few packages
dd4818f80348 | Bug #52957: Switch to Conflict and move a few packages
4d1ed13b6b71 | Bug #52957: move the removed packages of ucs5 to the debian/control part of the server

univention-server (15.0.4-3)
f5ab8088e6e5 | Bug #52957: added deleted packages to univention-role-common and old packages check

univention-server (15.0.4-2)
1bfc0150e3ac | Bug #52957: Enforce univention-passwd-store to be purged

univention-server (15.0.3-4)
dd4818f80348 | Bug #52957: Switch to Conflict and move a few packages
ebe6613e8d52 | fixup! Bug #52957: move the removed packages of ucs5 to the debian/control part of the server
4d1ed13b6b71 | Bug #52957: move the removed packages of ucs5 to the debian/control part of the server

univention-management-console (12.0.9-1)
dd4818f80348 | Bug #52957: Switch to Conflict and move a few packages

ucs-test-tools (4.0.0-2)
r52957 | bump version number (Bug #35664)

ucs-test (10.0.4-41)
d95c6c867562 | Bug #52957: fixup for uninstall for empty domains

ucs-test (10.0.4-40)
37709a6e561e | Bug #52957: fixup for Button name Manage installations
Comment 8 Florian Best univentionstaff 2021-05-03 12:21:57 CEST
REOPEN: now there are duplicates in base/univention-updater/script/check.sh

(In reply to Florian Best from comment #5)
> There should be a conflict to:
> univention-network-manager
> univention-management-console-module-packages
OK, now done.

> The following packages are removed but neither mentioned in check.sh or
> debian/control:
> univention-nagios-dansguardian
> univention-nagios-libvirtd
> univention-nagios-libvirtd-kvm
> univention-nagios-libvirtd-xen
> univention-nagios-uvmmd
> univention-printquotadb
Now they are in both files. Should they be part of only one mechanism?

> RFC: should we add these packages also to the Conflicts section (they are
> only in check.sh):
> univention-bacula
> univention-dansguardian
> univention-printquota
OK, they are not in the conflicts section as well.
Comment 9 Jan Luttermann univentionstaff 2021-05-04 10:09:12 CEST
Dublicates just have been removed.

Having them in both files is a bit of overhead, but I don't know which side to remove.

They are in the conflicts section of univention-role-common in the base/univention-server package.
Comment 10 Jan Luttermann univentionstaff 2021-05-06 11:21:10 CEST
univention-nagios-dansguardian
univention-nagios-libvirtd
univention-nagios-libvirtd-kvm
univention-nagios-libvirtd-xen
univention-nagios-uvmmd
univention-printquotadb
those packages have been remove from check.sh. Now they only appear in the conflicts section of the univention-role-common in univention-server 

univention-updater (15.0.3-53)
6786daca9312 | Bug #52957: removed univention-nagios packages from check.sh
Comment 11 Jan Luttermann univentionstaff 2021-05-06 17:20:22 CEST
changelog-5.0-0.xml
bc8fed97f132 | Bug #52957: added changelog entry

changelog entry added
Comment 12 Florian Best univentionstaff 2021-05-06 17:23:45 CEST
OK: all packages are covered.
OK: changelog entry
Comment 13 Florian Best univentionstaff 2021-05-25 16:02:11 CEST
UCS 5.0 has been released:
 https://docs.software-univention.de/release-notes-5.0-0-en.html
 https://docs.software-univention.de/release-notes-5.0-0-de.html

If this error occurs again, please use "Clone This Bug".