Bug 53092 - ucs_addServiceToLocalhost is called without "|| die" in join scripts
ucs_addServiceToLocalhost is called without "|| die" in join scripts
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: General
UCS 5.0
Other Linux
: P5 normal (vote)
: UCS 5.0-3
Assigned To: Mika Westphal
Florian Best
https://git.knut.univention.de/univen...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2021-04-14 11:20 CEST by Sönke Schwardt-Krummrich
Modified: 2023-02-13 11:41 CET (History)
5 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 4: Minor Usability: Impairs usability in secondary scenarios
Who will be affected by this bug?: 1: Will affect a very few installed domains
How will those affected feel about the bug?: 2: A Pain – users won’t like this once they notice it
User Pain: 0.046
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): bitesize
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sönke Schwardt-Krummrich univentionstaff 2021-04-14 11:20:53 CEST
The app "mailserver" has been installed via "univention-app install mailserver" on a replica node after the app had been installed on primary node and backup node too:

From /var/log/univention/appcenter.log:

 24579 packages                         21-04-13 16:06:24 [    INFO]: Calling joinscript 67univention-mail-server.inst ...
 24579 packages                         21-04-13 16:06:24 [    INFO]: 2021-04-13 16:06:24.944209785+02:00 (in joinscript_init)
 24579 packages                         21-04-13 16:06:25 [    INFO]: Object exists: cn=services,cn=univention,dc=nstx,dc=ucs
 24579 packages                         21-04-13 16:06:25 [    INFO]: Object exists: cn=SMTP,cn=services,cn=univention,dc=nstx,dc=ucs
 24579 packages                         21-04-13 16:06:26 [    INFO]: Permission denied.
 24579 packages                         21-04-13 16:06:26 [    INFO]: File: /etc/listfilter.secret
 24579 packages                         21-04-13 16:06:26 [    INFO]: Multifile: /etc/postfix/ldap.virtual
 24579 packages                         21-04-13 16:06:26 [    INFO]: Multifile: /etc/postfix/ldap.groups
 24579 packages                         21-04-13 16:06:26 [    INFO]: Multifile: /etc/postfix/ldap.virtualwithcanonical
 24579 packages                         21-04-13 16:06:26 [    INFO]: Multifile: /etc/postfix/ldap.canonicalrecipient
 24579 packages                         21-04-13 16:06:27 [    INFO]: Multifile: /etc/postfix/ldap.distlist
 24579 packages                         21-04-13 16:06:27 [    INFO]: Multifile: /etc/postfix/ldap.virtual_mailbox
 24579 packages                         21-04-13 16:06:27 [    INFO]: Multifile: /etc/postfix/ldap.sharedfolderremote
 24579 packages                         21-04-13 16:06:27 [    INFO]: Multifile: /etc/postfix/ldap.external_aliases
 24579 packages                         21-04-13 16:06:27 [    INFO]: Multifile: /etc/postfix/ldap.canonicalsender
 24579 packages                         21-04-13 16:06:27 [    INFO]: Multifile: /etc/postfix/ldap.transport
 24579 packages                         21-04-13 16:06:27 [    INFO]: Multifile: /etc/postfix/ldap.virtualdomains
 24579 packages                         21-04-13 16:06:27 [    INFO]: Multifile: /etc/postfix/ldap.sharedfolderlocal
 24579 packages                         21-04-13 16:06:27 [    INFO]: Multifile: /etc/postfix/ldap.saslusermapping
 24579 packages                         21-04-13 16:06:27 [    INFO]: Multifile: /etc/postfix/ldap.sharedfolderlocal_aliases
 24579 packages                         21-04-13 16:06:27 [    INFO]: 2021-04-13 16:06:27.827121972+02:00 (in joinscript_save_current_version)
 24579 packages                         21-04-13 16:06:27 [    INFO]: Joinscript 67univention-mail-server.inst finished with exitcode 0

Looks like the ucs_addServiceToLocalhost call failed and the join script did not die as expected.
This is also broken in nearly all other join scripts of other packages. No change in contrast to UCS 4.
Comment 1 Sönke Schwardt-Krummrich univentionstaff 2021-04-14 11:22:36 CEST
This caused the univention-mail-server join script to be run "successfully" even if ucs_addServiceToLocalhost failed. Though the service had not been registered at the computer object.
Comment 2 Florian Best univentionstaff 2023-02-06 10:54:38 CET
OK: all ucs_addServiceToLocalhost and ucs_removeServiceFromLocalhost calls now include error handling
OK: changelog entry
Comment 3 Mika Westphal univentionstaff 2023-02-08 08:35:11 CET
The join scripts was not using '|| die' which resulted in failed join scripts not generating an error. This was now corrected

univention-squid (13.0.6-1)
ac2ed422f6ae | Bug #53092: Added fail checks for ucs_addServiceToLocalhost and ucs_removeServiceFromLocalhost

univention-self-service (5.0.4-1)
ac2ed422f6ae | Bug #53092: Added fail checks for ucs_addServiceToLocalhost and ucs_removeServiceFromLocalhost

univention-saml (7.0.7-1)
ac2ed422f6ae | Bug #53092: Added fail checks for ucs_addServiceToLocalhost and ucs_removeServiceFromLocalhost

univention-samba4 (9.0.10-1)
ac2ed422f6ae | Bug #53092: Added fail checks for ucs_addServiceToLocalhost and ucs_removeServiceFromLocalhost

univention-samba (14.0.7-1)
ac2ed422f6ae | Bug #53092: Added fail checks for ucs_addServiceToLocalhost and ucs_removeServiceFromLocalhost

univention-s4-connector (14.0.12-1)
ac2ed422f6ae | Bug #53092: Added fail checks for ucs_addServiceToLocalhost and ucs_removeServiceFromLocalhost

univention-radius (7.0.4-1)
ac2ed422f6ae | Bug #53092: Added fail checks for ucs_addServiceToLocalhost and ucs_removeServiceFromLocalhost

univention-printserver (13.0.7-1)
ac2ed422f6ae | Bug #53092: Added fail checks for ucs_addServiceToLocalhost and ucs_removeServiceFromLocalhost

univention-nfs (12.0.1-3)
ac2ed422f6ae | Bug #53092: Added fail checks for ucs_addServiceToLocalhost and ucs_removeServiceFromLocalhost

univention-management-console (12.0.16-1)
ac2ed422f6ae | Bug #53092: Added fail checks for ucs_addServiceToLocalhost and ucs_removeServiceFromLocalhost

univention-mail-postfix (14.0.5-1)
ac2ed422f6ae | Bug #53092: Added fail checks for ucs_addServiceToLocalhost and ucs_removeServiceFromLocalhost

univention-mail-dovecot (6.0.6-1)
ac2ed422f6ae | Bug #53092: Added fail checks for ucs_addServiceToLocalhost and ucs_removeServiceFromLocalhost

univention-ldap (16.0.9-1)
ac2ed422f6ae | Bug #53092: Added fail checks for ucs_addServiceToLocalhost and ucs_removeServiceFromLocalhost

univention-fetchmail (13.0.2-1)
ac2ed422f6ae | Bug #53092: Added fail checks for ucs_addServiceToLocalhost and ucs_removeServiceFromLocalhost

univention-dhcp (14.0.6-1)
ac2ed422f6ae | Bug #53092: Added fail checks for ucs_addServiceToLocalhost and ucs_removeServiceFromLocalhost

univention-debmirror (11.0.1-1)
ac2ed422f6ae | Bug #53092: Added fail checks for ucs_addServiceToLocalhost and ucs_removeServiceFromLocalhost

univention-bind (14.0.4-1)
ac2ed422f6ae | Bug #53092: Added fail checks for ucs_addServiceToLocalhost and ucs_removeServiceFromLocalhost

univention-admin-diary (2.0.6-1)
ac2ed422f6ae | Bug #53092: Added fail checks for ucs_addServiceToLocalhost and ucs_removeServiceFromLocalhost

univention-ad-connector (14.0.12-1)
ac2ed422f6ae | Bug #53092: Added fail checks for ucs_addServiceToLocalhost and ucs_removeServiceFromLocalhost

join-template (1.0-1)
ac2ed422f6ae | Bug #53092: Added fail checks for ucs_addServiceToLocalhost and ucs_removeServiceFromLocalhost
Comment 4 Florian Best univentionstaff 2023-02-13 11:41:26 CET
UCS 5.0-3 has been released.

https://docs.software-univention.de/release-notes/5.0-3/en/

If this error occurs again, please clone this bug.