Univention Bugzilla – Bug 53172
DHCP build broken
Last modified: 2021-05-25 15:58:44 CEST
patches/20_restart-univention-dhcp.patch is no longer needed manual pages are not included ...
r19363 | Bug #53172: isc-dhcp Merge 21 and 22 Drop useless "export": All those environment variables are exported by dhclient as part of the API between it and the dhclient-script. As the script does not change any of those variables they need no re-export. Drop broken check for hook scripts reporting != 0: The old code "exit $?" always returned "0" as "!" inverted the failed result from "run_hook". Aborting the script on any failed hook is dangerous as any hook doing a "if cond; then ...; fi" would abort when "cond" is not met. If any script wants to abort further processing it simply could use "exit" as the hooks are sources by "dhclient-script", e.g. not executed in a sub-shell. Refactor code to output "option:timeout" for /etc/resolv.conf Package: isc-dhcp Version: 4.4.1-2A~5.0.0.202104271757 OK: for d in /var/univention/buildsystem2/apt/ucs_5.0-0/amd64/isc-dhcp-*.deb; do dpkg -c "$d"; done | grep -F /usr/share/man/ [phahn/dhcp] a21846aaf0 Bug #53175: univention-dhcp doc/changelog/changelog-5.0-0.xml | 4 ++++ 1 file changed, 4 insertions(+)
What I tested: Variables are exported (tested with dhclient debug hook) -> OK Hook scripts are executed, "exit 1" stops processing -> OK Refactor code to output "option:timeout" (moved resolvconf hook away to test this) -> OK Changelog -> OK -> Verified
UCS 5.0 has been released: https://docs.software-univention.de/release-notes-5.0-0-en.html https://docs.software-univention.de/release-notes-5.0-0-de.html If this error occurs again, please use "Clone This Bug".