Univention Bugzilla – Bug 53234
Portal blockers before release
Last modified: 2021-05-25 16:02:53 CEST
These issues should be fixed before the release - Drag and drop a portal entry to a different location and then right after drag and drop again: the portal renders portal entries multiple times and creates duplicates that are saved into the layout - the ensureLogin attribute is not savable - description, name, and links don't have a required symbol (*) and have no validation - error in csp style-src-elem. font is not loaded - javascript crashes when portal entries have only de_DE entries (on a english portal)
From phoenix: fce8001092cacc6567e61c9a4e1c48362ca32916 fix: improve folder css [#186] 3612b53865c2d552f0a5d814f12cf434289a26f4 fix: drag and drop on TileAdd.vue [#186] 629a099a9e5036221003788d3506e2fb7cb3453d fix: notifications seem out of symmetry if only headline is given [#186] 9eee927c60fef1a228d1233415f13a910121e3ff fix: center images in image upload widget [#186] 762cf0988c98ac3580929dfe0a89eafbbc443e90 fix: align buttons in add modal dialog [#186] d5db8a686e1b3c98fe390902887c099eaae76f8a fix: close tooltip when closing folder [#186] 69493ee447a3c07bbf15ffd5d2ebd4d7585e22a1 fix: align portal tiles, folders, and category headlines [#186] 3c80d97b3887a33247dae6a9df3f6817661ab9d3 fix: always return a string - an empty string is better than undefined [#186] ea97578b69cf630bda5db8829b02efbcd3efd45f fix: remove message if no search string is present (e.g. after esc) [#170] bcb3064ec17f71014e6d42de637eeefdbe1f6bda [#196] remove Tab trap 3fc46b1712ed494f2ad38a00525d139e2926348c fix: empty portal name at startup [#186] c3ddc3f381ce1b86bd93c9f7ecc5c78a7e8b881c [#133] removing unused colorvar a51a8fb4b9768dd5b0dd00b72e4a3b858bd2e6ec [#133] added focus variable d4ff3decc4d88192eb71ce7657b2df8c454ed852 [#133] cleaning vars
From phoenix: c8d42c106b4149d5d7fd8f6748b97766d656f54f fix: Form validation [#186] 02d665c71193e36ad7eeabfa632529b680268a7a Merge branch 'refactor-tooltip' into 'main' 0e70f2600b40c3edfd23da1b2013be33980352fd Merge branch 'main' of git.knut.univention.de:univention/customers/dataport/upx/portal/frontend into refactor-tooltip 25fb79dfcf1cb1743a716407f8172ae67663f4b3 [#130] cleanups d5a4df91086990993eb7c472f500f2070b549845 [#130] cleanup 3858978393b8074da6db7299b73b7e731a68376c [#130] mini cleanups a2bcafc18ce9903a09fce07f52f010cf522e18f0 [#130] add tooltip mobile styles aa54e9b7013c12fe19ad1ff1606c56934ed0115b [#130] adding mediaqueries a8eff48ad1b59ba4fa75dfde2a9d1d6b047a3405 [#130] add tooltip functionality and styles 22d91fff8ff5782b309ab1a311b260efea25f30d Merge branch 'feature/#200_form_validation' into 'main' 3fb1367ecff2184d850ffd65ca0d4ad04e8be9e7 feature(Admin Mode): Forms validation [#200] d04e0b0f0a00ca79182057d8ef708b33b63f1314 fix: have a loading animation while re-sorting entries [#186]
Also fixed - the ensureLogin attribute is not savable - error in csp style-src-elem. font is not loaded
Created attachment 10718 [details] portal entry in folder datalist
OK - Drag and drop a portal entry to a different location and then right after drag and drop again: the portal renders portal entries multiple times and creates duplicates that are saved into the layout -- OK: loading anim prevents interaction - the ensureLogin attribute is not savable -- OK: is savable - description, name, and links don't have a required symbol (*) and have no validation -- TBD: the required fields are still not marked as such (only "Internal name" is) -- OK: dialog is not closed if required fields are missing -- OK: required fields are highlighted -- ~OK: "Please enter a display name"/"Please enter a description" should mention that en_US is the required field. This message also comes if other locales are entered but not en_US -- indentation for ul elements - error in csp style-src-elem. font is not loaded -- OK: font is loaded - the other commits are OK FAIL - javascript crashes when portal entries have only de_DE entries (on a english portal) -- FAIL: still crashes when there is no en_US link Some new things I noticed -! scrolling not possible while drag and drop -! the <datalist> that is sometimes used (e.g. for adding exiting folders) can contain entries that are not valid (attachment 10718 [details]) - Adding existing folder says: "Entry successfully added" - clicking the ~add entry~ button in an open folder closes the folder which is kind of confusing
(In reply to Johannes Keiser from comment #5) > - description, name, and links don't have a required symbol (*) and have no > validation > -- TBD: the required fields are still not marked as such (only "Internal > name" is) Done > FAIL > - javascript crashes when portal entries have only de_DE entries (on a > english portal) > -- FAIL: still crashes when there is no en_US link Fixed > > > Some new things I noticed > -! scrolling not possible while drag and drop > -! the <datalist> that is sometimes used (e.g. for adding exiting folders) > can contain entries that are not valid (attachment 10718 [details]) At least we fixed the datalist bit. > > > - Adding existing folder says: "Entry successfully added" Fixed From phoenix: 86b285ac471e0ba991590723dad9342dc3476b7a fix: Notification message on adding an existing entry / folder [#186] 10c3d5a07af98452b40c1d5f046b3d10b5fe900e fix: Mark required input fields [#186] 526ca31f742c3c12358120447a2c24fb289be72c Merge branch 'main' of git.knut.univention.de:univention/customers/dataport/upx/portal/frontend into main 081362d6c9533437ab8c5d59feee5931903b88bb [#159] add aria label to folder 36b2c6f45bb5b9e75b33852d1a00102478d13e70 fix: Do not show invalid entries in datalist [#186] cfb161c6d1e8b2622dc6a1bac40bb013490e0f96 [#130] add styles only for info-button b3dc3b539c34e551492dd81a60f2fcfbaf40fe41 [#159] aria label cleanup 76f4333d91324a5fdf2f8d371fd8774331603de1 [#159] add translations to tabs in header 6b045b02f5eee4dda7ee400522e25277ae37bfae [#159] add translation to chososetabs ec58475e62eb5ab1847d965d63cc7a23ca33cca7 fix: JS Error on undefined links [#186] 43bbff5270fced2fbb84e97c9648496d1450f901 feature(Admin Mode): keep admin mode alive [#207]
OK These can be done in errata - "Links" attribute is not marked as required - drag and drop scrolling
UCS 5.0 has been released: https://docs.software-univention.de/release-notes-5.0-0-en.html https://docs.software-univention.de/release-notes-5.0-0-de.html If this error occurs again, please use "Clone This Bug".