Bug 53310 – Firefox autofills saved username into 'Description' field (regression from 4.4)

Bug 53310 - Firefox autofills saved username into 'Description' field (regression from 4.4)


Summary:	Firefox autofills saved username into 'Description' field (regression from 4.4)

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	UMC - Users
Version:	UCS 5.0
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS 5.0-0-errata
Assigned To:	Johannes Keiser
QA Contact:	Dirk Wiesenthal

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2021-05-21 10:26 CEST by Johannes Keiser
Modified:	2021-06-02 17:53 CEST (History)
CC List:	1 user (show)

See Also:
What kind of report is it?:	Development Internal
What type of bug is this?:	---
Who will be affected by this bug?:	---
How will those affected feel about the bug?:	---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:

Attachments
autofilled username (14.87 KB, image/png) 2021-05-21 10:26 CEST, Johannes Keiser	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Johannes Keiser

2021-05-21 10:26:00 CEST

When using Firefox, if the logged in user has saved his login data with the
browser, then the saved username is autofilled into the 'Description'
input field in the 'Users' module.

This is a regression from 4.4

Comment 1 Johannes Keiser

2021-05-21 10:26:20 CEST

Created attachment 10736 [details]
autofilled username

Comment 2 Johannes Keiser

2021-05-21 11:02:30 CEST

Firefox autofills the saved password in the first input with type="password"
and the saved username in the inputfield before that. Which is why the username
is filled into the 'Description' field.

We can prevent the autofill by adding autocomplete="new-password" to the
password input but then the input before the password input would still
have a dropdown from firefox which input suggesstions. In this case it is
the 'Description' field.

A workaround is to add a hidden text input field before the password input (this hidden input would get the dropdown) which was accidentally the case in 4.4,
but the hidden input field (which was not intended for a different use case) got removed with the design changes.

Fixed in
https://git.knut.univention.de/univention/ucs/-/tree/jkeiser/bug53310

Comment 3 Johannes Keiser

2021-05-26 15:05:26 CEST

Successful build
Package: univention-web
Version: 4.0.1-29A~5.0.0.202105261419
Branch: ucs_5.0-0
Scope: errata5.0-0

Comment 4 Johannes Keiser

2021-05-31 12:33:31 CEST

d8ced6b97c Bug #53310: yaml

Comment 5 Dirk Wiesenthal

2021-05-31 12:38:42 CEST

Firefox: OK again
Chrome: Still OK
YAML: OK

Comment 6 Erik Damrose

2021-06-02 17:53:36 CEST

<https://errata.software-univention.de/#/?erratum=5.0x3>