Bug 53321 - Updater should go into maintenance mode after executing preup.sh
Updater should go into maintenance mode after executing preup.sh
Status: RESOLVED WONTFIX
Product: UCS
Classification: Unclassified
Component: UMC - Software update
UCS 4.4
Other Linux
: P5 normal (vote)
: UCS 4.4-8-errata
Assigned To: UMC maintainers
UMC maintainers
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2021-05-21 18:36 CEST by Florian Best
Modified: 2021-06-09 16:06 CEST (History)
2 users (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Best univentionstaff 2021-05-21 18:36:09 CEST
When doing a release upgrade, the maintenance mode is started immediately.
If the preup.sh script then aborts the upgrade, no notice is shown and one is redirected to the login dialog.

After login in a notice is added saying that the upgrade failed, but one can easily oversee it.

We should instead execute the preup.sh still in the updater module and show its output in a pop up - before starting the maintenance mode.
Comment 1 Ingo Steuwer univentionstaff 2021-05-25 11:41:23 CEST
Would need a fix in 4.4-8
Comment 5 Dirk Wiesenthal univentionstaff 2021-06-09 16:06:22 CEST
Unfortunately, executing the preup.sh (the "check" portion of it) is not reliable.

We can postpone the maintenance mode for one call exactly. After that, the updater takes over.

An exit code != 0 may be a false positive: Any errata update (and a 4.4-9 even more so) could fix a problem that would have prevented the update. If we stopped before installing all updates, we might decrease the usability instead of increasing it.

There may be solutions for it, but the "customer space" in which a fix for this bug right here could actually shine may get very small.

So small, that in fact we would not fix it at all.