Bug 53340 - Regression: false positive warning in nagios check of ad-connector
Regression: false positive warning in nagios check of ad-connector
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: AD Connector
UCS 5.0
Other Linux
: P5 normal (vote)
: UCS 5.0-0-errata
Assigned To: Julia Bremer
Felix Botner
:
Depends on: 49981 51869
Blocks:
  Show dependency treegraph
 
Reported: 2021-05-27 11:36 CEST by Florian Best
Modified: 2021-06-02 17:53 CEST (History)
7 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 5: Major Usability: Impairs usability in key scenarios
Who will be affected by this bug?: 3: Will affect average number of installed domains
How will those affected feel about the bug?: 3: A User would likely not purchase the product
User Pain: 0.257
Enterprise Customer affected?:
School Customer affected?: Yes
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number: Ticket#2020081721000369
Bug group (optional): Regression
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Best univentionstaff 2021-05-27 11:36:03 CEST
Needs to be forward-ported to UCS 5.0.

+++ This bug was initially created as a clone of Bug #51869 +++

With the changes in Bug #49168 and Bug #50676 the nagios check for univention-ad-connector will report false positive warning if more the one ad connector is running, which having a different --configbase

root@backup131:~# ps auxf | grep univention.connector.ad.main | grep -v grep
root     30748  0.0  5.8 611756 60024 ?        S    22:31   0:00 /usr/bin/python2.7 -W ignore -m univention.connector.ad.main --configbase connector-gym-4
root     30800  0.0  5.8 611148 59552 ?        S    22:31   0:00 /usr/bin/python2.7 -W ignore -m univention.connector.ad.main --configbase connector-gym-3

root@backup131:~# /usr/lib/nagios/plugins/check_univention_ad_connector
ADCONNECTOR CRITICAL: AD connector is not running!

I propose to change the check for the processes in L92

from
/usr/lib/nagios/plugins/check_procs -w :1 -c 1: --ereg-argument-array "^([^ ]+)?python.*univention.connector.ad.main(.py)?\$" >/dev/null 2>&1

to
/usr/lib/nagios/plugins/check_procs -w 1: -c 1: --ereg-argument-array "^([^ ]+)?python.*univention.connector.ad.main(.py)?.*\$" >/dev/null 2>&1

→ warn on min 1 (instead of max 1)
→ allow multiple ad connector instances (after .py)
Comment 1 Julia Bremer univentionstaff 2021-05-28 11:21:04 CEST
Forward-port to UCS5:

0b3adb14d7 Bug #53340: yaml update
579fffdb51 Bug #53340: Fix false positive if multiple connectors are running

Package: univention-nagios-ad-connector
Version: 9.0.0-2A~5.0.0.202105281118
Branch: ucs_5.0-0
Scope: errata5.0-0
Comment 2 Felix Botner univentionstaff 2021-05-28 12:07:36 CEST
ucs5 with two connector instances

OK - no connector is running - ADCONNECTOR CRITICAL: No AD connector is running!
OK - only one - ADCONNECTOR WARNING: Less than the 2 configured AD connectors are running!
OK - both are running - ADCONNECTOR OK: System operational.
OK - more are running - ADCONNECTOR WARNING: More than the 1 configured AD connectors are running!
OK - ADCONNECTOR WARNING: There have been 3 reject(s)!

OK - yaml
Comment 3 Erik Damrose univentionstaff 2021-06-02 17:53:38 CEST
<https://errata.software-univention.de/#/?erratum=5.0x1>