Bug 53373 – Adjust ucs-school-umc-internetrules UMC module for UCS 5 Design

Bug 53373 - Adjust ucs-school-umc-internetrules UMC module for UCS 5 Design


Summary:	Adjust ucs-school-umc-internetrules UMC module for UCS 5 Design

Status:	CLOSED FIXED

Product:	UCS@school
Classification:	Unclassified
Component:	General
Version:	UCS@school 5.0
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS@school 5.0 v1
Assigned To:	Johannes Keiser
QA Contact:	Florian Best

URL:
Keywords:	interim-4

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2021-06-02 10:24 CEST by Florian Best
Modified:	2021-11-29 17:19 CET (History)
CC List:	0 users

See Also:
What kind of report is it?:	Development Internal
What type of bug is this?:	---
Who will be affected by this bug?:	---
How will those affected feel about the bug?:	---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:

Attachments
default_button (37.94 KB, image/png) 2021-07-08 13:50 CEST, Johannes Keiser	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Florian Best

2021-06-02 10:24:11 CEST

The package ucs-school-umc-internetrules needs to be adjusted for the new UCS 5.0 design.

Comment 1 Florian Best

2021-06-14 20:32:54 CEST

Additionally an icon for the module has to be added.

Comment 2 Florian Best

2021-06-21 10:25:41 CEST

The test case 91_ucsschool-selenium/02_internet_rules has to be fixed as well:

https://jenkins.knut.univention.de:8181/job/UCSschool-5.0/job/Install%20Singleserver/lastCompletedBuild/Config=s4-all-components,TestGroup=base1,UCSRelease=testing/testReport/91_ucsschool-selenium/02_internet_rules/master201/

Comment 4 Florian Best

2021-07-07 21:31:39 CEST

REOPEN: exception when clicking on "Assign rule"

AssignPage.js:251 Uncaught TypeError: _dialog.standbyDuring is not a function
    at Object._assignRule (AssignPage.js:251)
    at Object.callback (dojo.js.uncompressed.js:2968)
    at Object.<anonymous> (dojo.js.uncompressed.js:77086)
    at Object.onClick (dojo.js.uncompressed.js:2970)
    at Object._onClick (dojo.js.uncompressed.js:30926)
    at HTMLInputElement.<anonymous> (dojo.js.uncompressed.js:2968)
    at Object.__onClick (dojo.js.uncompressed.js:30913)
    at HTMLSpanElement.<anonymous> (dojo.js.uncompressed.js:2968)

Comment 5 Florian Best

2021-07-07 21:35:06 CEST

REOPEN: there is no default button in the remove dialog of "define internetrules"

OK: dark theme
OK: light theme
OK: standby animations
OK: buttons
OK: code review
OK: define internetrules
~OK: assign internetrules

Comment 6 Johannes Keiser

2021-07-08 13:49:04 CEST

(In reply to Florian Best from comment #4)
> REOPEN: exception when clicking on "Assign rule"
> 
> AssignPage.js:251 Uncaught TypeError: _dialog.standbyDuring is not a function
>     at Object._assignRule (AssignPage.js:251)
>     at Object.callback (dojo.js.uncompressed.js:2968)
>     at Object.<anonymous> (dojo.js.uncompressed.js:77086)
>     at Object.onClick (dojo.js.uncompressed.js:2970)
>     at Object._onClick (dojo.js.uncompressed.js:30926)
>     at HTMLInputElement.<anonymous> (dojo.js.uncompressed.js:2968)
>     at Object.__onClick (dojo.js.uncompressed.js:30913)
>     at HTMLSpanElement.<anonymous> (dojo.js.uncompressed.js:2968)

should be fixed with univention-web(In reply to Florian Best from comment #5)

Comment 7 Johannes Keiser

2021-07-08 13:50:35 CEST

Created attachment 10770 [details]
default_button

Comment 8 Johannes Keiser

2021-07-08 13:51:07 CEST

(In reply to Johannes Keiser from comment #7)
> Created attachment 10770 [details]
> default_button

(In reply to Florian Best from comment #5)
> REOPEN: there is no default button in the remove dialog of "define
> internetrules"

Comment 9 Florian Best

2021-07-08 14:32:36 CEST

OK: default button
OK: assign internetrule

Comment 10 Florian Best

2021-07-13 00:19:30 CEST

(In reply to Florian Best from comment #2)
> The test case 91_ucsschool-selenium/02_internet_rules has to be fixed as
> well:
> 
> https://jenkins.knut.univention.de:8181/job/UCSschool-5.0/job/
> Install%20Singleserver/lastCompletedBuild/Config=s4-all-components,
> TestGroup=base1,UCSRelease=testing/testReport/91_ucsschool-selenium/
> 02_internet_rules/master201/

REOPEN

Comment 11 Johannes Keiser

2021-07-16 14:09:43 CEST

(In reply to Florian Best from comment #10)
> (In reply to Florian Best from comment #2)
> > The test case 91_ucsschool-selenium/02_internet_rules has to be fixed as
> > well:
> > 
> > https://jenkins.knut.univention.de:8181/job/UCSschool-5.0/job/
> > Install%20Singleserver/lastCompletedBuild/Config=s4-all-components,
> > TestGroup=base1,UCSRelease=testing/testReport/91_ucsschool-selenium/
> > 02_internet_rules/master201/
> 
> REOPEN

https://git.knut.univention.de/univention/ucsschool/-/merge_requests/59

Comment 12 Florian Best

2021-08-19 20:56:08 CEST

The selenium test is still failing.

Comment 13 Johannes Keiser

2021-09-09 12:28:19 CEST

Fixed tests
Added 05_check_predefined_internetrules to check predefined internetrules

Comment 14 Florian Best

2021-09-09 17:50:49 CEST

OK: selenium test

Comment 15 Jürn Brodersen

2021-11-29 17:19:49 CET

UCS@school 5.0 v1 has been released.

https://docs.software-univention.de/release-notes-ucsschool-5.0v1-de.html

If this error occurs again, please clone this bug.