Univention Bugzilla – Bug 53385
Include patches from Phoenix
Last modified: 2021-06-23 15:55:39 CEST
The Portal has been improved for Phoenix. We should include their progress.
[5.0-0 54fba6da9f] Bug #53385: Include patches from Phoenix Date: Thu Jun 3 00:02:23 2021 +0200 69 files changed, 2206 insertions(+), 1311 deletions(-) 9f9c874ba8811c14d966d281599715b3f241ec35 [#232] fix: correct CookieBanner z-index, title placing and default text 1cc7c71f390cc547f31462276516bd1c86107496 [#232] feature: Cookie Banner not obvious enough 5fb68847fb14536dd0a36302fb0d760d1ba39706 [#232] feature: Cookie Banner not obvious enough 62344d3817b78cb6fcf681af3d51fea37fcb6b94 [#232] feature: Cookie Banner not obvious enough 4115f6be99c6532ccd3a7737f9261d080e9323b4 [#234] feat: Notifications can now be created so that they do not show up in NotificationBar 19a4e9442879386f50ebf106cdb7308d924d70aa [#220] fix: CSS for Edit Portal button 4af0a33c98e9eece8a9482932b6414cb34eca63a [#190] fix: CSS for notifications 3d089c32fe8c0c1e27ed7267a766623cf90474f2 [#190] fix: Undo debug timing d4f7b41092a6a1b2e33cedc9b9ffba29f68e2935 fixup! fixup! [#216] feat: Focus and button styling in CookieBanner e1decede5ef292e6e356196d27fcaff815f1be42 [#147] adjist margins to remove scrollar 656ef70f6040ada2ef34f29e10a843ad4ad5923b fixup! [#216] feat: Focus and button styling in CookieBanner f5bc9a7c63542a7197af48780c5187a46c15bf5b [#216] feat: Focus and button styling in CookieBanner 9b7a595bdc36959ab37a9af37c0df1204436f923 [#216] fix: Correct overflow calculation in PortalHeader 86b616195668066fea7883fe5a7b5e5fb4b52c55 fixup! [#216] fix: Correct ChooseTab activity layer 99df930d1593574dbc57dbd0d88596bc652f0c34 [#216] fix: Correct ChooseTab activity layer 55f883a61e582ef97824b8bd1fb83abcf2fda31e [#216] feat: New activity layers: Setting tabindex and keyboard arrow navigation through the store 2d768eb221e326fabf119c4c0e3240c1b22e1642 [#186] make home icon only visible for mobile users b7321e860f2a916d9b2944620ad45544c8f388bd [#147] make addTileButton and all thumbnails better in portalfolder 256d3d3e4c5030b041a10ee37a31b201e81899fc [#147] fix portaltile height bug bf009e7703659c3ddf93d89e25fab94cd319a857 [#194] Show that a menu has a submenu, with x many items d0acc0819bf53a2d6b7c45a859629c0e7a536106 [#194] show how many items folder has 1fa5764b9cb6fcfe696e199feadfae6dc72e0bc2 [#190] small lint changes 01a159c4ada042f18de49f968eff23f4f11ed4de [#190] add label text to notifications f616505cd4ba9506940662ce38c72f3713f65001 [#189] Add Label to Searchfield 275933abdbfb4a8f977fe3a6fbd32b39267fc4ee [#224] set transition property correct for buttons cce9f86ad23878422b2dccbaa4e673128cb11e51 [#193] fix: Only pass those properties that are really required 5d79dfb67ff8b67b876195d61d1e0cd6128f41b5 [#212] fix: Add style.styl 92e836bbd036eb6954aee5cef64d31c2946b7d83 [#186] added better zoom handling for folder 1e44f55c7243f6bbe45ba437aa338db1a083fa82 [#212] feat: Styles in dev mode are not compiled multiple times 6ab91483682b65597592fc4c2c3597c75c753cab [#186] adding css indikator form ore than 4 || 10 tiles in folder 65a363ce79e4bd6fe3a384093ef4306e50578d8a [#186] adding logic for folder tiles c1fbdb5116edd692fcdec9774b1c3e7e796a2814 [#186] fix: Stubborn edit modals 68847576d51b48a6d7459dda8693602f0e5716b7 [#186] fix: Checkbox styling fd0087c40c65dc5a703c93dcf0922764a027abc4 [#186] fix: Remove console.log in production 55b0a106774350d4def9579faa00df7254577d7e [#186] add sr-only class for mobile, since extend would't work 21685d0e6f1657e8f0559fdc2139d8df74ded323 [#186] add focus to editmode buttons 8da6222dfe83c1c8e779b52f6e6c1ba19f734e84 [#186] align checkbox 6d5534f27422022fb3b3cefe0b3ef514718e5771 [#159] add labels to several editmode buttons 6855b4bb77752bd8a5dc8775c8ab78306b270ea0 [#186] fix: translations bc0529e2476eeea74430c8dc7fc296e3c5b21ee7 [#204] feat: Extra layer just for loading state; keep any modal form if backend returned an error 90a56b10863f5a096784fd6f931be0422177b3f6 [#159] add emoty alt tag (user generated content) 4509de104aabf3578e23a78521a6d1a707e6491b [#159] add aria Labels 2a7084febf9c704ad9e8730465c7f7a3c06f28d2 [#186] fixing portalheader title in mobile and adding Homeicon e4d05bcab49f389c722c07c6cf22dcb44e9ad9d2 [#186] make folder responsive 105531331374fee4aec7d93a788bed66c9362115 [#186] save scrollposition c88cbdbfb509aad540a17553b3b8f8535a23a9ab [#186] transition für button background (250ms) in root.css as variable 290f4667f4a48c05bbc0ac556f655dd17b41d623 [#186] make sidenavigation scollable 08263994577c94dc9ca271f4a95277286c739522 [#186] make headerbutton round fd1ed07286ddf8fd1f55ca872277e32af7c9303a [#186] made portaltile smaller for mobile 10c8e4cd8d5ec9c0034d5e70e0da7b9505aa84f2 [#186] fix: Error when saving objects are not in notifications; more form validation on internal name e3f355b176837eb3b6f00f1ab6908d919720cf82 [#186] fix: Do not close edit forms on click outside; do close modals if switching tabs 942e8a160c52324557fedda5e8a969eeb30b0059 [#186] fix: ChooseTab layout 412989551a7c4a80b048ad15a9b1d9bcc6e48bdc [#202] feat: Revamped notifications with timeouts, multiple visible notifications, cleaner store
FYI: you can do `git remote add portal git@git.knut.univention.de:univention/customers/dataport/upx/portal/frontend.git; git fetch portal` and cherry-pick all further changes which have been made in the UCS 5 portal (`git cherry-pick 9f9c874ba8811c14d966d281599715b3f241ec35 1cc7c71f390cc547f31462276516bd1c86107496 ...`). This saves the git history and keeps ownership of the commiter. git automatically detects the pathes (except for new files). Using `git commit --amend` you can adjust the UCS bugnumber in the commit message. And if you are to lazy to do this, at least add the commit hashes to the commit messages.
Package: univention-portal Version: 4.0.5-54A~5.0.0.202106030016 Branch: ucs_5.0-0 Scope: errata5.0-0
I haven't found any regression or breaking changes. The changes look good OK: yaml (2e5427f0d0 (HEAD -> 5.0-0, origin/5.0-0) Bug #53385: yaml) Some new(ish) things - no reopen necessary: - The notifications when you e.g. successfully create a new entry do not disappear automatically. Is this the way it should be? - folders with only 3 rows of entries has scrollbar in chrome - Some modals are too big for mobile (e.g. "Create a new entry") - portal-sidenavigation - typo 'align-item' -> 'align-items' - navigating the menu with arrow keys also scrolls the page - The close buttons of iframe-tabs are focusable with tab-key while modals are open -- apart from that, do we want to hide the tabs in edit mode? or at least switch to the overview when you enter edit mode https://www.w3.org/TR/wai-aria-practices-1.1/examples/dialog-modal/dialog.html - i think the focus when tabbing in modals must not be able to break out of the modal; must be circular within the modal (https://www.w3.org/TR/wai-aria-practices-1.1/examples/dialog-modal/dialog.html) Not sure how important this is in terms of accessability guidelines - the cookie banner does not have focus when it appears
<https://errata.software-univention.de/#/?erratum=5.0x21>