Bug 53399 - Migrate settings/portal* to portals/*
Migrate settings/portal* to portals/*
Status: CLOSED FIXED
Product: UCS@school
Classification: Unclassified
Component: General
UCS@school 5.0
Other Linux
: P5 normal (vote)
: UCS@school 5.0 v1
Assigned To: Dirk Wiesenthal
Florian Best
: interim-4
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2021-06-04 17:40 CEST by Florian Best
Modified: 2021-11-29 17:19 CET (History)
1 user (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Best univentionstaff 2021-06-04 17:40:32 CEST
UCS@school uses the settings/portal* modules.
They need to be migrated to portal/*.

ucs-school-metapackage/17ucs-school-portal-entry.uinst:univention-directory-manager settings/portal_entry remove "$@" \
ucs-school-metapackage/62ucs-school-master.inst:pm = UDM.admin().version(1).get('settings/portal')
ucs-school-metapackage/62ucs-school-singlemaster.inst:pm = UDM.admin().version(1).get('settings/portal')
ucs-school-metapackage/63ucs-school-portal-entry.inst:  univention-directory-manager settings/portal create "$@" --ignore_exists \
ucs-school-metapackage/63ucs-school-portal-entry.inst:if udm settings/portal_entry list "$@" --filter cn=teacherconsole | egrep ^DN > /dev/null; then
ucs-school-metapackage/63ucs-school-portal-entry.inst:univention-directory-manager settings/portal_entry $OPERATION --ignore_exists "$@" \
ucs-school-metapackage/63ucs-school-portal-entry.inst:  univention-directory-manager settings/portal_entry modify "$@" --dn "cn=teacherconsole,cn=portal,cn=univention,$ldap_base" --set icon="$(base64 /usr/share/univention-management-consol
ucs-school-metapackage/create_demoportal.py:module_portal = modules.get("settings/portal")
ucs-school-metapackage/create_demoportal.py:module_portal_c = modules.get("settings/portal_category")
ucs-school-metapackage/create_demoportal.py:module_portal_e = modules.get("settings/portal_entry")
ucs-school-metapackage/var/www/univention/ucsschool/demo_tiles.html:                                            <a href="/univention/management/#module=udm:settings/portal_all:0:">Portaleinstellungen</a> des UMC-Moduls <em>Domäne</em> durc
ucs-test-ucsschool/90_ucsschool/31_create_demoportal.py:        {"module": "settings/portal_entry", "props": {"name": entry[0], "link": entry[5]}}
ucs-test-ucsschool/90_ucsschool/31_create_demoportal.py:            {"module": "settings/portal_category", "props": {"name": category[0]}}
ucs-test-ucsschool/90_ucsschool/31_create_demoportal.py:    expected.append({"module": "settings/portal", "props": {"name": "ucsschool_demo_portal"}})
ucs-test-ucsschool/modules/univention/testing/ucsschool/computerroom.py:        partial_old_settings.pop("period")
Comment 1 Florian Best univentionstaff 2021-06-17 10:45:25 CEST
Traceback (most recent call last):
  File "/usr/share/ucs-school-metapackage/scripts/create_demoportal.py", line 416, in <module>
    run()
  File "/usr/share/ucs-school-metapackage/scripts/create_demoportal.py", line 374, in run
    create_portal()
  File "/usr/share/ucs-school-metapackage/scripts/create_demoportal.py", line 366, in create_portal
    o.create()
  File "/usr/lib/python2.7/dist-packages/univention/admin/handlers/__init__.py", line 543, in create
    dn = self._create(response=response, serverctrls=serverctrls)
  File "/usr/lib/python2.7/dist-packages/univention/admin/handlers/__init__.py", line 1269, in _create
    six.reraise(exc[0], exc[1], exc[2])
  File "/usr/lib/python2.7/dist-packages/univention/admin/handlers/__init__.py", line 1251, in _create
    self.lo.add(self.dn, al, serverctrls=serverctrls, response=response)
  File "/usr/lib/python2.7/dist-packages/univention/admin/uldap.py", line 778, in add
    raise univention.admin.uexceptions.ldapError(_err2str(msg), original_exception=msg)
univention.admin.uexceptions.ldapError: No such object
Comment 3 Florian Best univentionstaff 2021-07-16 00:21:35 CEST
This looks good so far:

ucs-school-metapackage (13.0.3)
79721a9c4f81 | Bug #53399: Remove unneeded ucs-school-metapackage/17ucs-school-portal-entry.uinst ucs-school-metapackage/63ucs-school-portal-entry.inst
fec2e1e2150d | Bug #53399: Remove old code from ucs-school-metapackage/62ucs-school-*.inst
601c721f660b | Bug #53399: Adjust naming and link in ucs-school-metapackage/var/www/univention/ucsschool/demo_tiles.html
9f376a91fd92 | Bug #53399: Migrate ucs-school-metapackage/create_demoportal.py to new portal

Only missing thing is:
ucs-test-ucsschool/90_ucsschool/31_create_demoportal.py:        {"module": "settings/portal_entry", "props": {"name": entry[0], "link": entry[5]}}
ucs-test-ucsschool/90_ucsschool/31_create_demoportal.py:            {"module": "settings/portal_category", "props": {"name": category[0]}}
ucs-test-ucsschool/90_ucsschool/31_create_demoportal.py:    expected.append({"module": "settings/portal", "props": {"name": "ucsschool_demo_portal"}})
Comment 4 Florian Best univentionstaff 2021-07-23 14:21:31 CEST
ucs-school-metapackage (13.0.3)
79721a9c4f81 | Bug #53399: Remove unneeded ucs-school-metapackage/17ucs-school-portal-entry.uinst ucs-school-metapackage/63ucs-school-portal-entry.inst
fec2e1e2150d | Bug #53399: Remove old code from ucs-school-metapackage/62ucs-school-*.inst
601c721f660b | Bug #53399: Adjust naming and link in ucs-school-metapackage/var/www/univention/ucsschool/demo_tiles.html
9f376a91fd92 | Bug #53399: Migrate ucs-school-metapackage/create_demoportal.py to new portal
Comment 5 Florian Best univentionstaff 2021-08-19 20:51:37 CEST
REOPEN:
Traceback (most recent call last):
  File "/usr/share/ucs-test/90_ucsschool/31_create_demoportal.py", line 242, in test_create_portal
    create_demoportal_module.create_portal()
  File "/usr/share/ucs-school-metapackage/scripts/create_demoportal.py", line 313, in create_portal
    for dn, en, de in CATEGORIES:
ValueError: too many values to unpack (expected 3)
Comment 6 Florian Best univentionstaff 2021-08-24 22:39:42 CEST
(In reply to Florian Best from comment #5)
> REOPEN:
> Traceback (most recent call last):
>   File "/usr/share/ucs-test/90_ucsschool/31_create_demoportal.py", line 242,
> in test_create_portal
>     create_demoportal_module.create_portal()
>   File "/usr/share/ucs-school-metapackage/scripts/create_demoportal.py",
> line 313, in create_portal
>     for dn, en, de in CATEGORIES:
> ValueError: too many values to unpack (expected 3)
Looks like that the test case installed the version from UCS@school 4.4. The code is not present in the latest version.
Comment 7 Florian Best univentionstaff 2021-08-24 22:42:13 CEST
OK: fixes

I added a changelog entry:

changelog-ucsschool-5.0-de.xml
95a6801d78c4 | Changelog Bug #53399
Comment 8 Jürn Brodersen univentionstaff 2021-11-29 17:19:25 CET
UCS@school 5.0 v1 has been released.

https://docs.software-univention.de/release-notes-ucsschool-5.0v1-de.html

If this error occurs again, please clone this bug.