Bug 53466 - adtakeover: AttributeError: 'int' object has no attribute 'find'
adtakeover: AttributeError: 'int' object has no attribute 'find'
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: AD Takeover
UCS 4.4
Other Linux
: P5 normal (vote)
: UCS 5.0-0-errata
Assigned To: Florian Best
Arvid Requate
:
: 54048 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2021-06-18 23:03 CEST by Florian Best
Modified: 2021-11-18 13:02 CET (History)
3 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 6: Setup Problem: Issue for the setup process
Who will be affected by this bug?: 2: Will only affect a few installed domains
How will those affected feel about the bug?: 4: A User would return the product
User Pain: 0.274
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number: 2021061821000618, 2021080521000746, 2021100521000661, 2021100921000136, 2021100921000136
Bug group (optional): Error handling, External feedback, Regression
Max CVSS v3 score:


Attachments
patch (1.66 KB, patch)
2021-06-18 23:10 CEST, Florian Best
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Best univentionstaff 2021-06-18 23:03:51 CEST
Version: 5.0-0 errata14

Remark: AD Takeover didn't work on 4.4. It doesn't work on 5.0. Does this product really work or is it vaporware? 

Error: 
Traceback (most recent call last):
  File "%PY3%/univention/management/console/modules/adtakeover/__init__.py", line 61, in _background
    result = func(self, request)
  File "%PY3%/univention/management/console/modules/adtakeover/__init__.py", line 110, in copy_domain_data
    takeover.join_to_domain_and_copy_domain_data(ip, username, password, self.progress)
  File "%PY3%/univention/management/console/modules/adtakeover/takeover.py", line 312, in join_to_domain_and_copy_domain_data
    takeover.rewrite_sambaSIDs_in_OpenLDAP()
  File "%PY3%/univention/management/console/modules/adtakeover/takeover.py", line 1338, in rewrite_sambaSIDs_in_OpenLDAP
    char_idx = address.find("@")
AttributeError: 'int' object has no attribute 'find'
Comment 1 Florian Best univentionstaff 2021-06-18 23:10:26 CEST
Created attachment 10752 [details]
patch

Regression in git:8d2918450517ba7d955539f0199f379d24be4883. Patch attached.
Comment 4 Florian Best univentionstaff 2021-10-13 16:59:20 CEST
Fixed in:

univention-management-console-module-adtakeover.yaml
551160d136c9 | Bug #53466: fix AD takeover if AD contains mail or proxyAddresses attributes

univention-management-console-module-adtakeover (7.0.2-4)
551160d136c9 | Bug #53466: fix AD takeover if AD contains mail or proxyAddresses attributes
    
    TODO: our Jenkins-Tests should set up a domain with a lot of existing
    objects before doing the takeover.
    
    Fixes: 8d2918450517ba7d955539f0199f379d24be4883
Comment 5 Arvid Requate univentionstaff 2021-11-01 15:10:04 CET
Verified:
* Code review
* Package has been built
* Advisory
Comment 7 Arvid Requate univentionstaff 2021-11-10 18:14:37 CET
*** Bug 54048 has been marked as a duplicate of this bug. ***