Bug 53506 - Syntax check for School-OU name only done on singleserver
Syntax check for School-OU name only done on singleserver
Status: CLOSED FIXED
Product: UCS@school
Classification: Unclassified
Component: Ucsschool-lib
UCS@school 4.4
Other Linux
: P5 normal (vote)
: UCS@school 5.0 v2
Assigned To: Johannes Königer
Tobias Wenzel
https://git.knut.univention.de/univen...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2021-06-24 08:22 CEST by Daniel Tröder
Modified: 2022-07-15 08:31 CEST (History)
3 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 3: Simply Wrong: The implementation doesn't match the docu
Who will be affected by this bug?: 2: Will only affect a few installed domains
How will those affected feel about the bug?: 2: A Pain – users won’t like this once they notice it
User Pain: 0.069
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Tröder univentionstaff 2021-06-24 08:22:21 CEST
The regex for characters in an OU-name and their order is only applied, when an OU is created on a singleserver system. On multiserver systems this allows for invalid OU-names.

Make sure the naming restrictions for OU-names are also applied on multiserver systems.
Comment 4 Johannes Königer univentionstaff 2022-05-24 18:33:13 CEST
Possibility to reproduce the bug (UCS 5.0-1 errata 310, UCS@School 5.0 v1) on a multiserver environment:
/usr/share/ucs-school-import/scripts/create_ou t€est1 test2 test3
Comment 5 Tobias Wenzel univentionstaff 2022-05-25 17:14:51 CEST
qa

QA

- [x] code -> see mr
- [x] changelog ok
- [x] manual qa `*`


`*` 

- `/usr/share/ucs-school-import/scripts/create_ou bad€ou_name somedcname` -> now raises the correct validation error (invalid school name)
- the tests runs on primary, replica (and backup, although we don't have a jenkins test for this)


please merge + build
Comment 6 Johannes Königer univentionstaff 2022-05-25 17:42:00 CEST
The syntax check of school ou names is now done on single-server and multi-server environments with commit bd1e7329f.
A test for the school name validation has been added with commit 63ee1c59f.
Comment 8 Tobias Wenzel univentionstaff 2022-07-15 08:31:09 CEST
UCS@school 5.0 v2 has been released.

https://docs.software-univention.de/changelog-ucsschool-5.0v2-de.html

If this error occurs again, please clone this bug.