Bug 53624 - computerroom/query: Error: Unknown IP address
computerroom/query: Error: Unknown IP address
Status: CLOSED FIXED
Product: UCS@school
Classification: Unclassified
Component: UMC - Computer room
UCS@school 5.0
Other Linux
: P5 normal (vote)
: UCS@school 5.0 v4-errata
Assigned To: Tobias Wenzel
J Leadbetter
https://git.knut.univention.de/univen...
:
: 53570 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2021-07-30 14:49 CEST by Christian Castens
Modified: 2023-11-16 14:21 CET (History)
8 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 5: Major Usability: Impairs usability in key scenarios
Who will be affected by this bug?: 2: Will only affect a few installed domains
How will those affected feel about the bug?: 5: Blocking further progress on the daily work
User Pain: 0.286
Enterprise Customer affected?:
School Customer affected?: Yes
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number: 2022071321000605, 2021100421000207, 2021120821000536, 2021121321000562, 2023053121000191, 2022121021000137, 2022090521000788, 2023011321000552, 2023090521000151, 2023102021000272
Bug group (optional): Error handling, External feedback
Max CVSS v3 score:


Attachments
UI fix for Bug 53624 showing a computer missing an IP address with an orange icon and hover text (43.26 KB, image/png)
2023-11-13 11:06 CET, J Leadbetter
Details
New Icon (29.04 KB, image/png)
2023-11-16 09:27 CET, Tobias Wenzel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Castens univentionstaff 2021-07-30 14:49:20 CEST
This occurs when a Windows client joins a UCS@School domain and you do not specify the IP address of the Windows client in the "Computers (schools)" module after joining.

If you assign that computer to a computer room and then try to open the "Computer Room" module and select a room, without specifying the IP of the joined Windows computer first, the following Traceback will show up.

(I've only tested this for a missing IP address but this could probably also happen if you do not specify the MAC address of the joined client since that is also a required field)


Internal server error during "computerroom/query".
Request: computerroom/query

Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/univention/management/console/base.py", line 344, in __error_handling
    six.reraise(etype, exc, etraceback)
  File "/usr/lib/python3/dist-packages/six.py", line 693, in reraise
    raise value
  File "/usr/lib/python3/dist-packages/univention/management/console/base.py", line 247, in execute
    function.__func__(self, request, *args, **kwargs)
  File "/usr/lib/python3/dist-packages/ucsschool/lib/school_umc_ldap_connection.py", line 154, in wrapper_func
    return func(*args, **kwargs)
  File "/usr/lib/python3/dist-packages/univention/management/console/modules/computerroom/__init__.py", line 534, in query
    result = [computer.dict for computer in self._computerroom.values()]
  File "/usr/lib/python3/dist-packages/univention/management/console/modules/computerroom/__init__.py", line 534, in <listcomp>
    result = [computer.dict for computer in self._computerroom.values()]
  File "/usr/lib/python3/dist-packages/univention/management/console/modules/computerroom/room_management.py", line 526, in dict
    "ip": self.ipAddress,
  File "/usr/lib/python3/dist-packages/univention/management/console/modules/computerroom/room_management.py", line 453, in ipAddress
    raise ComputerRoomError("Unknown IP address")
univention.management.console.modules.computerroom.room_management.ComputerRoomError: Unknown IP address
Comment 1 Florian Best univentionstaff 2021-08-03 07:35:59 CEST
*** Bug 53570 has been marked as a duplicate of this bug. ***
Comment 2 Christian Castens univentionstaff 2021-10-05 10:11:30 CEST
Version: 4.4-8 errata1057 (Blumenthal) - UCS@school 4.4 v9

Remark: Kann auf keinen Computerraum zugreifen

Error:
Interner Server-Fehler in "computerroom/query".
Request: computerroom/query

Traceback (most recent call last):
  File "%PY2.7%/univention/management/console/base.py", line 359, in __error_handling
    six.reraise(etype, exc, etraceback)
  File "%PY2.7%/univention/management/console/base.py", line 262, in execute
    function.__func__(self, request, *args, **kwargs)
  File "%PY2.7%/ucsschool/lib/school_umc_ldap_connection.py", line 145, in wrapper_func
    return func(*args, **kwargs)
  File "%PY2.7%/univention/management/console/modules/computerroom/__init__.py", line 551, in query
    result = [computer.dict for computer in self._italc.values()]
  File "%PY2.7%/univention/management/console/modules/computerroom/room_management.py", line 1080, in dict
    "ip": self.ipAddress,
  File "%PY2.7%/univention/management/console/modules/computerroom/room_management.py", line 1007, in ipAddress
    raise ComputerRoomError("Unknown IP address")
ComputerRoomError: Unknown IP address

Role: domaincontroller_slave
Comment 3 Maximilian Janßen univentionstaff 2022-07-15 13:22:51 CEST
reported again: Version: 5.0-1 errata342 - UCS@school 5.0 v1; traceback see Description
Comment 4 Stefan Gohmann univentionstaff 2023-06-01 13:25:26 CEST
Added another support ticket: #2023053121000191

UCS VERSION: 5.0-3 Errata 677

Interner Server-Fehler in "computerroom/query".
Request: computerroom/query

Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/univention/management/console/base.py", line 351, in __error_handling
    six.reraise(etype, exc, etraceback)
  File "/usr/lib/python3/dist-packages/six.py", line 693, in reraise
    raise value
  File "/usr/lib/python3/dist-packages/univention/management/console/base.py", line 254, in execute
    function.__func__(self, request, *args, **kwargs)
  File "/usr/lib/python3/dist-packages/ucsschool/lib/school_umc_ldap_connection.py", line 156, in wrapper_func
    return func(*args, **kwargs)
  File "/usr/lib/python3/dist-packages/univention/management/console/modules/computerroom/__init__.py", line 562, in query
    result = &#91;computer.dict for computer in self._computerroom.values()&#93;
  File "/usr/lib/python3/dist-packages/univention/management/console/modules/computerroom/__init__.py", line 562, in <listcomp>
    result = &#91;computer.dict for computer in self._computerroom.values()&#93;
  File "/usr/lib/python3/dist-packages/univention/management/console/modules/computerroom/room_management.py", line 526, in dict
    "ip": self.ipAddress,
  File "/usr/lib/python3/dist-packages/univention/management/console/modules/computerroom/room_management.py", line 453, in ipAddress
    raise ComputerRoomError("Unknown IP address")
univention.management.console.modules.computerroom.room_management.ComputerRoomError: Unknown IP address
Comment 6 Mika Westphal univentionstaff 2023-09-11 12:55:31 CEST
2023090521000151  5.0-4 errata771 - UCS@school 5.0 v4
Comment 7 Christina Scheinig univentionstaff 2023-10-23 09:30:12 CEST
Happened again. The customer is not able to finish an exam, because switching to the computerroom, the traceback occurs. (5.0.5 errata 838)

Interner Server-Fehler in "computerroom/query".
Request: computerroom/query

Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/univention/management/console/base.py", line 387, in __error_handling
    six.reraise(etype, exc, etraceback)
  File "/usr/lib/python3/dist-packages/six.py", line 693, in reraise
    raise value
  File "/usr/lib/python3/dist-packages/univention/management/console/base.py", line 285, in execute
    function.__func__(self, request, *args, **kwargs)
  File "/usr/lib/python3/dist-packages/ucsschool/lib/school_umc_ldap_connection.py", line 156, in wrapper_func
    return func(*args, **kwargs)
  File "/usr/lib/python3/dist-packages/univention/management/console/modules/computerroom/__init__.py", line 562, in query
    result = [computer.dict for computer in self._computerroom.values()]
  File "/usr/lib/python3/dist-packages/univention/management/console/modules/computerroom/__init__.py", line 562, in <listcomp>
    result = [computer.dict for computer in self._computerroom.values()]
  File "/usr/lib/python3/dist-packages/univention/management/console/modules/computerroom/room_management.py", line 526, in dict
    "ip": self.ipAddress,
  File "/usr/lib/python3/dist-packages/univention/management/console/modules/computerroom/room_management.py", line 453, in ipAddress
    raise ComputerRoomError("Unknown IP address")
univention.management.console.modules.computerroom.room_management.ComputerRoomError: Unknown IP address
Comment 8 Tobias Wenzel univentionstaff 2023-11-06 10:04:07 CET
If a computer does not have an IP address, it will not anymore raise an error and be still displayed in the computerroom. 

It's icon (which displays the computer's status) will change it's color to orange and the status will say "The computer is unreachable because no IP address has been assigned to the computer object.".

With this issue, also https://forge.univention.org/bugzilla/show_bug.cgi?id=53571 
is fixed.

Merged & built with

Package: ucs-school-umc-computerroom
Version: 12.0.14
Branch: ucs_5.0-0
Scope: ucs-school-5.0

Package: ucs-test-ucsschool
Version: 7.3.148
Branch: ucs_5.0-0
Scope: ucs-school-5.0
Comment 9 J Leadbetter univentionstaff 2023-11-13 11:06:48 CET
Created attachment 11142 [details]
UI fix for Bug 53624 showing a computer missing an IP address with an orange icon and hover text

I have verified the bug fix works as intended. When a computer is added without an IP address to a computer room, it no longer throws an error. Instead, it displays the computer with an orange icon. When hovering over the computer, the explanation is provided that the computer is missing an IP address. Additionally, when the room is first loaded, there are warnings in the logs that the computer is misconfigured.
Comment 10 Tobias Wenzel univentionstaff 2023-11-15 16:03:52 CET
Package: ucs-school-umc-computerroom
Version: 12.0.15
Branch: ucs_5.0-0
Scope: ucs-school-5.0

changed icon to orange attention sign
Comment 11 Tobias Wenzel univentionstaff 2023-11-16 09:27:53 CET
Created attachment 11144 [details]
New Icon

We changed the icon to an orange attention sign.
Comment 12 J Leadbetter univentionstaff 2023-11-16 14:21:08 CET
Errata updates for UCS@school 5.0 v4 have been released.

https://docs.software-univention.de/ucsschool-changelog/5.0v4/en/changelog.html
https://docs.software-univention.de/ucsschool-changelog/5.0v4/de/changelog.html

If this error occurs again, please clone this bug.