Bug 53629 - The windows explorer crashes, if the share security section in a printer properties security tab
The windows explorer crashes, if the share security section in a printer prop...
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: Samba4
UCS 5.0
amd64 Windows 10
: P5 major with 1 vote (vote)
: UCS 5.0-1-errata
Assigned To: Julia Bremer
Erik Damrose
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2021-08-03 19:44 CEST by Philip Hill
Modified: 2022-01-31 15:17 CET (History)
4 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 7: Crash: Bug causes crash or data loss
Who will be affected by this bug?: 2: Will only affect a few installed domains
How will those affected feel about the bug?: 3: A User would likely not purchase the product
User Pain: 0.240
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Regression
Max CVSS v3 score:
bremer: Patch_Available+


Attachments
svn history (9.37 KB, text/x-log)
2021-09-28 12:22 CEST, Florian Best
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Philip Hill 2021-08-03 19:44:05 CEST
This appeared when I upgraded to 5.0.0 
i am on errata 59.
tested on windows 10 pro 20h2 connected to ucs domain.
single ucs server as ad 
This seems similar to bug id 49747 but it only is effecting printer properties security. Bug 49747 also had a problem with printers.
The explorer crashes when you go to a printer properties and enter the security tab of the printer.
This is a problem for me as I add everyone to manage the printer I set up.
 
I Remember but 49747 was partially fix (temp)  and at that time produced these exact results then i think upstream fix it properly.
I created a test share and that worked ok so it is only printer security causing issues.
Comment 1 Julia Bremer univentionstaff 2021-08-04 10:45:03 CEST
Thank you for your bug report.

As far as I know, this issue isn't fixed upstream yet, but our patches are still active.
Was this only reproducible after the upgrade or did you notice this issue with UCS4 as well?
Comment 2 Philip Hill 2021-08-04 13:01:20 CEST
It was not a problem on ucs 4 .I only just upgraded to ucs 5.0.0 on the 31/07/21 and then i notice the problem when adding a printer. There is a very small possibility that it occurred when i updated all the errata on ucs 4 before upgrading to 5 but i think this is very unlikely as there was very few patches/ errata to apply. 
I use ucs in a kvm guest on a ubuntu kvm server.I took a backup image of kvm img just before upgrade and i still have this.I could setup lab with this image but it would take me some time.
Comment 3 Julia Bremer univentionstaff 2021-08-05 13:56:17 CEST
I just checked our patches, and it seems like the changes we made for Bug #50601 (clone of Bug #49747) were not applied to the UCS5 version of samba. 
(diff svn/patches/samba/5.0-0-0-ucs/2\:4.13.0-1/99_bug49747.quilt svn/patches/samba/4.4-0-0-ucs/2\:4.10.18-1-errata4.4-8/99_bug49747.quilt) 

This means the crashes are only fixed for S-1-22*, but not for S-1-15*, S-1-16*, S-1-17* and S-1-18*.

We should apply the complete patch again and check if more patches beside this one are outdated.
Comment 4 Florian Best univentionstaff 2021-09-28 12:22:31 CEST
Created attachment 10834 [details]
svn history
Comment 5 Philip Hill 2021-12-05 16:25:03 CET
this bug is still present at errata 164
Comment 6 José Echeverría 2022-01-15 15:15:35 CET
Thank you for your support, I upgraded to 5.0-1 errata 187 and the bug is still present :(

Whenever you look at the security tab, even with an admin user explorer.exe crashes.

Is there a manual fix that I could patch?
Please help us with these fixes, they create a bad perception of your great project

Thanks in advance

José
Comment 7 Julia Bremer univentionstaff 2022-01-25 10:58:08 CET
Successful build
Package: samba
Version: 2:4.13.13-1A~5.0.0.202201242102
Branch: ucs_5.0-0
Scope: errata5.0-1

r19507 | jbremer | Bug #53629: Add well-known-sid

I reapplied the patch we used in 4.4 to mitigate the crashing explorer.
Comment 8 José Echeverría 2022-01-26 16:27:29 CET
Thank you Julia for the effort, I have two question.
I'm already up to date with all the packages:


univention-samba-local-config/errata501,now 14.0.5-4A~5.0.0.202201102049 all [installed,automatic]
univention-samba4-sysvol-sync/errata501,now 9.0.6-8A~5.0.0.202201181446 all [installed,automatic]
univention-samba4/errata501,now 9.0.6-8A~5.0.0.202201181446 amd64 [installed]


how do I force the patched package install?
Or should I wait for the next package errata to be released?
Thanks

José
Comment 9 Julia Bremer univentionstaff 2022-01-26 16:31:34 CET
(In reply to José Echeverría from comment #8)
> Thank you Julia for the effort, I have two question.
> I'm already up to date with all the packages:
> 
> 
> univention-samba-local-config/errata501,now 14.0.5-4A~5.0.0.202201102049 all
> [installed,automatic]
> univention-samba4-sysvol-sync/errata501,now 9.0.6-8A~5.0.0.202201181446 all
> [installed,automatic]
> univention-samba4/errata501,now 9.0.6-8A~5.0.0.202201181446 amd64 [installed]
> 
> 
> how do I force the patched package install?
> Or should I wait for the next package errata to be released?
> Thanks
> 
> José

Hi José,
Sorry for taking so long.
I applied the patch  internally. The status resolved fixed means that the QA is still pending. Hopefully the package can be released next week. Then, the status will be set to closed fixed. You will have to wait until then.
Best regards,
Julia
Comment 10 José Echeverría 2022-01-26 16:33:49 CET
OK, don't worry thank you Julia ;)

José
Comment 11 Erik Damrose univentionstaff 2022-01-31 14:55:02 CET
OK: Fixed patch 98_bug49747.quilt
OK: No more explorer crashes when affected SIDs are in use
OK: yaml
Verified