Bug 53665 - UCS@school 5.0 design: Implement light theme
UCS@school 5.0 design: Implement light theme
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UMC (Generic)
UCS 5.0
Other Linux
: P5 normal (vote)
: UCS 5.0-0-errata
Assigned To: Johannes Keiser
Florian Best
:
Depends on: 53390
Blocks: 52578 53307
  Show dependency treegraph
 
Reported: 2021-08-16 15:42 CEST by Florian Best
Modified: 2021-09-15 17:41 CEST (History)
3 users (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Cleanup, Design, Usability
Max CVSS v3 score:
best: Patch_Available+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Best univentionstaff 2021-08-16 15:42:29 CEST
For the light theme compatibility and the functionality of UCS@school 5.0 UMC modules, we need to make various adjustments in univention-web.

Current status is in git:jkeiser/school_ucs5_design.

+++ This bug was initially created as a clone of Bug #53390 +++

univention-web-style should ship

/usr/share/univention-web/themes/dark.css
/usr/share/univention-web/themes/light.css

+++ This bug was initially created as a clone of Bug #53307 +++

Every web interface (e.g., portal, UMC, login) gets another `link rel="stylesheet"`.

**It is the same for all web interfaces**: `/univention/theme.css`

We need a UCR module that listens to a UCR variable, that sets the path to the actual theme file that holds the content. Example:
`ucr set ucs/web/theme=/usr/share/univention-web/dark.css`
It would then add a symlink to `/var/www/univention/theme.css`.

Which variables are needed for a light theme? Document these, as for now, they define the officially supported range of a theme.

Make sure the variable names are speaking, e.g. "--color-contrast-high" instead of "--color-white".
Comment 2 Johannes Keiser univentionstaff 2021-09-07 10:56:31 CEST
365d6097ce Bug #53665: yaml                                                                                                                                                                                        
50ac3d1875 Bug #53665: Merge branch 'jkeiser/school_ucs5_design' into 5.0-0
64209c312c Bug #53665: yaml
05b70b9f3e Bug #53665: debian changelog
e66373505e Bug #53665: remove unused css class
c5ed865534 Bug #53665: remove unused widget
453758bba7 Bug #53665: remove unused css class
c250e4259c Bug #53665: focus default button if applicable
9d05fa725f Bug #53665: adjust css class names
c4c91411b8 Bug #53665: adjust dialog button row styling
c01a60dcf7 Bug #53665: fix popup styling with scrollbar
56d07dd4e9 Bug #53665: remove unused function
1c7efce516 Bug #53665: re-add italic styling
d8d90b60b0 Bug #53665: make it possible to define sprite path for icon
1bb4118903 Bug #53665: update module header buttons when module closable attr changes
33d7818c33 Bug #53665: rename umcTextBoxDark to umcTextBoxOnBody
a1a03072c1 Bug #53665: adjust TitlePane styling
b1965b20af Bug #53665: rename css class
d2359e380c Bug #53665: adjust Grid styling for buttons
9da1258a30 Bug #53665: adjust Grid styling
4f5252fadb Bug #53665: addjust ConfirmDialog styling
7f617f0b96 Bug #53665: adjust MultiUploader
35380f094c Bug #53665: adjust design of MultiUploader for UCS 5
1372ac78d3 Bug #53665: cleanup
5b2a823d96 Bug #53665: fix widget leak in dialog.confirm
afdf6d1e1c Bug #53665: adjust rendering of defaultButton
0c0f4bfae4 Bug #53665: move StandbyMixIn to base Dialog widget
3a24b38d88 Bug #53665: add option to destroy dialog on cancel (esc or button in header)
c7ea616b30 Bug #53665: remove unused function
66e873ca83 Bug #53665: adjust PasswordBox style
74484eb41e Bug #53665: adjust buttonsize in textbox
07283f22a2 Bug #53665: cleanup ProgressBar
db6416f906 Bug #53665: adjust Dialog style
87c3f05716 Bug #53665: add possibility to add class to TitlePane in render layout
9a0de074f8 Bug #53665: adjust TitlePane style
f2b6cb0029 Bug #53665: adjust nested TitlePane style in udm
804e4ecdda Bug #53665: fix gridtile items not lining up
4582bca5e2 Bug #53665: remove unused css class
735414a10c Bug #53665: adjust page header styling
cdb5958271 Bug #53665: adjust grid header
fb0a912221 Bug #53665: public function for repositioning dialog
9505b7d15e Bug #53665: adjust buttonrow in forms
Comment 3 Florian Best univentionstaff 2021-09-08 13:31:26 CEST
The following Selenium-Test are now failing:
 86_selenium.192_app_suggestions_algorithm
 86_selenium.191_app_suggestions_category
 86_selenium.190_app_suggestions_fallback
 86_selenium.153_udm_check_properties_of_copied_users
 86_selenium.137_appcenter
 86_selenium.10_product_test_password_change
Comment 4 Johannes Keiser univentionstaff 2021-09-10 10:30:01 CEST
86_selenium.153_udm_check_properties_of_copied_users
  fixed with https://forge.univention.org/bugzilla/show_bug.cgi?id=53675#c8

rest fixed with

7a39c8e964 Bug #53665: selenium add right click to click_element() / fix appcenter uninstall
7349ec044d fixup! Bug #53665: focus default button if applicable
Comment 5 Johannes Keiser univentionstaff 2021-09-10 11:34:29 CEST
95db774f16 Bug #53665: yaml
c916ff71a5 Bug #53665: Merge branch 'jkeiser/ucs5/misc' into 5.0-0
61926fad2c Bug #53665: debian changelog
3c1de8054f Bug #53665: adjust success notification in udm NewObjectDialog
bb6ecb3dcf Bug #53665: fix scrollbar in menu Dialogs
d1069bb3e2 Bug #53665: wip multiinput required
73c8b6eb28 Bug #53665: adjust udm tablabel warning color
90dfbd2d41 Bug #53665: remove double margin for umcPageNav
3661e2f6aa Bug #53665: generalize umcPage{Main,Nav}Content style
a8d4df80d5 Bug #53665: add padding at the bottom of non flex module layouts
6e01c47c6f Bug #53665: remove usage of umc-icon-button
e4c6ba451e Bug #53665: remove usage of material-outlined-button
4cab45485b Bug #53665: remove usage of material-flat-button
9d14702bcb Bug #53665: replace material-grid() with spacing()
Comment 6 Florian Best univentionstaff 2021-09-13 13:09:34 CEST
OK: YAML
OK: changes (light theme, dark theme)