Bug 53714 – App Attributes: Rewriting layout for frontend "permanently" alters backend properties

Bug 53714 - App Attributes: Rewriting layout for frontend "permanently" alters backend properties


Summary:	App Attributes: Rewriting layout for frontend "permanently" alters backend pr...

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	UMC - Users
Version:	UCS 4.4
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS 5.0-0-errata
Assigned To:	Florian Best
QA Contact:	Dirk Wiesenthal

URL:
Keywords:

Depends on:
Blocks:	53715
	Show dependency tree / graph

Reported:	2021-08-29 04:29 CEST by Dirk Wiesenthal
Modified:	2021-09-02 09:10 CEST (History)
CC List:	3 users (show)

See Also:	51283
What kind of report is it?:	Bug Report
What type of bug is this?:	5: Major Usability: Impairs usability in key scenarios
Who will be affected by this bug?:	2: Will only affect a few installed domains
How will those affected feel about the bug?:	4: A User would return the product
User Pain:	0.229
Enterprise Customer affected?:
School Customer affected?:	Yes
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Dirk Wiesenthal

2021-08-29 04:29:36 CEST

When the App Attributes are used, the frontend is presenting a slightly different layout than the backend was configured with.

To accomplish this, we generate altered properties in umc-udm/udm_ldap.py. This process may permanently alter the "descriptions" of a UDM module.

This is a problem if udm_ldap.py is used outside of umc-udm AND the process is long-living.

As is the case in the UDM REST API. Creating an object through the API executes the altering code in umc-udm. Subsequent requests now operate on changed "options" for certain attributes.

Fix around line 963:

'options': copy.deepcopy(prop.options),

Comment 1 Florian Best

2021-08-29 09:00:25 CEST

univention-management-console-module-udm.yaml
980bccaa8494 | YAML Bug #53714
e540600ac049 | Bug #53714: prevent altering of original object options through app options

univention-management-console-module-udm (10.0.1-14)
e540600ac049 | Bug #53714: prevent altering of original object options through app options

Comment 2 Dirk Wiesenthal

2021-08-30 23:50:11 CEST

Code change: OK
No regressions: OK
YAML: OK

Comment 3 Erik Damrose

2021-09-01 17:07:13 CEST

<https://errata.software-univention.de/#/?erratum=5.0x76>