Univention Bugzilla – Bug 53800
Prevent consecutive whitespaces in school group names.
Last modified: 2022-04-05 15:23:14 CEST
We split Bug 53464 - Starting an exam throws an unexpected error: - We will write a diagnose module which detects such groups in Bug 53464. - We also opened Bug 53799 to fix this upstream, but this may take some time. This Bug: We need to prevent group names like "DEMOSCHOOL-Ch Gk" because they lead to errors in the following code which is used in ucsschool-exams from samba.param import LoadParm lp.load_default() This has to be fixed in ucsschool 4.4 and feature kelvin (!) Group-names like this are most likely due to typing errors. ------------------ QA-Tasks - code review - test in single-server-env + multi-server env - create a workgroup DEMOSCHOOL-Ch GK and start an exam -> witness the error in the log + umc before the fix. This can also be done by calling the following code used in the ucsschool-lib from samba.param import LoadParm lp.load_default() - deploy fix -> no error should be raised - tests should pass + there should be a new one for this scenario. - check if samba-tool ntacl get /home/... still works - check if samba-tool testparm -d2 -s smb.conf works -> see bug
I think, when #53799 #53828 are verified, this bug can be closed, because group names with consecutive whitespaces are not dangerous anymore.
Comment #(In reply to Tobias Wenzel from comment #1) > I think, when #53799 #53828 are verified, this bug can be closed, because > group names with consecutive whitespaces are not dangerous anymore. The exam-bug is fixed, but consecutive whitespaces are still not good: it's not possible to access these shares.
(In reply to Tobias Wenzel from comment #2) > Comment #(In reply to Tobias Wenzel from comment #1) > > I think, when #53799 #53828 are verified, this bug can be closed, because > > group names with consecutive whitespaces are not dangerous anymore. > > The exam-bug is fixed, but consecutive whitespaces are still not good: it's > not possible to access these shares. I opened a new bug to track this from the samba point of view: bug 53800