Bug 53800 - Prevent consecutive whitespaces in school group names.
Prevent consecutive whitespaces in school group names.
Status: NEW
Product: UCS@school
Classification: Unclassified
Component: Ucsschool-lib
UCS@school 4.4
Other Linux
: P5 normal (vote)
: ---
Assigned To: UCS@school maintainers
:
Depends on:
Blocks: 53464
  Show dependency treegraph
 
Reported: 2021-09-16 11:19 CEST by Tobias Wenzel
Modified: 2022-04-05 15:23 CEST (History)
3 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 5: Major Usability: Impairs usability in key scenarios
Who will be affected by this bug?: 1: Will affect a very few installed domains
How will those affected feel about the bug?: 2: A Pain – users won’t like this once they notice it
User Pain: 0.057
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Wenzel univentionstaff 2021-09-16 11:19:37 CEST
We split Bug 53464 - Starting an exam throws an unexpected error:

- We will write a diagnose module which detects such groups in Bug 53464.
- We also opened Bug 53799 to fix this upstream, but this may take some time.

This Bug:

We need to prevent group names like "DEMOSCHOOL-Ch  Gk" because they lead to errors in the following code which is used in ucsschool-exams

from samba.param import LoadParm
lp.load_default()

This has to be fixed in ucsschool 4.4 and feature kelvin (!)

Group-names like this are most likely due to typing errors.

------------------

QA-Tasks

 - code review
 - test in single-server-env + multi-server env
 - create a workgroup DEMOSCHOOL-Ch  GK and start an exam -> witness the error in the log + umc before the fix. This can also be done by calling the following code used in the ucsschool-lib

from samba.param import LoadParm
lp.load_default()

 - deploy fix -> no error should be raised
 - tests should pass + there should be a new one for this scenario.
 - check if samba-tool ntacl get /home/... still works
 - check if samba-tool testparm -d2 -s smb.conf works -> see bug
Comment 1 Tobias Wenzel univentionstaff 2021-09-24 11:15:50 CEST
I think, when #53799 #53828 are verified, this bug can be closed, because group names with consecutive whitespaces are not dangerous anymore.
Comment 2 Tobias Wenzel univentionstaff 2021-09-27 10:36:28 CEST
Comment #(In reply to Tobias Wenzel from comment #1)
> I think, when #53799 #53828 are verified, this bug can be closed, because
> group names with consecutive whitespaces are not dangerous anymore.

The exam-bug is fixed, but consecutive whitespaces are still not good: it's not possible to access these shares.
Comment 3 Jürn Brodersen univentionstaff 2021-10-06 14:50:47 CEST
(In reply to Tobias Wenzel from comment #2)
> Comment #(In reply to Tobias Wenzel from comment #1)
> > I think, when #53799 #53828 are verified, this bug can be closed, because
> > group names with consecutive whitespaces are not dangerous anymore.
> 
> The exam-bug is fixed, but consecutive whitespaces are still not good: it's
> not possible to access these shares.

I opened a new bug to track this from the samba point of view: bug 53800