Bug 53803 – univention.appcenter.docker.inspect_with_retry: error handling broken

Bug 53803 - univention.appcenter.docker.inspect_with_retry: error handling broken


Summary:	univention.appcenter.docker.inspect_with_retry: error handling broken

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	App Center
Version:	UCS 5.0
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS 5.0-0-errata
Assigned To:	Florian Best
QA Contact:	Dirk Wiesenthal

URL:
Keywords:

Depends on:	53273
Blocks:
	Show dependency tree / graph

Reported:	2021-09-16 20:01 CEST by Florian Best
Modified:	2021-09-29 17:10 CEST (History)
CC List:	0 users

See Also:
What kind of report is it?:	Development Internal
What type of bug is this?:	---
Who will be affected by this bug?:	---
How will those affected feel about the bug?:	---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):	Regression
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Florian Best

2021-09-16 20:01:32 CEST

python3
>>> import univention.appcenter.docker                                                                                                        
>>> univention.appcenter.docker.inspect_with_retry('asfd')
Error: No such object: asfd
Error: No such object: asfd
Error: No such object: asfd
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib/python3/dist-packages/univention/appcenter/docker.py", line 94, in inspect_with_retry
    raise DockerInspectCallFailed('Inspect for container {} failed after {} retries: {}'.format(container, retries, e))
UnboundLocalError: local variable 'e' referenced before assignment

Comment 1 Florian Best

2021-09-17 16:52:23 CEST

univention-appcenter.yaml
e35bdf0f992c | YAML Bug #53803
e5a541db521b | Bug #53803: fix error handling in docker.inspect_with_retry()

univention-appcenter (9.0.2-68)
e5a541db521b | Bug #53803: fix error handling in docker.inspect_with_retry()

Comment 2 Dirk Wiesenthal

2021-09-29 13:54:38 CEST

Code: OK
YAML: OK

Comment 3 Erik Damrose

2021-09-29 17:10:22 CEST

<https://errata.software-univention.de/#/?erratum=5.0x105>