Bug 53906 - UMC modules that open other UMC modules are unusable when opened via portal iframe
UMC modules that open other UMC modules are unusable when opened via portal i...
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UMC (Generic)
UCS 5.0
Other Linux
: P5 normal (vote)
: UCS 5.0-0-errata
Assigned To: Johannes Keiser
Jürn Brodersen
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2021-10-14 11:03 CEST by Johannes Keiser
Modified: 2021-11-10 17:30 CET (History)
3 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 5: Major Usability: Impairs usability in key scenarios
Who will be affected by this bug?: 3: Will affect average number of installed domains
How will those affected feel about the bug?: 5: Blocking further progress on the daily work
User Pain: 0.429
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review: Yes
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments
screencast example in umc users module (1.23 MB, image/gif)
2021-10-14 11:04 CEST, Tobias Wenzel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Johannes Keiser univentionstaff 2021-10-14 11:03:08 CEST
Some UMC modules open another UMC module for some tasks,
e.g The "Users (schools)" module has a button "Create a new class"
that opens the "Classes (schools)" module.

In some situations this newly opened module is unclosable and there is no way to navigate back to the initial "Users (schools)" tab/module.

This can happen in two ways.
- Opening the "Users (schools)" module from the portal (http://fqdn/unvention/umc)
-- The portal opens UMC modules in an iframe with the query parameter ?overview=false
-- If this parameter is set the UMC does not render the tabs in the header and also does not create a close button in the modules

- It can also happen in the 'real' UMC (http://fqdn/univention/management) when the user has only 1 module available. In that case it has the same behaviour as setting the query parameter ?overview=false
Comment 1 Tobias Wenzel univentionstaff 2021-10-14 11:04:34 CEST
Created attachment 10843 [details]
screencast example in umc users module
Comment 3 Johannes Keiser univentionstaff 2021-10-26 10:16:19 CEST
This issue was deemed to be a blocking problem for the UCS@school 5 release.

As discussed the fix (for now( is to show the tabs when there is more than 1 tab open.

4764196239 Bug #53906: yaml
a6017f590e Bug #53906: yaml
42b4e730b2 Bug #53906: debian changelog
1e4600fc66 Bug #53906: dont show close button on mobile tabs if module not closable
77cccdc304 Bug #53906: show tabs when more than one module is open with ?overview=false
Comment 5 Johannes Keiser univentionstaff 2021-11-01 12:47:12 CET
2677a3af4c Bug #53906: yaml
617956c4b7 Bug #53906: yaml
1615fbd35f Bug #53906: debian changelog
2f6b71d969 Bug #53906: adjust behaviour of mobile tabs
Comment 6 Johannes Keiser univentionstaff 2021-11-02 08:36:47 CET
Added 18_overview_false.py test.

2f4a1524c0 Bug #53906: debian changelog
5a87f26abc Bug #53906: make 18_overview_false.py executable
3af333f211 Bug #53906: debian changelog
37e76d7b91 Bug #53906: add selenium test

Successful build
Package: ucs-test
Version: 10.0.6-64A~5.0.0.202111020833
Branch: ucs_5.0-0
Scope: errata5.0-0
Comment 8 Jürn Brodersen univentionstaff 2021-11-09 10:36:45 CET
(In reply to Jürn Brodersen from comment #7)
> 18_overview_false.py failed :(
> 
> https://jenkins.knut.univention.de:8181/job/UCS-5.0/job/UCS-5.0-0/job/
> AutotestJoin/lastCompletedBuild/SambaVersion=no-samba,Systemrolle=master-
> part-II/testReport/86_selenium/18_overview_false/master090/

The "Administrator" user was showing a missing property pop up which broke the test. The test now uses a new user and is fixed.

I take the liberty to set the bug to resolved again.
Comment 9 Jürn Brodersen univentionstaff 2021-11-09 10:41:44 CET
What I tested:

* changes -> OK
* Is tab switching possible?
 - Create a class from the school users umc module
  -- Desktop view -> OK
  -- Mobile view -> OK
 - Create a policy from the users module
  -- Desktop view -> OK
  -- Mobile view -> OK
* 86_selenium/18_overview_false -> OK
* yaml -> OK

-> Verified