Bug 54019 - Debugging of failed server_password_change not possible because timestamps are missing (4.4)
Debugging of failed server_password_change not possible because timestamps ar...
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: Password changes
UCS 4.4
Other Linux
: P5 normal (vote)
: UCS 4.4-8-errata
Assigned To: Esteban
Arvid Requate
https://git.knut.univention.de/univen...
:
Depends on: 53182
Blocks:
  Show dependency treegraph
 
Reported: 2021-11-01 16:02 CET by Arvid Requate
Modified: 2021-12-28 07:36 CET (History)
8 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 3: Simply Wrong: The implementation doesn't match the docu
Who will be affected by this bug?: 3: Will affect average number of installed domains
How will those affected feel about the bug?: 3: A User would likely not purchase the product
User Pain: 0.154
Enterprise Customer affected?: Yes
School Customer affected?: Yes
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number: 2021032221000553
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Arvid Requate univentionstaff 2021-11-01 16:02:16 CET
Fix also for 4.4-8.

Some commits in the 4.4-8 branch have already been done via Bug #53182 Comment 2:

UCS 4.4-8
univention-server.yaml
37f4b31de831 | Bug #53182: changelog entries

univention-server (14.0.0-17)
eaf19168bcca | Bug #53182: added timestamp to logger output of server password change

univention-mail-postfix.yaml
37f4b31de831 | Bug #53182: changelog entries

univention-mail-postfix (13.0.4-4)
eaf19168bcca | Bug #53182: added timestamp to logger output of server password change


+++ This bug was initially created as a clone of Bug #53182 +++
Comment 1 Esteban univentionstaff 2021-11-05 18:27:24 CET
univention-server.yaml
dc0f6337ac11 | Bug #54019: errata staging files created and fixed

univention-server (14.0.0-17)
7350fef0f060 | Bug #54019: Update of Debian control files. New version of shell-univention-lib
2cbb0b44cb27 | Bug #54019: Fixed timestamps for log messages (4.4)

univention-samba4.yaml
dc0f6337ac11 | Bug #54019: errata staging files created and fixed

univention-samba4 (8.0.0-36)
7350fef0f060 | Bug #54019: Update of Debian control files. New version of shell-univention-lib
619783e6bd11 | Bug #54019: Update of changelogs

univention-samba4 (8.0.0-35)
2cbb0b44cb27 | Bug #54019: Fixed timestamps for log messages (4.4)

univention-s4-connector.yaml
dc0f6337ac11 | Bug #54019: errata staging files created and fixed

univention-s4-connector (13.0.2-89)
7350fef0f060 | Bug #54019: Update of Debian control files. New version of shell-univention-lib
619783e6bd11 | Bug #54019: Update of changelogs

univention-s4-connector (13.0.2-88)
2cbb0b44cb27 | Bug #54019: Fixed timestamps for log messages (4.4)

univention-radius.yaml
dc0f6337ac11 | Bug #54019: errata staging files created and fixed

univention-radius (6.0.2-27)
7350fef0f060 | Bug #54019: Update of Debian control files. New version of shell-univention-lib
619783e6bd11 | Bug #54019: Update of changelogs

univention-radius (6.0.2-26)
2cbb0b44cb27 | Bug #54019: Fixed timestamps for log messages (4.4)

univention-mail-postfix.yaml
dc0f6337ac11 | Bug #54019: errata staging files created and fixed

univention-mail-postfix (13.0.4-5)
7350fef0f060 | Bug #54019: Update of Debian control files. New version of shell-univention-lib
619783e6bd11 | Bug #54019: Update of changelogs

univention-mail-postfix (13.0.4-4)
2cbb0b44cb27 | Bug #54019: Fixed timestamps for log messages (4.4)

univention-mail-dovecot.yaml
dc0f6337ac11 | Bug #54019: errata staging files created and fixed

univention-mail-dovecot (5.0.1-14)
7350fef0f060 | Bug #54019: Update of Debian control files. New version of shell-univention-lib
619783e6bd11 | Bug #54019: Update of changelogs

univention-mail-dovecot (5.0.1-13)
2cbb0b44cb27 | Bug #54019: Fixed timestamps for log messages (4.4)

univention-lib.yaml
dc0f6337ac11 | Bug #54019: errata staging files created and fixed

univention-lib (8.0.1-44)
619783e6bd11 | Bug #54019: Update of changelogs

univention-lib (8.0.1-43)
2cbb0b44cb27 | Bug #54019: Fixed timestamps for log messages (4.4)

univention-dhcp.yaml
dc0f6337ac11 | Bug #54019: errata staging files created and fixed

univention-dhcp (13.0.0-8)
7350fef0f060 | Bug #54019: Update of Debian control files. New version of shell-univention-lib
619783e6bd11 | Bug #54019: Update of changelogs

univention-dhcp (13.0.0-7)
2cbb0b44cb27 | Bug #54019: Fixed timestamps for log messages (4.4)

univention-bind.yaml
dc0f6337ac11 | Bug #54019: errata staging files created and fixed

univention-bind (13.0.1-12)
7350fef0f060 | Bug #54019: Update of Debian control files. New version of shell-univention-lib
619783e6bd11 | Bug #54019: Update of changelogs

univention-bind (13.0.1-11)
2cbb0b44cb27 | Bug #54019: Fixed timestamps for log messages (4.4)
Comment 3 Arvid Requate univentionstaff 2021-11-18 18:27:48 CET
Verified:
* Code review
* Update to new packages
* Functional tests:
  * server_password_change still works
  * timestamps are in the log file
* Advisories

Minor adjustment:
17001982d3 | Adjust advisory text
Comment 4 Christina Scheinig univentionstaff 2021-11-24 10:27:23 CET
Hopefully Bug 51535 was considered, when implementing the timestamps, because we have a lot of the workaround implemented in customer environments:

 diff -Nuar univention-samba4{.orig,}
--- univention-samba4.orig    2020-06-18 16:33:01.812634377 +0200
+++ univention-samba4    2020-06-18 16:32:10.169712325 +0200
@@ -83,6 +83,16 @@
         exit 1
     fi
 
-    test -x /etc/init.d/samba && /etc/init.d/samba restart
+    if test -x /etc/init.d/samba; then
+        /etc/init.d/samba stop
+        sleep 5
+        pids=$(pgrep smbd)
+        if [ -n "$pids" ]; then
+            pkill -9 smbd
+            /etc/init.d/samba stop
+        fi
+        /etc/init.d/samba start
+    fi
         
 fi

It would be quite fatal if the customers then run into the problem again because the workaround is overwritten
Comment 5 Ingo Steuwer univentionstaff 2021-11-24 12:41:41 CET
(In reply to Christina Scheinig from comment #4)
> Hopefully Bug 51535 was considered, when implementing the timestamps,
> because we have a lot of the workaround implemented in customer environments:
> 
>  diff -Nuar univention-samba4{.orig,}
> --- univention-samba4.orig    2020-06-18 16:33:01.812634377 +0200
> +++ univention-samba4    2020-06-18 16:32:10.169712325 +0200
> @@ -83,6 +83,16 @@
>          exit 1
>      fi
>  
> -    test -x /etc/init.d/samba && /etc/init.d/samba restart
> +    if test -x /etc/init.d/samba; then
> +        /etc/init.d/samba stop
> +        sleep 5
> +        pids=$(pgrep smbd)
> +        if [ -n "$pids" ]; then
> +            pkill -9 smbd
> +            /etc/init.d/samba stop
> +        fi
> +        /etc/init.d/samba start
> +    fi
>          
>  fi
> 
> It would be quite fatal if the customers then run into the problem again
> because the workaround is overwritten

I don't think so, as Bug 51535 hasn't changed and until now there was no connection between these Bugs.