Bug 54029 - Update French translation
Update French translation
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: General
UCS 5.0
Other Linux
: P5 normal (vote)
: UCS 5.0-1-errata
Assigned To: Johannes Lohmer
Florian Best
:
: 53973 (view as bug list)
Depends on:
Blocks: 54461
  Show dependency treegraph
 
Reported: 2021-11-04 10:28 CET by Florian Best
Modified: 2022-02-23 09:46 CET (History)
1 user (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Internationalization
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Best univentionstaff 2021-11-04 10:28:16 CET
We need to update (and re-translate) the French translation package for UCS 5.0-0.

Package is in base/univention-l10n-fr.

Documentation how to do it:
https://docs.software-univention.de/developer-reference-5.0.html#chap:translation
Comment 1 Florian Best univentionstaff 2022-01-28 20:37:49 CET
During the upgrade I see:

Object modified: cn=Univention-CanonicalRecipientRewriteEnable,cn=canonical-maps,cn=custom attributes,cn=univention,l=school,l=dev
Unknown or no action defined

Object modified: cn=self-service-protect-account,cn=entry,cn=portals,cn=univention,l=school,l=dev

in debian/univention-self-service.postinst:
→ "motify" instead of "modify"


Object modified: cn=univentionRadiusClientSharedSecret,cn=custom attributes,cn=univention,l=school,l=dev
E: Invalid Syntax: translationLongDescription: too many arguments
Object modified: cn=univentionRadiusClientVirtualServer,cn=custom attributes,cn=univention,l=school,l=dev

in debian/univention-radius.postinst:
→ the translation string contains double quotes which aren't quotes. Preferably use » « then.
Comment 2 Florian Best univentionstaff 2022-01-28 20:42:17 CET
Also line 130 in the joinscript: 80univention-radius.inst
Comment 3 Florian Best univentionstaff 2022-01-29 11:17:08 CET
I fixed those errors so that the Jenkins Tests are working again:

univention-radius (7.0.1-6)
bc9d5e97166b | Bug #54029: fix typo

univention-self-service (5.0.1-17)
3d8c828ed6b8 | fixup! Bug #54029: updated french translation of univention-self-service
Comment 4 Florian Best univentionstaff 2022-01-29 11:25:55 CET
ucslint says:

E:0006-2: management/univention-self-service/debian/univention-self-service.postinst: script contains 3 calls of univention-directory-manager or univention-admin - use a join script

→ please set this to the ignore list
Comment 5 Julia Bremer univentionstaff 2022-01-31 09:42:38 CET
Since this change was merged this new test is failing:
Would you please have a look Johannes?

60_umc.101_test_umc_frontend_i18n.TestI18N.test_with_content[js/umc/i18n/en/app.json] (from pytest) 


https://jenkins.knut.univention.de:8181/job/UCS-5.0/job/UCS-5.0-1/job/AutotestJoin/lastCompletedBuild/SambaVersion=no-samba,Systemrolle=master/testReport/60_umc.101_test_umc_frontend_i18n/TestI18N/test_with_content_js_umc_i18n_en_app_json_/
Comment 6 Florian Best univentionstaff 2022-01-31 23:31:56 CET
(In reply to Julia Bremer from comment #5)
> Since this change was merged this new test is failing:
> Would you please have a look Johannes?
> 
> 60_umc.101_test_umc_frontend_i18n.TestI18N.test_with_content[js/umc/i18n/en/
> app.json] (from pytest) 
> 
> 
> https://jenkins.knut.univention.de:8181/job/UCS-5.0/job/UCS-5.0-1/job/
> AutotestJoin/lastCompletedBuild/SambaVersion=no-samba,Systemrolle=master/
> testReport/60_umc.101_test_umc_frontend_i18n/TestI18N/
> test_with_content_js_umc_i18n_en_app_json_/

Ńo, this is caused by changes in univention-web-js 4.0.2-44 via Bug #54032 - with 4.0.1-43 it works again. That package has not been changed here.
Comment 7 Florian Best univentionstaff 2022-01-31 23:47:02 CET
OK: ucslint fixed
OK: debian/changelog fixed
OK: joinscript adjustments
→ we should further enhance this via Bug #54394 so that the translations aren't part of plain UCS anymore.
OK: postinst adjustments
OK: removal of UCR scripts (obsolete, no potral entries via UCR variables anymore)
OK: adjustments of univention-l10n for packaging other translations
OK: advisories
OK: debdiff of the prior changes in the univention-l10n-fr package
FYI: new is "ucs-test" but for me okay. Maybe useful for a test in the future.

# debdiff univention-l10n-fr_4.0.1-5A~5.0.0.202105171353_all.deb  univention-l10n-fr_4.0.1-6A~5.0.0.202201312309_all.deb 
[The following lists of changes regard files as different if they have
different names, permissions or owners.]

Files in second .deb but not in first
-------------------------------------
-rw-r--r--  root/root   /usr/lib/univention-portal/udm/fr.mo
-rw-r--r--  root/root   /usr/share/locale/fr/LC_MESSAGES/ucs-test-framework.mo
-rw-r--r--  root/root   /usr/share/locale/fr/LC_MESSAGES/ucs-test-selenium.mo
-rw-r--r--  root/root   /usr/share/locale/fr/LC_MESSAGES/univention-admin-handlers-ms.mo
-rw-r--r--  root/root   /usr/share/locale/fr/LC_MESSAGES/univention-management-console-module-admindiary.mo
-rw-r--r--  root/root   /usr/share/plymouth/themes/ucs/fr/LC_MESSAGES/univention-bootsplash.mo
-rw-r--r--  root/root   /usr/share/univention-management-console-frontend/js/umc/modules/i18n/fr/admindiary.json
-rw-r--r--  root/root   /usr/share/univention-management-console-frontend/js/umc/modules/i18n/fr/welcome.json
-rw-r--r--  root/root   /usr/share/univention-management-console/i18n/fr/admindiary.mo
-rw-r--r--  root/root   /usr/share/univention-management-console/i18n/fr/welcome.mo
-rw-r--r--  root/root   /usr/share/univention-portal/i18n/fr.json
-rw-r--r--  root/root   /usr/share/univention-web/js/umc/hooks/i18n/fr/univention_demo.json

Files in first .deb but not in second
-------------------------------------
-rw-r--r--  root/root   /etc/univention/templates/info/univention-l10n-fr.info
-rw-r--r--  root/root   /usr/share/locale/fr/LC_MESSAGES/ucr-variables.mo
-rw-r--r--  root/root   /usr/share/locale/fr/LC_MESSAGES/univention-management-console-handlers-cups.mo
-rw-r--r--  root/root   /usr/share/univention-portal/i18n/fr/main.json
-rw-r--r--  root/root   DEBIAN/conffiles
-rwxr-xr-x  root/root   /etc/univention/templates/scripts/ucr-l10n-fr
-rwxr-xr-x  root/root   DEBIAN/preinst
-rwxr-xr-x  root/root   DEBIAN/prerm

Control files: lines which differ (wdiff format)
------------------------------------------------
Depends: univention-l10n-dev (>= [-7.0.1), univention-config (>= 7.0.25)-] {+7.0.1)+}
Installed-Size: [-627-] {+747+}
Version: [-4.0.1-5A~5.0.0.202105171353-] {+4.0.1-6A~5.0.0.202201312309+}
Comment 8 Johannes Lohmer univentionstaff 2022-02-02 13:42:43 CET
A comprehensive update of the french translation was necessary. The tasks included:
​
- Fixing the tool to automatically build and update language packages based on changes in the source code. (univention-ucs-translation-merge)
- Removing the deprecated "fr/ucr-variables.po" translation file and implementation logic.
- Translating all new strings in the .po files.
- Updating all outdated strings in the .po files.
- Updating and completing the LDAP extended attribute and portal entries translations in several joinscripts.
- Adding an l10n-fr joinscript to activate univention-portal/udm/fr.mo
​
univention-self-service (5.0.1-16)
bc5dd39fe9fa | Bug #54029: Merge branch 'jlohmer/54029-french-translation-update' into 5.0-1
77019de31c1e | Bug #54029: updated french translation of univention-self-service
​
univention-self-service (5.0.1-15)
d62389d1d08a | Bug #54029: fix typos in docs, UCR variable descriptions and code comments
​
univention-saml.yaml
7050363c7e37 | Bug #54029: added build versions to advisory
bc5dd39fe9fa | Bug #54029: Merge branch 'jlohmer/54029-french-translation-update' into 5.0-1
cd89264031d4 | Bug #54029: updated french translation of univention-saml
​
univention-saml (7.0.4-18)
bc5dd39fe9fa | Bug #54029: Merge branch 'jlohmer/54029-french-translation-update' into 5.0-1
cd89264031d4 | Bug #54029: updated french translation of univention-saml
​
univention-samba4 (9.0.6-10)
d62389d1d08a | Bug #54029: fix typos in docs, UCR variable descriptions and code comments
​
univention-s4-connector (14.0.7-7)
d62389d1d08a | Bug #54029: fix typos in docs, UCR variable descriptions and code comments
​
univention-radius.yaml
7050363c7e37 | Bug #54029: added build versions to advisory
bc5dd39fe9fa | Bug #54029: Merge branch 'jlohmer/54029-french-translation-update' into 5.0-1
c76cdcbe63b8 | Bug #54029: updated french translation of univention-radius
​
univention-management-console-module-udm (10.0.1-20)
d62389d1d08a | Bug #54029: fix typos in docs, UCR variable descriptions and code comments
​
univention-management-console (12.0.12-20)
d62389d1d08a | Bug #54029: fix typos in docs, UCR variable descriptions and code comments
​
univention-maintenance-mode (3.0.0-2)
d62389d1d08a | Bug #54029: fix typos in docs, UCR variable descriptions and code comments
​
univention-mail-dovecot.yaml
7050363c7e37 | Bug #54029: added build versions to advisory
bc5dd39fe9fa | Bug #54029: Merge branch 'jlohmer/54029-french-translation-update' into 5.0-1
939bbbca32c1 | Bug #54029: updated french translation of univention-mail-dovecot
​
univention-mail-dovecot (6.0.3-6)
bc5dd39fe9fa | Bug #54029: Merge branch 'jlohmer/54029-french-translation-update' into 5.0-1
939bbbca32c1 | Bug #54029: updated french translation of univention-mail-dovecot
​
univention-mail-canonical-maps (8.0.0-2)
bc5dd39fe9fa | Bug #54029: Merge branch 'jlohmer/54029-french-translation-update' into 5.0-1
69160fc280c4 | Bug #54029: updated french translation of univention-mail-canonical-maps
​
univention-ldap.yaml
bc5dd39fe9fa | Bug #54029: Merge branch 'jlohmer/54029-french-translation-update' into 5.0-1
3e7c2352aad9 | Bug #54029: updated french translation of univention-ldap
​
univention-ldap (16.0.7-12)
7050363c7e37 | Bug #54029: added build versions to advisory
bc5dd39fe9fa | Bug #54029: Merge branch 'jlohmer/54029-french-translation-update' into 5.0-1
3e7c2352aad9 | Bug #54029: updated french translation of univention-ldap
​
univention-l10n.yaml
7050363c7e37 | Bug #54029: added build versions to advisory
bc5dd39fe9fa | Bug #54029: Merge branch 'jlohmer/54029-french-translation-update' into 5.0-1
68e1f8bfd69e | Bug #54029: fixed univention-ucs-translation-build-package

univention-fetchmail.yaml
7050363c7e37 | Bug #54029: added build versions to advisory
bc5dd39fe9fa | Bug #54029: Merge branch 'jlohmer/54029-french-translation-update' into 5.0-1
3873561f26d7 | Bug #54029: updated french translation of mail/univention-fetchmail
​
univention-fetchmail (13.0.1-3)
bc5dd39fe9fa | Bug #54029: Merge branch 'jlohmer/54029-french-translation-update' into 5.0-1
3873561f26d7 | Bug #54029: updated french translation of mail/univention-fetchmail
​
univention-directory-manager-modules.yaml
7050363c7e37 | Bug #54029: added build versions to advisory
bc5dd39fe9fa | Bug #54029: Merge branch 'jlohmer/54029-french-translation-update' into 5.0-1
68def3c948ba | Bug #54029: updated french translation of univention-directory-manager-modules
​
univention-directory-manager-modules (15.0.11-29)
bc5dd39fe9fa | Bug #54029: Merge branch 'jlohmer/54029-french-translation-update' into 5.0-1
68def3c948ba | Bug #54029: updated french translation of univention-directory-manager-modules
​
univention-demo-configuration (8.0.0-9)
bc5dd39fe9fa | Bug #54029: Merge branch 'jlohmer/54029-french-translation-update' into 5.0-1
91da6d7057cc | Bug #54029: updated french translation of test utils and demo-configuration
​
univention-demo-configuration (8.0.0-10)
9de405cfbfef | fixup! Bug #54029: updated french translation of test utils and demo-configuration
​
univention-appcenter (9.0.2-70)
d62389d1d08a | Bug #54029: fix typos in docs, UCR variable descriptions and code comments
​
extended-attribute (1.0-1)
bc5dd39fe9fa | Bug #54029: Merge branch 'jlohmer/54029-french-translation-update' into 5.0-1
706585cb679a | Bug #54029: [devdoc] updated french translation of example join script
Comment 9 Florian Best univentionstaff 2022-02-07 12:59:09 CET
There was still an error in the univention-portal postinst and ucslint override, which I fixed:
> 05a4447208 fixup! Bug #54029: updated french translation of univention-portal
> 349d7285a3 fixup! Bug #54029: updated french translation of univention-portal

OK: QA done mostly in comment 7
OK: registration of translation for UDM portal/* objects
OK: ucslint
OK: debian/changelog
OK: UMC and Portal is translated, I couldn't find untranslated modules/components. (The Appcenter App content is ofc not translated).
~OK?: The change password dialog in the portal is not translated
OK: diff between old and new LDAP entries:
> univention-ldapsearch -LLL > old.ldif
> univention-upgrade
> univention-ldapsearch -LLL > new.ldif
> /usr/bin/ldiff old.ldif new.ldif

FYI: I rebuilt the affected packages, @Johannes, please adjust the YAML version numbers accordingly.
Comment 11 Johannes Lohmer univentionstaff 2022-02-23 09:46:25 CET
*** Bug 53973 has been marked as a duplicate of this bug. ***