First Last Prev Next    This bug is not in your last search results.
Bug 54047 - Missing quoting in univention-lib/shell/umc.sh
Missing quoting in univention-lib/shell/umc.sh
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UMC (Generic)
UCS 5.0
Other Linux
: P5 normal (vote)
: UCS 5.0-1-errata
Assigned To: Juan Carlos
Peter Stoll
https://git.knut.univention.de/univen...
:
Depends on: 53465
Blocks:
  Show dependency tree / graph
 
Reported: 2021-11-10 11:58 CET by Jürn Brodersen
Modified: 2022-06-01 16:51 CEST (History)
3 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 5: Major Usability: Impairs usability in key scenarios
Who will be affected by this bug?: 5: Will affect all installed domains
How will those affected feel about the bug?: 2: A Pain – users won’t like this once they notice it
User Pain: 0.286
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): bitesize
Max CVSS v3 score:

Attachments
Possible patch (following shellcheck recommendation) (960 bytes, patch)
2021-11-10 11:58 CET, Jürn Brodersen 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jürn Brodersen univentionstaff 2021-11-10 11:58:53 CET 
Created attachment 10863 [details]
Possible patch (following shellcheck recommendation)

Missing quoting in univention-lib/shell/umc.sh

Due to some missing quoting, the package "ucs-school-umc-exam" prints a lot of error during installation:

'''
find: ‘/usr/share/doc/ucs-school-umc-exam/examples/GPO/lockUSB/Windows’: No such file or directory
find: ‘XP’: No such file or directory
find: ‘/usr/share/doc/ucs-school-umc-exam/examples/GPO/lockUSB/Windows’: No such file or directory
find: ‘XP/admx’: No such file or directory
...
'''

How to reproduce:
Install the "ucs-school-umc-exam" package.

See the attached patch for the exact problem.
Comment 2 Juan Carlos univentionstaff 2022-05-17 08:22:54 CEST 
Suggested patch applied. Now UMC can detect files with whitespace in its filename, so error messages will no longer appear during updates and caching is improved. 
Fixed on version 9.0.11-11.
See commit 7baeea8c
Comment 3 Peter Stoll univentionstaff 2022-06-01 13:19:57 CEST 
YAML OK
Issue reproduced and successfully retested.
First Last Prev Next    This bug is not in your last search results.