Univention Bugzilla – Bug 54115
Integrate expiration date into the school library
Last modified: 2021-11-29 07:49:59 CET
Implemented on oschwieg/54115 - Since it is only visible if chosen (optional field) and I did not include it in the default visible fields, no screenshots and documentation should need adaptation. (What is actually desired here?) - This field has the same limitation as the birthday field in that it can not be unset, once it was set to a value (Does it need to be 'fixed' within the Dienstleistung?) - I am not aware of any particular changes needed in the importer to accommodate the new field?
- Since it is only visible if chosen (optional field) and I did not include it in the default visible fields, no screenshots and documentation should need adaptation. (What is actually desired here?) -> it is an optional field, so we decided no screenshots. we added a section, which mentions the ucr-v ucsschool/wizards/schoolwizards/users/optional_visible_fields which is needed to set these. - This field has the same limitation as the birthday field in that it can not be unset, once it was set to a value (Does it need to be 'fixed' within the Dienstleistung?) -> we decided to fix this: So far we had this check in base.py:_alter_udm_obj if value is not None and attr.map_to_udm which leads to None values being ignored. The solution includes introducing map_if_none in the class Attribute. Birthday & UserExpirationDate set the value to True, the default is False. UCS: 4.4-8 errata1072 Installed: cups=2.2.1 samba4=4.10 squid=3.5 ucsschool=4.4 v9 packages are merge & build in 4.4 and wait for jenkins Package: ucs-school-lib Version: 12.2.37A~4.4.0.202111231618 Branch: ucs_4.4-0 Scope: ucs-school-4.4 Package: ucs-school-import Version: 17.0.74A~4.4.0.202111231620 Branch: ucs_4.4-0 Scope: ucs-school-4.4 Package: ucs-school-umc-wizards Version: 11.0.4A~4.4.0.202111231623 Branch: ucs_4.4-0 Scope: ucs-school-4.4 Package: ucs-test-ucsschool Version: 6.0.253A~4.4.0.202111231625 Branch: ucs_4.4-0 Scope: ucs-school-4.4
FYI: We did not add a new schoollib- test, because person.verify checks the expiration_date implicitly in the import tests.
fixed tests Package: ucs-test-ucsschool Version: 6.0.254A~4.4.0.202111240951 Branch: ucs_4.4-0 Scope: ucs-school-4.4
I had to add something I was missing to commit first. Translation for the UMC and proper optional handling. Package: ucs-school-umc-wizards Version: 11.0.6A~4.4.0.202111250805 Branch: ucs_4.4-0 Scope: ucs-school-4.4
Changelog&Advisory: OK Manual&automatic tests: OK
Errata updates for UCS@school 4.4 v9 have been released. https://docs.software-univention.de/changelog-ucsschool-4.4v9-de.html If this error occurs again, please clone this bug.