Bug 54153 - Location and name of directory reports is not configurable
Location and name of directory reports is not configurable
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: General
UCS 4.4
Other Linux
: P5 normal (vote)
: UCS 5.0-1-errata
Assigned To: Ildefonso González Sánchez
Arvid Requate
https://git.knut.univention.de/univen...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2021-11-26 11:27 CET by Dirk Schnick
Modified: 2022-01-26 17:21 CET (History)
2 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 2: Improvement: Would be a product improvement
Who will be affected by this bug?: 1: Will affect a very few installed domains
How will those affected feel about the bug?: 1: Nuisance – not a big deal but noticeable
User Pain: 0.011
Enterprise Customer affected?: Yes
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number: 2021112421000383
Bug group (optional): bitesize
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Schnick univentionstaff 2021-11-26 11:27:31 CET
As I explained the customer how to generate own reports I was wondering that univention-directory-reports has no option for the output location and/or name.
If you want to use the report for automatic actions this is more complicated. 

Also /tmp is from my point of view no good place if you want to keep the reports you need to move them manually.
Comment 1 Arvid Requate univentionstaff 2021-11-26 13:57:44 CET
I'd propose to add an option -o or similar where the caller can specify a different file path
and the script should then finally move the created file from /tmp to the new location and name.
Comment 2 Ildefonso González Sánchez univentionstaff 2022-01-03 18:07:18 CET
Changes: isanchez/54153-Location_and_name_of_directory_reports_is_not_configurable
Comment 3 Ildefonso González Sánchez univentionstaff 2022-01-10 13:34:15 CET
The UCS version 4.4
The univention directory reports module allow a couple of new arguments.
 * The argument --output-dir (-o) allow select the output report 
   directory by the user.
 * The argument --file-name (-f) allow select the output report file
   name by the user.
Comment 4 Florian Best univentionstaff 2022-01-10 14:13:23 CET
1. please refer your merge request URL.

2. the target milestone is set to 5.0-1-errata but your fixes has been committed for UCS 4.4-8-errata.

3. please don't merge a merge request which is not reviewed and accepted by the reviewer.

4. I made more comments on the merge request which should be addressed:
https://git.knut.univention.de/univention/ucs/-/merge_requests/224

5. When setting a bug to RESOLVED FIXED please include the commits, e.g.:

univention-directory-reports.yaml
e20141f9824f | Bug #54153: update YAML for univention-directory-reports
8f2eb5779367 | Bug #54153: include univention-directory-reports YAML file

univention-directory-reports (11.0.0-6)
38c4ba76c486 | Bug #54153: default output path field in config.ini file
2458a3d8912e | Bug #54153 include changes for use a custom file name output report
209b86805f0b | Bug #54153: Location configure location of reports with -o argument or default configuration file option

6. please squash or cleanup your commits before merging so that interim changes are not visible anymore.
Comment 5 Ildefonso González Sánchez univentionstaff 2022-01-12 14:22:17 CET
(In reply to Florian Best from comment #4)
> 1. please refer your merge request URL.
> 
> 2. the target milestone is set to 5.0-1-errata but your fixes has been
> committed for UCS 4.4-8-errata.
> 
> 3. please don't merge a merge request which is not reviewed and accepted by
> the reviewer.
> 
> 4. I made more comments on the merge request which should be addressed:
> https://git.knut.univention.de/univention/ucs/-/merge_requests/224
> 
> 5. When setting a bug to RESOLVED FIXED please include the commits, e.g.:
> 
> univention-directory-reports.yaml
> e20141f9824f | Bug #54153: update YAML for univention-directory-reports
> 8f2eb5779367 | Bug #54153: include univention-directory-reports YAML file
> 
> univention-directory-reports (11.0.0-6)
> 38c4ba76c486 | Bug #54153: default output path field in config.ini file
> 2458a3d8912e | Bug #54153 include changes for use a custom file name output
> report
> 209b86805f0b | Bug #54153: Location configure location of reports with -o
> argument or default configuration file option
> 
> 6. please squash or cleanup your commits before merging so that interim
> changes are not visible anymore.

I just revert the changes of the previous merge request and i create a new one for the right Target Milestone version.

https://git.knut.univention.de/univention/ucs/-/merge_requests/236
Comment 7 Arvid Requate univentionstaff 2022-01-26 11:21:18 CET
Verified:
* Code review: Ok
* Package update: Ok
* Functional test: Ok
* Advisory: Adjusted, see below
* Documentation: No change required (The tool is mentioned in the manual but the options are in --help)

dcbf5fa367] fixup! https://git.knut.univention.de/univention/ucs/-/merge_requests/236#note_48468
Comment 8 Arvid Requate univentionstaff 2022-01-26 11:55:57 CET
FYI: A run of https://jenkins.knut.univention.de:8181/job/UCS-5.0/job/UCS-5.0-1/job/ErrataValidation/ confirmed that advisory and metadata are consistent and the errata update can be released.