Bug 54310 - Kelvin is not installable on Backup Directory Nodes
Summary: Kelvin is not installable on Backup Directory Nodes
Status: CLOSED FIXED
Alias: None
Product: UCS@school
Classification: Unclassified
Component: HTTP-API (Kelvin)
Version: UCS@school 5.0
Hardware: Other Linux
: P5 normal
Target Milestone: ---
Assignee: Tobias Wenzel
QA Contact: Daniel Tröder
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-07 11:13 CET by Johannes Keiser
Modified: 2022-01-12 15:52 CET (History)
2 users (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Customer ID:
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Johannes Keiser univentionstaff 2022-01-07 11:13:43 CET 
For the ID Broker setup we want to be able to install the Kelvin REST API app on a Backup Directory Node. This is currently not possible.

Note: Kelvin should use the UDM Rest API on the host (itself) and not directly the Primary.
Comment 1 Daniel Tröder univentionstaff 2022-01-10 16:46:58 CET 
REOPEN:
* raise VERSION in join script (appcenter/inst)

* in kelvin-api/ucsschool/kelvin/routers/school.py line 322 "ldap/master" was correct
* in ucs-school-lib/modules/ucsschool/lib/models/school.py lines 295, 781 and 928 "ldap/master" were correct
* in ucs-school-lib/modules/ucsschool/lib/models/network.py line 154 "ldap/master" was correct
* in ucs-school-lib/modules/ucsschool/lib/tests/conftest.py line 572, 619 and 721 "ldap/master" were correct
* in ucs-school-lib/modules/ucsschool/lib/tests/test_create_ou.py line 119 "ldap/master" was correct
* in ucs-school-lib/modules/ucsschool/lib/tests/test_validation_users.py line 74 "ldap/master" was correct
* in univention-directory-manager-modules-slim/univention/admin/uldap_docker.py lines 124, 126, 167 and 168 "ldap/master" were correct
Comment 2 Tobias Wenzel univentionstaff 2022-01-11 09:31:31 CET 
Thanks for the QA!

I reverted the changes. We also needed to pass uldap.machineconnection ldap_master=False, if kelvin is not running on the master.

also today is the "burnout-day" of git+git

https://github.blog/2021-09-01-improving-git-protocol-security-github/


[twenzel/kelvin/54310_install_kelvin_on_backups] 66d080eec Bug #54310: change git protocol
[twenzel/kelvin/54310_install_kelvin_on_backups] 1f5800d39 Bug #54310: add changelog & version
[twenzel/kelvin/54310_install_kelvin_on_backups] c2c3cb7fd Bug #54310: install kelvin on backups


docker-upload.software-univention.de/ucsschool-kelvin-rest-api   1.5.2               3121d8d7216c
Comment 3 Tobias Wenzel univentionstaff 2022-01-11 14:28:33 CET 
As discussed, I squashed & build the changes in feature/kelvin

[feature/kelvin] f7a45946f Bug #54310: change git protocol
[feature/kelvin] 9045147b4 Bug #54310: add changelog & version
[feature/kelvin] c533cc4b6 Bug #54310: install kelvin on backups
Comment 4 Daniel Tröder univentionstaff 2022-01-11 17:00:05 CET 
OK: code review
OK: installation on backup
OK: manual tests
OK: automatic tests
OK: Jenkins
Comment 6 Tobias Wenzel univentionstaff 2022-01-12 15:52:15 CET 
has been released with version 1.5.2

if this error occurs again, please clone this bug.