Bug 54359 - potential UCR variable inconsistency
potential UCR variable inconsistency
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: AD Takeover
UCS 5.0
amd64 Linux
: P5 normal (vote)
: UCS 5.0-1-errata
Assigned To: Nikola Radovanovic
Julia Bremer
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2022-01-19 11:50 CET by Nikola Radovanovic
Modified: 2022-02-23 16:29 CET (History)
2 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nikola Radovanovic univentionstaff 2022-01-19 11:50:37 CET
In AD_Takeover_Finalize class, method create_virtual_IP_alias (possibly in other places also - have not check yet), setting UCR variables regarding network is not done via ucr_update method, thus risking inconsistency.

Also, maybe guess_broadcast local variable needs to be set when IPv6 detected, or skipped from the update since uninitialized atm
Comment 2 Florian Best univentionstaff 2022-01-19 14:25:19 CET
I don't understand this issue.
What is the difference between settings UCR variables via Python or via subprocess and command line client?

Is the problem that some UCR-Variables which are not set (None) are unset via ucr_update() ?

In the merge request there is "interfaces/%s/ipv6/acceptRA": False" - I think a real boolean is wrong here and should be instead the string "false".
Comment 3 Nikola Radovanovic univentionstaff 2022-02-10 10:45:55 CET
6d5dbdd400 | Potential UCR variable inconsistency
4ae14d68e4 | Advisory update
Comment 4 Julia Bremer univentionstaff 2022-02-14 14:40:25 CET
Code review: OK
Yaml: OK
Ad takeover: OK
AD takeover product tests: OK

Verified