Bug 54368 – remove_from_groups_of_school() doesn't remove school admins from admins-OU group

Bug 54368 - remove_from_groups_of_school() doesn't remove school admins from admins-OU group


Summary:	remove_from_groups_of_school() doesn't remove school admins from admins-OU group

Status:	CLOSED FIXED

Product:	UCS@school
Classification:	Unclassified
Component:	Ucsschool-lib
Version:	UCS@school 4.4
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS@school 5.0 v2-errata
Assigned To:	Fabian Wilhelm
QA Contact:	Amir Teymuri

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2022-01-24 09:21 CET by Oliver Friedrich
Modified:	2023-04-19 10:17 CEST (History)
CC List:	5 users (show)

See Also:	55986
What kind of report is it?:	Bug Report
What type of bug is this?:	3: Simply Wrong: The implementation doesn't match the docu
Who will be affected by this bug?:	2: Will only affect a few installed domains
How will those affected feel about the bug?:	2: A Pain – users won’t like this once they notice it
User Pain:	0.069
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):	bitesize
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Oliver Friedrich

2022-01-24 09:21:13 CET

When I invoke `remove_from_groups_of_school` on a school admin user object, then the group admins-<old school> is not deleted from the object. This works as expected for teachers & students.

Example code:
```
from ucsschool.lib.models.user import User
import univention.admin.uldap

lo = univention.admin.uldap.getAdminConnection()[0]

dn="uid=olitestadmin1,cn=admins,cn=users,ou=OlisTestschule,${ldap_base}" 
user_object = User.from_dn(dn, None, lo)

user_object.get_specific_groups(lo)

['cn=Domain Users OlisTestschule,cn=groups,ou=OlisTestschule,dc=schulportal-sh,dc=intranet',
 'cn=admins-olistestschule,cn=ouadmins,cn=groups,${ldap_base}']

user_object.remove_from_groups_of_school(user_object.school, lo)
```
→ the user is still member of the group 'cn=admins-olistestschule,cn=ouadmins,cn=groups,${ldap_base}'

Comment 2 Fabian Wilhelm

2022-07-11 12:49:27 CEST

cc2c9f7dd Bug #54368: advisory and changelog
5e83209b7 Bug #54368: add test for remove_from_groups_of_school
ddf225a44 Bug #54368: fix remove_from_groups_of_school

Comment 3 Amir Teymuri

2022-07-28 16:32:36 CEST

Package: ucs-school-lib
Version: 13.0.21A~5.0.0.202207281220
Branch: ucs_5.0-0
Scope: ucs-school-5.0

Comment 4 Jürn Brodersen

2022-08-04 18:35:50 CEST

UCS@school 5.0 v3 has been released.

https://docs.software-univention.de/changelog-ucsschool-5.0v3-de.html

If this error occurs again, please clone this bug.