Bug 54432 - Rejected changes from AD are not resynced
Rejected changes from AD are not resynced
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: AD Connector
UCS 4.4
Other Linux
: P5 normal (vote)
: UCS 4.4-9-errata
Assigned To: Julia Bremer
Arvid Requate
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2022-02-08 21:40 CET by Julia Bremer
Modified: 2022-04-27 16:20 CEST (History)
2 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 3: Simply Wrong: The implementation doesn't match the docu
Who will be affected by this bug?: 1: Will affect a very few installed domains
How will those affected feel about the bug?: 2: A Pain – users won’t like this once they notice it
User Pain: 0.034
Enterprise Customer affected?:
School Customer affected?: Yes
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number: 2022021121000234, 2022021121000181
Bug group (optional):
Max CVSS v3 score:


Attachments
patch (761 bytes, patch)
2022-02-08 21:40 CET, Julia Bremer
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Julia Bremer univentionstaff 2022-02-08 21:40:12 CET
Created attachment 10914 [details]
patch

With Bug #54147, we introduced a retry_count for rejects. Per default, rejects should only be resynced 10 times. This is configurable via UCR variable connector/ad/max_retry_rejected.

With commit b2685acdae690 the real default was accidentally set to zero. That way, rejects are not retried at all. This was done only in UCS 4.4
Comment 1 Julia Bremer univentionstaff 2022-02-10 18:41:57 CET
Applied the patch.

e62f422fb0 Bug #54432: yaml
37507edb1d Bug #54432: Set default resyncs to 10, as it is documented
Comment 2 Erik Damrose univentionstaff 2022-02-11 11:05:25 CET
OK: Fixed value to the documented default
OK: u-ad-connector 13.0.0-66A~4.4.0.202202101840
OK: No fix in UCS 5 necessary
OK: yaml
Verified
Comment 3 Florian Best univentionstaff 2022-02-11 23:00:30 CET
hmm, resyncing rejects only 10 times causes that we will loose rejects and don't get external feedback reports about tracebacks (real errors) anymore.
I think 0 (or -1) should be interpreted as resync forever - like it has been before.
Comment 5 Julia Bremer univentionstaff 2022-04-27 12:47:36 CEST
Version 13.0.0-66A~4.4.0.202112081254 was released because the package was imported to release 4.0 instead of 4.4

Cherrypicked the Version 13.0.0-67A which contained the fix to 4.4(-9)
Comment 6 Julia Bremer univentionstaff 2022-04-27 12:58:31 CEST
6f4736997b Bug #54432: New build in 4.4-9
Comment 7 Arvid Requate univentionstaff 2022-04-27 13:34:54 CEST
Verified:
* Package update
* Advisory