Bug 54467 - mailPrimaryAddress widget should suggest available mail domains
mailPrimaryAddress widget should suggest available mail domains
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UMC - Users
UCS 5.0
Other Linux
: P5 normal (vote)
: UCS 5.0-1-errata
Assigned To: Florian Best
Dirk Wiesenthal
https://git.knut.univention.de/univen...
:
: 32142 (view as bug list)
Depends on: 38762 54840
Blocks:
  Show dependency treegraph
 
Reported: 2022-02-17 15:31 CET by Florian Best
Modified: 2022-06-08 17:47 CEST (History)
3 users (show)

See Also:
What kind of report is it?: Feature Request
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Usability
Max CVSS v3 score:


Attachments
Screenshot of possible variants (12.47 KB, image/png)
2022-02-17 19:12 CET, Florian Best
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Best univentionstaff 2022-02-17 15:31:31 CET
A new widget for the users/user mailPrimaryAddress should suggest all available mail domains during typing.

Currently one gets a error message after saving the object when the specified mail/domain object doesn't exists.
Comment 1 Florian Best univentionstaff 2022-02-17 19:12:02 CET
Created attachment 10920 [details]
Screenshot of possible variants
Comment 2 Daniel Tröder univentionstaff 2022-02-18 08:36:15 CET
What about creating a text entry field for the local part and a drop-down besides it with only the available domains? (Unless the syntax was changed to "string".)
Comment 3 Florian Best univentionstaff 2022-02-18 08:39:51 CET
(In reply to Daniel Tröder from comment #2)
> What about creating a text entry field for the local part and a drop-down
> besides it with only the available domains? (Unless the syntax was changed
> to "string".)

Isn't that what you see right in the screenshot?
We decided for the left variant as it is much more simple in the implementation, it looks better and it's OOTB copy&pasteable.
So, after typing in the @ all mail domains are suggested as completion.
Comment 4 Daniel Tröder univentionstaff 2022-02-18 09:10:33 CET
(In reply to Florian Best from comment #3)
> (In reply to Daniel Tröder from comment #2)
> > What about creating a text entry field for the local part and a drop-down
> > besides it with only the available domains? (Unless the syntax was changed
> > to "string".)
> 
> Isn't that what you see right in the screenshot?
> We decided for the left variant as it is much more simple in the
> implementation, it looks better and it's OOTB copy&pasteable.
> So, after typing in the @ all mail domains are suggested as completion.

I was thinking that it does still allow to type in a wrong domain.
But from a UX point of view the completion solution is much better :)
And the case where a user does type / copy&paste in a wrong domain should be seldom and will still be caught by UDM with a helpful error message.
... so forget my previous post - the completion solution is best ;)
Comment 5 Florian Best univentionstaff 2022-02-18 09:17:02 CET
(In reply to Daniel Tröder from comment #4)
> I was thinking that it does still allow to type in a wrong domain.
It does still allow to type a wrong domain but you will get the same error message as before when trying to save the object then.
Comment 6 Florian Best univentionstaff 2022-02-21 13:45:55 CET
*** Bug 32142 has been marked as a duplicate of this bug. ***
Comment 7 Florian Best univentionstaff 2022-04-22 01:46:20 CEST
A new widget which suggests the available mail domains during typing has been added (Thanks to Johannes Kaiser).
The syntax class for mailPrimaryAddress has been adjusted to map the widget to the new MailBox widget, do validation like before, display the widget also in the search field when selecting to search for mailPrimaryAddress.

univention-web.yaml
fed0111b6608 | YAML Bug #54467

univention-web (4.0.2-50)
08f7e728d0e8 | Bug #54467: add umc.widgets.MailBox

univention-directory-manager-modules.yaml
fed0111b6608 | YAML Bug #54467

univention-directory-manager-modules (15.0.11-44)
6fa7fd83d5ad | Bug #54467: add widget for users/user:mailPrimaryAddress
Comment 8 Dirk Wiesenthal univentionstaff 2022-06-08 12:59:22 CEST
YAML: OK
Code review: OK
Manual tests: OK