Bug 54501 - Cleanup new listener API
Summary: Cleanup new listener API
Status: CLOSED FIXED
Alias: None
Product: UCS
Classification: Unclassified
Component: Listener (univention-directory-listener)
Version: UCS 5.0
Hardware: Other Linux
: P5 normal
Target Milestone: UCS 5.0-2
Assignee: Daniel Tröder
QA Contact: Philipp Hahn
URL: https://git.knut.univention.de/univen...
Keywords:
: 54506 (view as bug list)
Depends on:
Blocks: 54502 54506
  Show dependency tree / graph
 
Reported: 2022-03-03 11:49 CET by Daniel Tröder
Modified: 2022-09-27 15:23 CEST (History)
0 users

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Cleanup
Customer ID:
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Tröder univentionstaff 2022-03-03 11:49:05 CET 
* The ListenerModuleConfiguration.get_configuration() method is only used by __repr__(), deprecate it.
* Non-relative imports make it harder for linters and IDEs to follow the imports.
Comment 1 Daniel Tröder univentionstaff 2022-03-03 11:58:52 CET 
There is MR for this: https://git.knut.univention.de/univention/ucs/-/merge_requests/295

It consists of 2 commits: one keeping the old functionality, just deprecating the method name, the other deprecating the functionality as well. The 2nd is optional.
If the 2nd is desired, they'd be squashed.
Comment 2 Daniel Tröder univentionstaff 2022-06-21 16:28:59 CEST 
*** Bug 54506 has been marked as a duplicate of this bug. ***
Comment 3 Daniel Tröder univentionstaff 2022-06-21 17:01:47 CEST 
It was to much trouble to rebase the branch dtroeder/54501_udl_config_cleanup upon 5.0-2, so I created a new branch: dtroeder/54501_udl_config_cleanup_5.0-2

I contains one more commit, that:

* removes ListenerModuleConfiguration.get_configuration()
* removes a duplicate set entry

and a commit for the changelog.
Comment 4 Daniel Tröder univentionstaff 2022-06-23 09:08:14 CEST 
[5.0-2] 6d797fabaa Bug #54501: deprecate ListenerModuleConfiguration.get_configuration() and some cleanup
[5.0-2] ba2cadd913 Bug #54501: prepare complete removal of deprecated ListenerModuleConfiguration.get_configuration()
[5.0-2] c091ff5bec Bug #54501: fix static type hint, indent, add deprecation warning
[5.0-2] 2213b5648f Bug #54501: remove ListenerModuleConfiguration.get_configuration()
[5.0-2] 6ea675ab5a Bug #54501: changelog
[5.0-2] d5c902962a Bug #54501: Merge branch 'dtroeder/54501_udl_config_cleanup_5.0-2' into 5.0-2

Package: univention-directory-listener
Version: 14.0.6-2A~5.0.0.202206230904
Branch: ucs_5.0-0
Scope: ucs5.0-2
Comment 5 Philipp Hahn univentionstaff 2022-06-24 17:35:03 CEST 
OK: git diff e3e0a3bfe4..6ea675ab5a
OK: changelog
OK: https://jenkins2022.knut.univention.de/job/UCS-5.0/job/UCS-5.0-2/
Comment 6 Florian Best univentionstaff 2022-07-04 14:08:18 CEST 
UCS 5.0-2 has been released.

https://docs.software-univention.de/release-notes-5.0-2-en.html

If this error occurs again, please clone this bug.