Description Ole Schwiegert 2022-04-08 08:13:50 CEST

+++ This bug was initially created as a clone of Bug #54535 +++

ucsschool-roles with a format other than role:school:context will raise errors, e.g. in the umc

Interner Server-Fehler in "schoolwizards/users/query (schoolwizards/users)".
Request: schoolwizards/users/query (schoolwizards/users)


ucsschool/lib/models/validator.py

    errors.append(cls.validate_part_of_school(roles, schools))
  File "/usr/lib/python2.7/dist-packages/ucsschool/lib/models/validator.py", line 228, in validate_part_of_school
    missing_schools = set([s for r, c, s in roles if c == "school" and s.lower() not in schools])
ValueError: need more than 2 values to unpack


These errors come from an incorrect of the school role, but we should log an error with a better description of whats wrong.


...
e.g. the function split_roles could be refactored into one of the validation classes, log and a) return only values as tuples (r,c,s) or b) return an empty list.


The changes have to be implemented for the Kelvin API as well!