First Last Prev Next    This bug is not in your last search results.
Bug 54688 - "map acl inherit = yes" share configuration broken since UCS 5.0
"map acl inherit = yes" share configuration broken since UCS 5.0
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UMC - Shares
UCS 5.0
Other Linux
: P5 normal (vote)
: UCS 5.0-1-errata
Assigned To: Florian Best
Arvid Requate
: python3-migration
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2022-04-25 15:20 CEST by Florian Best
Modified: 2022-04-27 16:11 CEST (History)
0 users

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): bitesize, Regression
Max CVSS v3 score:
best: Patch_Available+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Best univentionstaff 2022-04-25 15:20:35 CEST 
Since the Python3 migration / UCS 5.0 the setting for "map acl inherit = yes" in a share definition does not work anymore.

@diff --git services/univention-samba4/samba-shares.py services/univention-samba4/samba-shares.py
index 3cd34b42e2..b7b0f30f99 100644
--- services/univention-samba4/samba-shares.py
+++ services/univention-samba4/samba-shares.py@ -239,3 +239,3 @@ def handler(dn, new, old, command):
                        # acl and inherit -> map acl inherit (Bug #47850)
-                       if '1' in new.get('univentionShareSambaNtAclSupport', []) and '1' in new.get('univentionShareSambaInheritAcls', []):
+                       if b'1' in new.get('univentionShareSambaNtAclSupport', []) and b'1' in new.get('univentionShareSambaInheritAcls', []):
                                print('map acl inherit = yes', file=fp)
Comment 1 Florian Best univentionstaff 2022-04-25 17:01:38 CEST 
I wanted to push it as Merge Request but accidentally pushed directly to 5.0-1.

Therefor here we go:
The fix has been added in both univention-samba and univention-samba4 listeners.
A resync of the listener module is done in postinst only if there are objects needed to be fixed.

univention-samba4.yaml
0ae11a7f56de | Bug #54688: fix support for shares "map acl inherit = yes"

univention-samba4 (9.0.7-1)
0ae11a7f56de | Bug #54688: fix support for shares "map acl inherit = yes"

univention-samba4 (9.0.6-12)
7da130f5689f | Bug #54688: resync listener on affected systems
bb26dc4f7ff3 | fixup! Bug #54688: fix support for shares "map acl inherit = yes"

univention-samba.yaml
0ae11a7f56de | Bug #54688: fix support for shares "map acl inherit = yes"

univention-samba (14.0.5-5)
7da130f5689f | Bug #54688: resync listener on affected systems
0ae11a7f56de | Bug #54688: fix support for shares "map acl inherit = yes"
Comment 2 Arvid Requate univentionstaff 2022-04-26 22:28:16 CEST 
Verified:
* Code review
* Advisory
First Last Prev Next    This bug is not in your last search results.