Bug 54738 – Migrate generate_appliance to Python 3

Bug 54738 - Migrate generate_appliance to Python 3


Summary:	Migrate generate_appliance to Python 3

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	General
Version:	UCS 5.0
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS 5.0-1-errata
Assigned To:	Florian Best
QA Contact:	Philipp Hahn

URL:
Keywords:	python3-migration

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2022-05-09 21:40 CEST by Florian Best
Modified:	2022-08-17 13:25 CEST (History)
CC List:	2 users (show)

See Also:	45426 55107
What kind of report is it?:	Development Internal
What type of bug is this?:	---
Who will be affected by this bug?:	---
How will those affected feel about the bug?:	---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):	Appliance
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Florian Best

2022-05-09 21:40:06 CEST

test/generate-appliance/bin/generate_appliance is not yet migrated to Python 3.

Comment 1 Florian Best

2022-05-09 22:03:49 CEST

1af2094f724e | Bug #54738: add Python 3 compatibility
c8ea9eb6b1f0 | Bug #54738: Python 3 compatibility for encode_vmware_uuid()

TODOs:
* change dependencies in debian/control
* change hashbang
* get VMDKstream in Python 3 compatible
* check if key.set_contents_from_string(part) works with bytes or migrate to use set_contents_from_file().

Comment 2 Philipp Hahn

2022-05-10 09:26:28 CEST

Please stop this now as your works conflicts with #dist work on Bug #45426
Next time please ask BEFORE you start changing code: At least work on a FB instead of committing directly to main.

Comment 3 Florian Best

2022-05-20 12:03:51 CEST

(In reply to Philipp Hahn from comment #2)
> Please stop this now as your works conflicts with #dist work on Bug #45426
> Next time please ask BEFORE you start changing code: At least work on a FB
> instead of committing directly to main.

OK, everything else will be done via Bug #45426.

Comment 4 Philipp Hahn

2022-05-30 14:13:51 CEST

OK: 1af2094f724e
OK: c8ea9eb6b1f0

Nothing to release as test/generate-appliance/ is internal only.

Comment 5 Florian Best

2022-08-17 13:25:42 CEST

Further fixes are necessary, they are part of the branch `phahn/45426genAppliance`.